activemerchant/offsite_payments

A simple and unified API to handle dozens of different offsite payment pages.

offsite_payments's Issues

notify_url for ipay88 integration does not work

I had tried notify_url in my code but the HTML code "BackendURL" which is supposed to be generated after using the notify_url method does not render in my HTML.

example:
<% service.notify_url url_for(:only_path => true, :action => 'backendurl') %>

https://github.com/Shopify/offsite_payments/blob/master/lib/offsite_payments/integrations/ipay88.rb

The code part:
mapping :notify_url, "BackendURL"

adding Errno::ETIMEDOUT rescue for pagseguro

Issue by celsodantas
Wednesday Jun 04, 2014 at 18:37 GMT
Originally opened as activemerchant/active_merchant#1245

---

@odorcicd @bslobodin

This adds another rescue for PagSeguro in case of a timeout.

Why don't we use a HTTP client like HTTParty to avoid this?

---

celsodantas included the following code: https://github.com/Shopify/active_merchant/pull/1245/commits

Mobikwik Wallet Integration

Issue by mobikwikwallet
Sunday Apr 06, 2014 at 08:49 GMT
Originally opened as activemerchant/active_merchant#1106

---

---

mobikwikwallet included the following code: https://github.com/Shopify/active_merchant/pull/1106/commits

QIWI support

Issue by pierre
Monday May 05, 2014 at 15:13 GMT
Originally opened as activemerchant/active_merchant#1164

---

Support for the QIWI payment gateway (https://qiwi.com/).

Integration testing was performed with the Kill Bill QIWI plugin (https://github.com/killbill/killbill-qiwi-plugin).

---

pierre included the following code: https://github.com/Shopify/active_merchant/pull/1164/commits

Add Coinbase integration

Issue by isaacwaller
Thursday Nov 14, 2013 at 09:00 GMT
Originally opened as activemerchant/active_merchant#915

---

Coinbase (https://coinbase.com/) merchant tool integration for Active Merchant. Information on Coinbase's merchant offerings can be found here: https://coinbase.com/merchants

The integration is fairly simple, a api call is made to Coinbase to create the form in the Helper and the callback is verified in the Notification module.

Thanks!

---

isaacwaller included the following code: https://github.com/Shopify/active_merchant/pull/915/commits

Added 'role' attribute to hidden tag fields of payment service form.

Issue by divineforest
Friday Oct 11, 2013 at 09:30 GMT
Originally opened as activemerchant/active_merchant#878

---

Without this change it's not possible to programmatically find these input elements by Javascript integration-independently because fields like "order" will have other actual names as set by particular service mappings.

With this patch "order" input for example for Paysbuy integration will be:

<input id="inv" name="inv" role="payment-form-order" type="hidden" value="42">

So I can query it with

$("[role='payment-form-order']")

without having to know particular input name.

More info on "role" html attribute http://www.w3.org/TR/role-attribute/

---

divineforest included the following code: https://github.com/Shopify/active_merchant/pull/878/commits

Add cyber mut integration

Issue by spk
Monday Sep 23, 2013 at 09:28 GMT
Originally opened as activemerchant/active_merchant#850

---

Hello,
We are using active merchant for the cyber_mut french payment method.
Hope this will be integrated !
Thanks

---

spk included the following code: https://github.com/Shopify/active_merchant/pull/850/commits

Get Travis working

I have the .travis.yml set up correctly I think, but not sure how to kickstart Travis actually building the repo.

Альфа-Банк integration support

Issue by pierre
Friday May 09, 2014 at 12:11 GMT
Originally opened as activemerchant/active_merchant#1188

---

Support for the Альфа-Банк payment gateway (http://alfabank.ru/).

Integration testing was performed with the Kill Bill Альфа-Банк plugin (https://github.com/killbill/killbill-alfabank-plugin).

See original pull request #1163.

---

pierre included the following code: https://github.com/Shopify/active_merchant/pull/1188/commits

WebPay3 - croatian gateway accepting worldwide merchants

Issue by damir
Saturday May 17, 2014 at 13:35 GMT
Originally opened as activemerchant/active_merchant#1205

---

WebPay3 supports 3DS, pan tokenization, risk management and fraud screening. More at https://ipg.webteh.hr.
Demo app at https://github.com/WebtehHR/webpay3-activemerchant.

---

damir included the following code: https://github.com/Shopify/active_merchant/pull/1205/commits

Valitor update

Issue by saevarom
Wednesday Dec 18, 2013 at 00:17 GMT
Originally opened as activemerchant/active_merchant#965

---

This is an update to the Valitor integration to the current version of 1.2.4. Valitor is the local VISA branch in Iceland.

• All parameters have been renamed from Icelandic to English
• The amount is not returned by Valitor so some tests regarding 'gross' were removed
• I have not found a way to run the remote test, I'm not sure how to handle that. Leaving it as is for now.

---

saevarom included the following code: https://github.com/Shopify/active_merchant/pull/965/commits

Please consider a trivial example of how to use this gem

Some examples on how this gem could be used would be extremely helpful. I would be happy to write them myself if someone can take a couple of minutes to familiarize me with how this gem is used.

QuickPay billing integrations is missing "acquirer" when computing callback notification response md5 check.

Issue by naoufalmed
Wednesday Jan 08, 2014 at 21:04 GMT
Originally opened as activemerchant/active_merchant#986

---

Hi,

When using QuickPay billing integration, I use ActiveMerchant::Billing::Integrations::Quickpay::Notification class to process the callback response, but the calling to the method acknowledge always returns false. Comparing the MD5_CHECK_FIELDS constant with the required fields for computing the md5 checksum, I see that the field acquirer is missing in the constant.
Here is what the documentation says:

You can perform you own MD5 check on the data returned to you. An example of MD5 calculation from the above listed values, could look like this and remember to calculate the values in the correct order (msgtype, ordernumber, amount, currency, time, state, qpstat, qpstatmsg, chstat, chstatmsg, merchant, merchantemail, transaction, cardtype, cardnumber, card expire, acquirer , splitpayment, fraudprobability, fraudremarks, fraudreport, fee, secret)

But in ActiveMerchant::Billing::Integrations::Quickpay::Notification the fields are as follows:

MD5_CHECK_FIELDS = [
            :msgtype,
            :ordernumber,
            :amount,
            :currency,
            :time,
            :state,
            :qpstat,
            :qpstatmsg,
            :chstat,
            :chstatmsg,
            :merchant,
            :merchantemail,
            :transaction,
            :cardtype,
            :cardnumber,
            :cardhash,
            :cardexpire,
            :splitpayment,
            :fraudprobability,
            :fraudremarks,
            :fraudreport,
            :fee
          ]

As you can see the :acquirer field is missing.

Is that correct or I'm using the wrong class?

Thank you!

Quick Review

@bslobodin @jduff @codyfauser can I get a quick review of this overall? I want to flip it to public pretty soon so that I can easily reference it as I work on the ActiveMerchant branch that will shim it in over there.

Add 2Checkout language support

Issue by craigchristenson
Thursday May 22, 2014 at 21:36 GMT
Originally opened as activemerchant/active_merchant#1220

---

2Checkout's hosted checkout supports multiple languages. This PR would allow the merchant to pass in the language to display to the customer.

---

craigchristenson included the following code: https://github.com/Shopify/active_merchant/pull/1220/commits

changes for payu integration

Issue by buoyant
Tuesday Aug 20, 2013 at 15:33 GMT
Originally opened as activemerchant/active_merchant#811

---

1. Getting merchant_id and secret_key from app environment.
2. Replaced productinfo with secret_key in generate_checksum method of helper class.
3. Sending params to notification on response.

Note: Tested with test credentials.
Any questions mail me on [email protected]

---

buoyant included the following code: https://github.com/Shopify/active_merchant/pull/811/commits

Unit tests for integrations?

Can you please confirm if unit test and/or remote test are required for new offsite payment methods (Integrations)?

acknowledge in ipay88 module does not work

The code below:

        def acknowledge
          secure? && (!success? || requery == "00")
        end

at:

https://github.com/Shopify/offsite_payments/blob/master/lib/offsite_payments/integrations/ipay88.rb

shouldn't it be:

        def acknowledge
          secure? && (success? || requery == "00")
        end

as the previous commiter set it as !success which i feel it is wrong.

Add GoCoin Integration

Issue by mabeller
Wednesday Jan 29, 2014 at 23:54 GMT
Originally opened as activemerchant/active_merchant#1019

---

GoCoin is a digital currency payment gateway. Please see http://gocoin.com for more information about GoCoin, or let me know if you have any questions.

---

mabeller included the following code: https://github.com/Shopify/active_merchant/pull/1019/commits

fix timezone bug in Paypal Integration

Issue by AknEp
Wednesday Jan 29, 2014 at 08:39 GMT
Originally opened as activemerchant/active_merchant#1016

---

I found strange bug, payment date ("received_at" method) was incorrect.
It's simple fix, please check a code.

P.S.
Thanks a lot such a great gem. You saved my time ! :)

---

AknEp included the following code: https://github.com/Shopify/active_merchant/pull/1016/commits

Yandex.Money integration

Issue by mgfox
Thursday May 29, 2014 at 10:13 GMT
Originally opened as activemerchant/active_merchant#1230

---

---

mgfox included the following code: https://github.com/Shopify/active_merchant/pull/1230/commits

Support QuickPay custom fields

QuickPay can store custom fields such as CUSTOM_foo. See http://doc.quickpay.dk/paymentwindow/technicalspecification.html

It seems like that WordPay integration is support custom params (https://github.com/Shopify/offsite_payments/blob/d9453d0bc95ed272af10d9e5f088a04245a4d022/lib/offsite_payments/integrations/world_pay.rb), or is there any better way of implementing this? Perhaps what Authorize.net integration is doing? (https://github.com/Shopify/offsite_payments/blob/d9453d0bc95ed272af10d9e5f088a04245a4d022/lib/offsite_payments/integrations/authorize_net_sim.rb#L123)

Add Checkout Finland integration

Issue by tuomasb
Friday Jan 10, 2014 at 11:00 GMT
Originally opened as activemerchant/active_merchant#991

---

Checkout Finland integration (www.checkout.fi)
Unit tested and manually tested. Any comments?

---

tuomasb included the following code: https://github.com/Shopify/active_merchant/pull/991/commits

MOLPay: Initial Commit

Issue by saifiikmal
Friday Apr 25, 2014 at 03:05 GMT
Originally opened as activemerchant/active_merchant#1143

---

Please review as this is initial commit for MOLPay to Active Merchant. TQ

---

saifiikmal included the following code: https://github.com/Shopify/active_merchant/pull/1143/commits

.

.

Add support for passing line item information to offsite integrations.

Issue by melari
Wednesday Oct 30, 2013 at 14:10 GMT
Originally opened as activemerchant/active_merchant#894

---

This defines a standard way to pass line item information to integrations. Individual integrations can then override the line_item method to suit their needs.

There are already a few integrations which support passing in line items such as auth.net sims. These should be refactored to this common interface as some point.

@odorcicd @RichardBlair

---

melari included the following code: https://github.com/Shopify/active_merchant/pull/894/commits

Add Payza integration

Issue by divineforest
Tuesday Nov 12, 2013 at 14:03 GMT
Originally opened as activemerchant/active_merchant#911

---

https://www.payza.com/

---

divineforest included the following code: https://github.com/Shopify/active_merchant/pull/911/commits

Payfast descriptionn

detect canceled payments

Issue by vdv
Thursday Jan 09, 2014 at 05:20 GMT
Originally opened as activemerchant/active_merchant#987

---

---

vdv included the following code: https://github.com/Shopify/active_merchant/pull/987/commits

Veritrans Indonesia vt web integration

Issue by barock19
Monday Sep 16, 2013 at 13:29 GMT
Originally opened as activemerchant/active_merchant#841

---

---

barock19 included the following code: https://github.com/Shopify/active_merchant/pull/841/commits

Add support for Cybersource Secure Acceptance.

Issue by DarkFox
Monday May 19, 2014 at 16:38 GMT
Originally opened as activemerchant/active_merchant#1207

---

Cybersource's new integration method, which replaces their Hosted Order Page and Silent Order POST integration methods.

API documentation: http://www.cybersource.com/developers/develop/integration_methods/secure_acceptance/

---

DarkFox included the following code: https://github.com/Shopify/active_merchant/pull/1207/commits

Bluezeal ccavenue shopify

Issue by bluezeal
Monday Jan 20, 2014 at 06:37 GMT
Originally opened as activemerchant/active_merchant#1003

---

Bluezeal ccavenue shopify

---

bluezeal included the following code: https://github.com/Shopify/active_merchant/pull/1003/commits

Worldpay: Update billing address mapping

Issue by semaperepelitsa
Friday Apr 18, 2014 at 22:33 GMT
Originally opened as activemerchant/active_merchant#1130

---

Worldpay now supports all standard billing address fields. I have updated the mapping and removed custom method.

See: http://www.worldpay.com/support/kb/bg/customisingadvanced/custa9103.html

---

semaperepelitsa included the following code: https://github.com/Shopify/active_merchant/pull/1130/commits

Alipay beta

Issue by amassaad
Thursday Feb 06, 2014 at 21:31 GMT
Originally opened as activemerchant/active_merchant#1026

---

---

amassaad included the following code: https://github.com/Shopify/active_merchant/pull/1026/commits

Add paybox system integration

Issue by spk
Monday Sep 23, 2013 at 10:08 GMT
Originally opened as activemerchant/active_merchant#851

---

Hello,
We are using active merchant for the paypox_system french payment method.

This payment method are different and change the classic usage of active_merchant helper...

PayboxSystem are very strict with parameters, so we have created a method that return a hash with only the needed params. (query_with_hmac)

We have documented the usage of the paybox helper so it can be used without payment_service_for helper.

Thanks

---

spk included the following code: https://github.com/Shopify/active_merchant/pull/851/commits

Add Paysera Integration

Issue by mrup5
Wednesday Jan 08, 2014 at 11:15 GMT
Originally opened as activemerchant/active_merchant#985

---

This pull request adds integration with an off-site payment gateway Paysera.

---

mrup5 included the following code: https://github.com/Shopify/active_merchant/pull/985/commits

Extract offsite_payments - née integrations - into a separate gem

Issue by ntalbott
Tuesday Jun 03, 2014 at 01:02 GMT
Originally opened as activemerchant/active_merchant#1239

---

Extract

• Create a fresh local repo, copy over all the relevant tests, and get them passing by copying over only the code that's needed.
• Move over generator code
• Strip out crufty dependencies
• Overhaul the naming and structure in light of the separation & new name[space]
• Craft a first-pass README
• Get a new Github repo provisioned
• Push OffsitePayments 2.0.0 RC up on Github

Migrate

• Strip integrations code out of ActiveMerchant in a branch
• Add offsite_payments as an ActiveMerchant dependency - for now
• Create a shim that is as close to 100% API compatible as possible, and spews deprecation warnings like they're going out of style if you use it

Profit

• Move all still-relevant integrations Issues to the new repo; PR's can become Issues pointing to the (now closed) PR's on the active_merchant repo.

💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰 💰

Documenting integration helper methods.

Issue by lulalala
Tuesday Apr 15, 2014 at 15:06 GMT
Originally opened as activemerchant/active_merchant#1122

---

I am trying to document the usage of integration gateways. I am not an expert so please review because my understanding could be wrong. Please also advice styling preferences if you have any. Cheers.

I do this because after a year not using AM, I had to relearn by reading codes from each of the methods again.

---

lulalala included the following code: https://github.com/Shopify/active_merchant/pull/1122/commits

Worldpay: minor improvements of signature method

Issue by semaperepelitsa
Friday Apr 18, 2014 at 22:28 GMT
Originally opened as activemerchant/active_merchant#1129

---

Please, review the commits.

---

semaperepelitsa included the following code: https://github.com/Shopify/active_merchant/pull/1129/commits

Paydollar payment gateway integration

Issue by shintre
Tuesday Jul 16, 2013 at 05:43 GMT
Originally opened as activemerchant/active_merchant#764

---

Active Merchant - Paydollar payment gateway integration
NOTE - For details on Active Merchant read the README.md file.

This document provide details on the Paydollar branch and how to use the Paydollar module for client posts (i.e integration mode, where the credit card information page is put up by Paydollar)

---

shintre included the following code: https://github.com/Shopify/active_merchant/pull/764/commits

No transaction validation for DirecPay

The DirecPay implementation doesn't validate if the parameter returned are valid (see this).

I'm reading through the DirecPay documentation and it seems that we could use their status endpoint (https://www.timesofmoney.com/direcpay/secure/dpPullMerchAtrnDtls.jsp) to do the validation instead of blindly returning true.

@louiskearns

Add RedDotPayment module and test

Issue by shuhong
Monday Mar 10, 2014 at 13:15 GMT
Originally opened as activemerchant/active_merchant#1066

---

Adding RedDotPayment as an integration for offsite payment.

http://www.reddotpayment.com/

---

shuhong included the following code: https://github.com/Shopify/active_merchant/pull/1066/commits

Add Log support

Currently, there's no logging support for the gem.

Would be awesome to have support for something like

OffsitePayments.logger = Rails.logger
OffsitePayments.logger.error("Geez! A bug!")

There has been some errors in PagSeguro's Notification that without logging Net::HTTP requests, is getting hard to track them down.

cc @bslobodin @odorcicd

Add integration dengionline

Issue by ovcharik
Tuesday Oct 08, 2013 at 16:20 GMT
Originally opened as activemerchant/active_merchant#874

---

Hi,

I just implemented support of russian DengiOnline service. Integrated support of it's protocol.

Link to the service: http://dengionline.com/eng
Link to protocol: http://dengionline.com/eng/dev/protocol/main_protocol

---

ovcharik included the following code: https://github.com/Shopify/active_merchant/pull/874/commits

Яндекс support

Issue by pierre
Monday May 05, 2014 at 15:21 GMT
Originally opened as activemerchant/active_merchant#1165

---

Support for the Яндекс payment gateway (https://money.yandex.ru/).

Integration testing was performed with the Kill Bill Яндекс plugin (https://github.com/killbill/killbill-yandex-plugin).

---

pierre included the following code: https://github.com/Shopify/active_merchant/pull/1165/commits

Added 'gross' method to Paysbuy Notification

Issue by divineforest
Tuesday Nov 12, 2013 at 13:06 GMT
Originally opened as activemerchant/active_merchant#910

---

Missed gross method

---

divineforest included the following code: https://github.com/Shopify/active_merchant/pull/910/commits

PayVector Integration

Issue by X0Refraction
Tuesday Feb 11, 2014 at 11:17 GMT
Originally opened as activemerchant/active_merchant#1030

---

Adding an integration for PayVector - http://www.payvector.co.uk (formerly known as Iridium Corporation).

I'm new to github so if there are any issues, just let me know.

---

X0Refraction included the following code: https://github.com/Shopify/active_merchant/pull/1030/commits

HiTrust gateway returns New Taiwan Dollar as NTD instead of TWD

Issue by silverstreaked
Monday Sep 30, 2013 at 19:38 GMT
Originally opened as activemerchant/active_merchant#862

---

Problem

When the HiTrust gateway returns its currency param, it returns the New Taiwan Dollar as NTD instead of TWD (the correct ISO code). NTD appears to be a common, but colloquial, reference to the New Taiwan Dollar.

Example params coming back from HiTrust:

Parameters: {"e08"=>"", "e07"=>"", "creddate"=>"", "e06"=>"", "retcode"=>"00", "credamount"=>"0", "approveamount"=>"98000", "capDate"=>"2013-09-16-16.01.30", "ordernumber"=>[removed], "type"=>"AUTH", "credcode"=>"", "currency"=>"NTD", "eci"=>"SSL", "paybatchnumber"=>"", "e10"=>"", "depositamount"=>"98000", "authCode"=>[removed], "pan"=>"", "storeid"=>[removed], "orderstatus"=>"03", "authRRN"=>"130199130199", "credbatchnumber"=>"", "orderdesc"=>[removed], "credRRN"=>"", "orderdate"=>"2013-09-16-16.01.30.694034", "e09"=>"", "gateway"=>"hi_trust", "shop_id"=>[removed]}

NTD should be mapped to TWD upon return from HiTrust, to avoid any issues with systems which only use ISO codes.

@melari @louiskearns

Netgiro

Issue by saevarom
Tuesday Dec 17, 2013 at 22:24 GMT
Originally opened as activemerchant/active_merchant#964

---

Netgíró is a new payment processor based in Iceland.

Developer documentation: https://www.netgiro.is/Assistance/Documentation

This pull request was previously submitted as #884, but due to some changes made in our fork I had to submit it again.

---

saevarom included the following code: https://github.com/Shopify/active_merchant/pull/964/commits

Cut 2.0.0 gem release

@bslobodin let me know what I can do to help make this happen; from my perspective we're ready to ship 2.0.0.