adafruit/adafruit_circuitpython_sgp30

CircuitPython driver for SGP30 VoC sensor

adafruit_circuitpython_sgp30's Issues

Missing Type Annotations

There are missing type annotations for some functions in this library.

The typing module does not exist on CircuitPython devices so the import needs to be wrapped in try/except to catch the error for missing import. There is an example of how that is done here:

try:
    from typing import List, Tuple
except ImportError:
    pass

Once imported the typing annotations for the argument type(s), and return type(s) can be added to the function signature. Here is an example of a function that has had this done already:

def wrap_text_to_pixels(
    string: str, max_width: int, font=None, indent0: str = "", indent1: str = ""
) -> List[str]:

If you are new to Git or Github we have a guide about contributing to our projects here: https://learn.adafruit.com/contribute-to-circuitpython-with-git-and-github

There is also a guide that covers our CI utilities and how to run them locally to ensure they will pass in Github Actions here: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code In particular the pages: Sharing docs on ReadTheDocs and Check your code with pre-commit contain the tools to install and commands to run locally to run the checks.

If you are attempting to resolve this issue and need help, you can post a comment on this issue and tag both @FoamyGuy and @kattni or reach out to us on Discord: https://adafru.it/discord in the #circuitpython-dev channel.

The following locations are reported by mypy to be missing type annotations:

• adafruit_sgp30.py:82
• adafruit_sgp30.py:150
• adafruit_sgp30.py:161
• adafruit_sgp30.py:173
• adafruit_sgp30.py:183
• adafruit_sgp30.py:204

simpletest.py set_iaq_relative_humidity parameter is celsius

Hello, in the simpletest.py the celcius parameter is misspelled and it should be celsius:

sgp30.set_iaq_relative_humidity(celsius=22.1, relative_humidity=44)

Thanks.

I have installed Blinka on my IOT205. It is working now. I allready tested a view Adafruit sensors. They are also working. But I have von problem with the sensor sgp30 from Adafruit. It is working once and then every time at the second try it shows "ValueError: No I2C device at adress: 58". If I put it off an on its working again. Do you have any idea what problem could be?

RuntimeError: SGP30 Not detected

Hi,
I just got a Adafruit SGP30 sensor breakout. Unfortunately, the sensor is not working. The output is the following:

File "30test", line 11, in <module>
sgp30 = adafruit_sgp30.Adafruit_SGP30(i2c)
File "/home/pi/sgp30.py", line 69, in __init__
raise RuntimeError('SGP30 Not detected')
RuntimeError: SGP30 Not detected

When I unplug the sensor afterwards and plug it back in, I can find the sensor with i2cdetect -y 1. After the next try to read the values, the sensor disappears.

There is another report in the Adafruit forum: https://forums.adafruit.com/viewtopic.php?f=19&t=158492

Do you have an idea how to solve it?

Thanks,
David

Irq baseline issue

Hi , the irq baseline hard code as following in the example code.
sgp30.set_iaq_baseline(0x8973, 0x8aae)
In the Pi3 board i got the 400ppm value with eCO2 output all the time. The root cause is the baseline should be updated, right? How could i get the right baseline value? thanks.

make eco2 + tvoc properties to match sensor standard

ed1db09#commitcomment-25187627

Incorrect feature set value for newer chips

The _SGP30_FEATURESET const is set to 0x0020:

https://github.com/adafruit/Adafruit_CircuitPython_SGP30/blob/master/adafruit_sgp30.py#L54

...but in newer versions of the SGP30, the value should be 0x0022. See https://www.tmsnet.eu/assets/pdf/pdfsrc.php?MPN=SGP30-2.5K&T=25__530

Error in sensor data?

So I managed to set up the sensor. But I keep getting values around 400 for eCO2 and 0 for TVOC.
Do I need to burn the sensor in?
Does it take a while before it starts outputting true values?
It does change when I blow on it. So it does seem to be working properly.
I just get the feeling it's not outputting real world values.

readme.rst is a comma missing, please add it

i2c_bus = busio.I2C(board.SCL, board.SDA frequency=100000)