Giter Site home page Giter Site logo

Comments (10)

enzian avatar enzian commented on August 15, 2024 1

@adamralph maybe it was also a case of over engineering is underrated ;-) I patched it!

from minver.

enzian avatar enzian commented on August 15, 2024

hey, need help on that?

from minver.

adamralph avatar adamralph commented on August 15, 2024

Hey @enzian, sure thing! I guess, from the user's perspective, this would result in a new property. Something like:

<MinVerAutoIncrement>major|minor|patch(default)</MinVerAutoIncrement>

I'm not wild about the name MinVerAutoIncrement. Any better idea? /cc @leastprivilege

from minver.

enzian avatar enzian commented on August 15, 2024

I preliminarily introduced the --increment-segment option in the CLI, but I don't have a strong opinion about the naming either!

from minver.

adamralph avatar adamralph commented on August 15, 2024

@enzian thanks for the PR!

But also apologies, because I was not clear in my previous comment:

<MinVerAutoIncrement>major|minor|patch(default)</MinVerAutoIncrement>

I was using | to mean "or". That is, the default (implicit) value would be:

<MinVerAutoIncrement>patch</MinVerAutoIncrement>

And that could be changed to:

<MinVerAutoIncrement>minor</MinVerAutoIncrement>

or:

<MinVerAutoIncrement>major</MinVerAutoIncrement>

I can't think of a valid use case to auto-increment more than one part of the version.

from minver.

enzian avatar enzian commented on August 15, 2024

@adamralph : I've seen (just once...) that a company did not release versions like 2.0.0. The first version they would release was 2.1.0 (for what reason is unclear to me...)! Should I switch to a single value?

from minver.

adamralph avatar adamralph commented on August 15, 2024

That sounds like a bizarre versioning scheme and not one I really want to encourage. 😉

I think, for now, let's stick to a single value for simplicity. We can always extend it to multiple values later, but I hope noone asks for that. 😉

from minver.

adamralph avatar adamralph commented on August 15, 2024

Released in 1.1.0-beta.1.

@leastprivilege would you like to give it a try? Just add a property:

<MinVerAutoIncrement>minor</MinVerAutoIncrement>

from minver.

leastprivilege avatar leastprivilege commented on August 15, 2024

sorry - swamped right now...

from minver.

adamralph avatar adamralph commented on August 15, 2024

@leastprivilege FYI I just pushed 1.1.0-rc.1.

from minver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.