adamviola/boostedbrightness

A simple Minecraft mod that allows you to set brightness beyond default levels.

boostedbrightness's Issues

1.20.1

Mod update to 1.20.1 please!

Bug with Optifine lightmaps

When using a resource pack with lightmaps, the lightmap overrides the mod's settings. Meaning 1200% brightness on the mod will only give 100% brightness. This issue can be worked around if you do not have a lightmap installed in your resource pack.

No negative Brightness/Gamma possible

When setting the brightness to values below 0 in 1.19+, it just looks like 0. While porting the slider feature to forge, I found out the issue. It should be fixed by applying this mixin: https://github.com/LaidBackSloth/BetterBrightnessSlider/blob/forge-1.19.X/src/main/java/com/laidbacksloth/brightnessslider/mixin/LightTextureMixin.java, at least it does in forge, but I think fabric should be the same (you might need to add remap = true).

1.20.5 support

Upload to Modrinth?

Could you also add this on Modrinth? I am unsure if I can use this in my Modrinth modpack because I don't think curseforge shows if mods allow downloads from other places

Sodium

Not compatible with sodium

Using the hotkeys sometimes will not work.

Sometimes when I need to toggle my brightness on of off then the keys don't work. When I do this then it will only change the setting sometimes, other times it will not do anything. This is happenign with the b key, and the bracket keys.

I am running Sodium and a mod named LambDynamicLights.

crash

crash-2022-12-08_16.01.29-client.txt

Game looks neon when using Boosted Brightness Values

I'm using this mod in conjunction with the Fabulously Optimized mod pack, which includes Sodium and Iris (I have shaders disabled). When using brightness values outside of the default game (like 1200) everything looks neon, including the terrain and options menus. I had a challenging time uploading images. Any ideas on how to fix this?
https://youtu.be/SyrpgLEiGhQ

Using mod on 1.18 with sodium causes new "simulation distance" to be swapped with brightness

I've found that using sodium on 1.18 alongside this mod causes the simulation distance and brightness settings to be swapped in the video settings, so the simulation distance can be adjusted from -100 to 1200, and the brightness from 0 to 100.

Missing something to work as expected in 1.16.2

Once clicked on the graphic options:

net.minecraft.class_148: mouseClicked event handler
	at net.minecraft.class_437.method_25412(class_437.java:440) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.class_312.method_1601(class_312.java:92) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.class_312.method_22686(class_312.java:162) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.class_1255.execute(class_1255.java:94) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.class_312.method_22684(class_312.java:162) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:36) ~[lwjgl-glfw-3.2.2.jar:build 10]
	at org.lwjgl.system.JNI.invokeV(Native Method) ~[lwjgl-3.2.2.jar:build 10]
	at org.lwjgl.glfw.GLFW.glfwPollEvents(GLFW.java:3101) ~[lwjgl-glfw-3.2.2.jar:build 10]
	at com.mojang.blaze3d.systems.RenderSystem.flipFrame(RenderSystem.java:102) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.class_1041.method_15998(class_1041.java:308) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.class_310.method_1523(class_310.java:1043) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.class_310.method_1514(class_310.java:656) [intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.client.main.Main.main(Main.java:215) [intermediary-minecraft-1.16.2-client.jar:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_251]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_251]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_251]
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_251]
	at net.fabricmc.loader.game.MinecraftGameProvider.launch(MinecraftGameProvider.java:192) [fabric-loader-0.9.2+build.206.jar:?]
	at net.fabricmc.loader.launch.knot.Knot.init(Knot.java:140) [fabric-loader-0.9.2+build.206.jar:?]
	at net.fabricmc.loader.launch.knot.KnotClient.main(KnotClient.java:26) [fabric-loader-0.9.2+build.206.jar:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_251]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_251]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_251]
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_251]
	at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:196) [NewLaunch.jar:?]
	at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:231) [NewLaunch.jar:?]
	at org.multimc.EntryPoint.listen(EntryPoint.java:143) [NewLaunch.jar:?]
	at org.multimc.EntryPoint.main(EntryPoint.java:34) [NewLaunch.jar:?]
Caused by: java.lang.NoSuchMethodError: net.minecraft.class_4067.method_18518()Lnet/minecraft/class_5250;
	at net.minecraft.class_4067.md482591$lambda$init$0$0(class_4067.java:540) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.class_4067.method_18619(class_4067.java:73) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.class_4040.method_25346(class_4040.java:27) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.class_4040.<init>(class_4040.java:16) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.class_4067.method_18520(class_4067.java:33) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.class_353$class_354.method_20410(class_353.java:79) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.class_353.method_20407(class_353.java:25) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.class_353.method_20408(class_353.java:30) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.class_446.method_25426(class_446.java:67) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.class_437.method_25423(class_437.java:325) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.class_310.method_1507(class_310.java:897) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.class_429.method_19828(class_429.java:85) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.class_4185.method_25306(class_4185.java:33) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.class_4264.method_25348(class_4264.java:16) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.class_339.method_25402(class_339.java:149) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.class_4069.method_25402(class_4069.java:27) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.class_312.method_1611(class_312.java:92) ~[intermediary-minecraft-1.16.2-client.jar:?]
	at net.minecraft.class_437.method_25412(class_437.java:435) ~[intermediary-minecraft-1.16.2-client.jar:?]

Cannot start beacuse of config problem?

I tried launching it just with cloth, arch. & API.
Still crashes.

LOG START
---- Minecraft Crash Report ----
// Don't be sad, have a hug! <3

Time: 12/30/21, 3:13 PM
Description: Initializing game

java.lang.RuntimeException: Could not execute entrypoint stage 'client' due to errors, provided by 'boostedbrightness'!
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke0$0(EntrypointUtils.java:51)
at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:49)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke(EntrypointUtils.java:35)
at net.fabricmc.loader.impl.game.minecraft.Hooks.startClient(Hooks.java:53)
at net.minecraft.class_310.(class_310.java:437)
at net.minecraft.client.main.Main.main(Main.java:177)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:567)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:608)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:77)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:567)
at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:210)
at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:245)
at org.multimc.EntryPoint.listen(EntryPoint.java:143)
at org.multimc.EntryPoint.main(EntryPoint.java:34)
Caused by: java.lang.NullPointerException: Cannot invoke "com.google.gson.JsonObject.get(String)" because "config" is null
at net.boostedbrightness.BoostedBrightness.loadConfig(BoostedBrightness.java:82)
at net.boostedbrightness.BoostedBrightness.onInitializeClient(BoostedBrightness.java:75)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:47)
... 19 more

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head --
Thread: Render thread
Stacktrace:
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke0$0(EntrypointUtils.java:51)
at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:49)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke(EntrypointUtils.java:35)
at net.fabricmc.loader.impl.game.minecraft.Hooks.startClient(Hooks.java:53)
at net.minecraft.class_310.(class_310.java:437)

-- Initialization --
Details:
Stacktrace:
at net.minecraft.client.main.Main.main(Main.java:177)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:567)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:608)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:77)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:567)
at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:210)
at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:245)
at org.multimc.EntryPoint.listen(EntryPoint.java:143)
at org.multimc.EntryPoint.main(EntryPoint.java:34)

-- System Details --
Details:
Minecraft Version: 1.16.5
Minecraft Version ID: 1.16.5
Operating System: Windows 10 (amd64) version 10.0
Java Version: 16.0.2, Eclipse Foundation
Java VM Version: OpenJDK 64-Bit Server VM (mixed mode, sharing), Eclipse Foundation
Memory: 1033111120 bytes (985 MB) / 2147483648 bytes (2048 MB) up to 6442450944 bytes (6144 MB)
CPUs: 12
JVM Flags: 3 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xms1024m -Xmx6144m
Fabric Mods:
architectury: Architectury 1.27.46
boostedbrightness: Boosted Brightness 2.0.0
cloth-basic-math: cloth-basic-math 0.6.0
cloth-config2: Cloth Config v4 4.13.49
fabric: Fabric API 0.41.3+1.16
fabric-api-base: Fabric API Base 0.3.0+f74f7c7d7d
fabric-api-lookup-api-v1: Fabric API Lookup API (v1) 1.3.0+f74f7c7d7d
fabric-biome-api-v1: Fabric Biome API (v1) 3.1.12+c16be54b7d
fabric-blockrenderlayer-v1: Fabric BlockRenderLayer Registration (v1) 1.1.5+ca58154a7d
fabric-command-api-v1: Fabric Command API (v1) 1.1.2+f74f7c7d7d
fabric-commands-v0: Fabric Commands (v0) 0.2.2+ca58154a7d
fabric-containers-v0: Fabric Containers (v0) 0.1.11+9354966b7d
fabric-content-registries-v0: Fabric Content Registries (v0) 0.2.4+f74f7c7d7d
fabric-crash-report-info-v1: Fabric Crash Report Info (v1) 0.1.3+ca58154a7d
fabric-dimensions-v1: Fabric Dimensions API (v1) 2.0.7+c16be54b7d
fabric-entity-events-v1: Fabric Entity Events (v1) 1.2.3+77df1b337d
fabric-events-interaction-v0: Fabric Events Interaction (v0) 0.4.4+35ff49a47d
fabric-events-lifecycle-v0: Fabric Events Lifecycle (v0) 0.2.1+ca58154a7d
fabric-game-rule-api-v1: Fabric Game Rule API (v1) 1.0.6+f74f7c7d7d
fabric-item-api-v1: Fabric Item API (v1) 1.2.1+ca58154a7d
fabric-item-groups-v0: Fabric Item Groups (v0) 0.3.0+ede6dcf77d
fabric-key-binding-api-v1: Fabric Key Binding API (v1) 1.0.4+f74f7c7d7d
fabric-keybindings-v0: Fabric Key Bindings (v0) 0.2.1+ca58154a7d
fabric-lifecycle-events-v1: Fabric Lifecycle Events (v1) 1.2.1+ca58154a7d
fabric-loot-tables-v1: Fabric Loot Tables (v1) 1.0.2+ca58154a7d
fabric-mining-levels-v0: Fabric Mining Levels (v0) 0.1.3+ca58154a7d
fabric-models-v0: Fabric Models (v0) 0.3.0+f74f7c7d7d
fabric-networking-api-v1: Fabric Networking API (v1) 1.0.4+f74f7c7d7d
fabric-networking-blockentity-v0: Fabric Networking Block Entity (v0) 0.2.8+ca58154a7d
fabric-networking-v0: Fabric Networking (v0) 0.3.2+ca58154a7d
fabric-object-builder-api-v1: Fabric Object Builder API (v1) 1.9.5+f74f7c7d7d
fabric-object-builders-v0: Fabric Object Builders (v0) 0.7.2+ca58154a7d
fabric-particles-v1: Fabric Particles (v1) 0.2.4+ca58154a7d
fabric-registry-sync-v0: Fabric Registry Sync (v0) 0.7.5+9385714e7d
fabric-renderer-api-v1: Fabric Renderer API (v1) 0.4.4+f74f7c7d7d
fabric-renderer-indigo: Fabric Renderer - Indigo 0.4.4+ca58154a7d
fabric-renderer-registries-v1: Fabric Renderer Registries (v1) 2.3.0+f74f7c7d7d
fabric-rendering-data-attachment-v1: Fabric Rendering Data Attachment (v1) 0.1.5+ca58154a7d
fabric-rendering-fluids-v1: Fabric Rendering Fluids (v1) 0.1.14+4579bd497d
fabric-rendering-v0: Fabric Rendering (v0) 1.1.2+ca58154a7d
fabric-rendering-v1: Fabric Rendering (v1) 1.6.0+2868a2287d
fabric-resource-loader-v0: Fabric Resource Loader (v0) 0.4.7+f74f7c7d7d
fabric-screen-api-v1: Fabric Screen API (v1) 1.0.0+c045166c7d
fabric-screen-handler-api-v1: Fabric Screen Handler API (v1) 1.1.5+f74f7c7d7d
fabric-structure-api-v1: Fabric Structure API (v1) 1.1.11+ca0ef93d7d
fabric-tag-extensions-v0: Fabric Tag Extensions (v0) 1.1.1+ca58154a7d
fabric-textures-v0: Fabric Textures (v0) 1.0.6+ca58154a7d
fabric-tool-attribute-api-v1: Fabric Tool Attribute API (v1) 1.2.7+f74f7c7d7d
fabric-transfer-api-v1: Fabric Transfer API (v1) 1.4.1+c16be54b7d
fabricloader: Fabric Loader 0.12.12
java: OpenJDK 64-Bit Server VM 16
minecraft: Minecraft 1.16.5
Launched Version: MultiMC5
Backend library: LWJGL version 3.2.2 build 10
Backend API: NO CONTEXT
GL Caps:
Using VBOs: Yes
Is Modded: Definitely; Client brand changed to 'fabric'
Type: Client (map_client.txt)
CPU:
LOG END

Mixin conflict with Gamma Utils

Since the latest update when using with Gamma Utils, the MixinLightmapTextureManager.java mixin conflicts with Gamma Utils' and the game crashes upon launch.

Here is a crash report: https://mclo.gs/SNZJwEP

1.19.3 Semi-incompatibility

Boosted Brightness works almost fully; however, the game will crash if you attempt to open its settings UI or any related UIs. Keybinds and modifiers for this mod do work and do still increase/decrease brightness accordingly.

Doesn't work with Sodium's custom interface

I know this isn't your mod's problem, but maybe you could contact the developers and discuss about a better implementation on their side?

1.20.2 Support

When is the 1.20.2 version available?

Doesn't work with sildur's shaders

Video wouldn't upload cuz bigger than 10mb
Uploaded to yt instead
idk if its a setting in the shader or not and am very dumb

edit: the first part of video with it working is with shaders set to off
another edit cuz line 3 above: with shaders on it does still effect the minimap tho

BoostedBrightness seems to forget "normal" brightness.

Using Sodium btw. It seems that if I leave the game with Boosted Brightness on and then start the game again the mod has forgotten the "normal" brightness. Perhaps add a config option for what normal brightness should be.

1.19 When??

I literally need this mod right now please give me an update yet or I will riot

Incompatible with 1.19

Just here to report what happens on 1.19 if it helps development.

The game opens, and mod menu even detects the mod.
But when trying to edit the config the game crashes, either using mod menu or key binds.

The game crashed whilst unexpected error
Error: java.lang.NoSuchFieldError: field_1840
Exit Code: -1

With the removal of editing the gamma in the options.txt manually in 1.19, this mod would be very useful to content creators!

support 1.17.1

Use 'fabric-api' mod ID in fabric.mod.json

Users may be confused when they see that it depends on fabric, not knowing that it's referring to the Fabric API.

As of Minecraft 1.19.2, Fabric API's mod ID has changed from fabric to fabric-api. When backporting from 1.19.2 to earlier versions, you must alter the depends section of your fabric.mod.json to expect fabric.

From https://fabricmc.net/wiki/tutorial:setup#mod_setup

Incompatibility with Sodium Extra

crash-2022-05-27_06.06.17-client.txt

1.20?

Is this compatible with 1.20? If it is, the version needs to be bumped. If not, then this is an issue for it I guess ¯_(ツ)_/¯

java.lang.StackOverflowError: mouseClicked event handler

i see this error while i try to change brightness or click something belongs to the mod
i tried reinstall the mod and reinstall minecraft but it doesn't help

Incompatible with Sodium Extras

Update to 1.19.4

Please update to 1.19.4

Gamma change doesn't work

When I try to change to any other brightness setting other than the default values, nothing happens. The text appears on-screen, and the proper brightness is selected when I look under the mod options, but it doesn't change anything in game.

Quilt 0.18.3-pre.2
Minecraft 1.19.3
Mod version 2.1.3

1.19 support

Hi, I've been using this mod for a while and I want to use it on 1.19 so yeah any chance that it will be updated soon?
I'm aware that now you cant change the gamma above the limit so if it affects the mod I would understand if it will take longer but Im curious how much lo?

Incompatible with a Mod combination of Sodium Shadowy Path Blocks and Reese Sodium Options

When Sodium Shadowy Path Blocks and Reese Sodium Options are installed together with this Mod and the graphics screen is opened, minecraft crashes. (Maybe also the problem from #23 ?)
Without one of these three Mods, it is working.
With only:

• Iris, Sodium, Sodium extra, Reese Sodium Options, Sodium Shadowy Path Blocks or
• Iris, Sodium, Sodium extra, Reese Sodium Options, Boosted Brightness or
• Iris, Sodium, Sodium extra, Boosted Brightness, Sodium Shadowy Path Blocks
  it is working.

Incompatibility with Sodium Extra

Hello, due to people reporting issues about Boosted Brightness completely breaking with Sodium Extra. I did a little bit of investigating a figured out the reflection hack to modify Sodium's Brightness Slider completely breaks due to the addition of an option group in the general page which adds back the resolution slider in Sodium Extra.

BoostedBrightness/src/main/java/net/boostedbrightness/mixin/MixinMinecraftClient.java

Line 48 in e0c09e2

List<?> options = (List<?>) get(optionGroups.get(0), "me.jellysquid.mods.sodium.client.gui.options.OptionGroup", "options");

Suggestion to fix this issue

List<?> options = (List<?>) get(FabricLoader.getInstance().isModLoaded("sodium-extra") ? optionGroups.get(1) : optionGroups.get(0), "me.jellysquid.mods.sodium.client.gui.options.OptionGroup", "options"); 

Crash when trying to configure the mod

1.20.2 game crashed when clicking on the configure button in the mod menu.

Report: crash-2023-12-28_15.47.56-client.txt

2023-12-28_16-00-52.trimmed.mp4

Issue with the Sodium implementation

Details:
Minecraft 1.16.5
Fabric 0.11.3
Fabric API 0.32.0+1.16
Sodium 0.1.0
BoostedBrightness 1.2.1
Starlight (Not sure if this matters pretty sure no) 0.0.2

I think this may cause a memory leak, as my memory usage exploded until I disabled it. But the logs don't seem that good anyway.
I also think this has something to do with Sodium.

Log:
https://paste.ee/p/2jkJc