Giter Site home page Giter Site logo

Comments (8)

nemesis avatar nemesis commented on August 14, 2024

Do you reference the workspace when building?

from ios-build-kit.

delebedev avatar delebedev commented on August 14, 2024

IMMEDIATE UPDATE: it happens because buildkit expects full path in :build_dir setting. Working on solution

from ios-build-kit.

delebedev avatar delebedev commented on August 14, 2024

@nemesis sure I do :)

from ios-build-kit.

delebedev avatar delebedev commented on August 14, 2024

Actually, I see use cases when :build_dir and other preferences can be both relative and absolute paths, so buildkit config should determine that and expand path to full if necessary (and leave 'as is' if it's already expanded).
Builds -> users/src/project/Builds
users/src/project/Builds -> users/src/project/Builds
@adamwaite what do you think? Should this pattern be applied to all options?

from ios-build-kit.

adamwaite avatar adamwaite commented on August 14, 2024

That would be great actually. Not sure how you might go about checking if the path is relative or absolute though? Unless you try finding relative and if it fails, try absolute, and if that also fails raise an exception? Can't think of a cleaner way to do it off the top of my head. I'm all for this though. Appreciate the help on this. Make a 'Contributors' section in the README and put yourself on there!

from ios-build-kit.

delebedev avatar delebedev commented on August 14, 2024

If path starts with / its defenitely absolute one otherwise it's relative.
So basically workflow remains the same, but TaskRunnerConfig returns correct version of path and assertions work like before.

from ios-build-kit.

adamwaite avatar adamwaite commented on August 14, 2024

Haha of course, I think I need to go back to bed! Yes, that works.

from ios-build-kit.

adamwaite avatar adamwaite commented on August 14, 2024

Fixed with #14

from ios-build-kit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.