Comments (3)
That's a good point. I'm not sure how I missed that. Let me work on it.
from ios-build-kit.
Hey @Kudo. This should be sorted now. Only took me 7 months. I'll get on to your PR soon, thanks!
from ios-build-kit.
Thanks @adamwaite.
After a little testing, I found there are still some code sign inconsistency between xcrun and xcodebuild. For example, I use my developer provision in xcode, then during xcodebuild step, it will sign with the developer provision implicitly. If later for xcrun code sign step, I give another different provision, when upload to app store, they will complain for inconsistency.
My workaround is to do code sign in xcodebuild step but not xcrun step. One limitation for xcodebuild is that it only accept provision included in Xcode, i.e. Before build, we should refresh Xcode's provisions handy.
BTW, there are still some other changes from me, but the design is totally different from your, so I did not send PR for you. Here are they and you may able to have some reference and I am likely to see if the changes can be merge in mainstream.
- 690da06 for update Decorated-* in project plist during build time, so we don't need to modify project plist in VCS(git).
- 33d0baf for Asset Catalogs support
- ba50505 876a275 as what I mentioned to do code sign in xcodebuild.
Thank you.
from ios-build-kit.
Related Issues (20)
- Use more reliable mechanism to determine if build/test was failed HOT 2
- NoMethodError when deleting mandatory configuration sush as :build_dir HOT 1
- -lPods not found issue in example project HOT 8
- Add "clean before build" option to xcodebuild task HOT 4
- Build succeeded not working HOT 2
- Error when :build_dir does not exist. HOT 1
- Install failing HOT 7
- Error when using buildkit HOT 26
- Support test reports, test coverage reports, API docs HOT 1
- ipa builds with wrong provisioning profile even when specifying path to provisioning profile HOT 3
- Distribute Task
- can not download HOT 5
- "Missing Provisioning Profile - iOS Apps must contain a provisioning profile in a file named embedded.mobileprovision."
- Web UI
- Running simultaneous builds
- BuildKit creating invalid IPA
- CodeSign fails but script gives happy cheers
- NoSuchMethod error
- Error when using buildkit HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ios-build-kit.