adapt-security/adapt-authoring-jsonschema

adapt-authoring-jsonschema's Issues

overwriteProperties in JsonSchema.js patch function

What happened?

After discussing we've changed overwriteProperties to true to allow schemas to override blank default values. Further investigation needed into why overwriteProperties was introduced and _.defaultsDeep was being used rather than _.merge.

Expected behaviour

No response

Steps to reproduce

n/a

Authoring tool version

n/a

Framework version

No response

What browsers are you seeing the problem on?

No response

Relevant log output

No response

Defaults not pulling through correctly

What happened?

When creating a new component the default instruction text is not showing, however on the hotgraphic/narrative the mobile instruction default is showing. Seems to be a schema issue.

The help icon and text is also missing from the instruction input.

Steps to reproduce

• Create a course
• Add a new component (hotgraphic/narrative)
• Check defaults are being pulled through

JSON validator should provide localised error messages

Note that these will only be translated when returning the response (required lang will only been known at that point)

Perhaps using
https://github.com/ajv-validator/ajv-i18n

If-Then-Else conditions

What happened?

The If-Then conditions for https://github.com/adaptlearning/adapt-contrib-scoringAssessment/blob/issue/8/schema/article.schema.json#L209-L225 prevent the plugin from being enabled. The schema is correctly validated in the tool, i.e. an error is raised if the plugin is enabled and the _id is empty. However, the _isEnabled property is never saved and the plugin remains disabled.

Expected behaviour

No response

Steps to reproduce

• Add https://github.com/adaptlearning/adapt-contrib-scoringAssessment/tree/issue/8 to the AAT
• Add to project
• Enable the plugin on an article and set an _id
• Save
• When returning to edit the article, the plugin is now disabled.

Authoring tool version

https://staging.kineoadapt.com

Framework version

No response

What browsers are you seeing the problem on?

No response

Relevant log output

No response