adashen/vscode-tomcat

vscode-tomcat's Issues

[Enhancement] Changing server port throw error when tomcat sever is running

Repro step:
change shutdown port when tomcat server is running throw error like blow.
And tomcat server can't be shutdown.
change this port when tomcat is shutdown ,everything is good .

Move starting debug session after starting jvm

This is to fix the potential co current issue.

Proceed with *info* message when user create the same tomcat server

Add option to create new server to command "Tomcat: Start Tomcat Server" in the end of server list

pop up info instead of error when there is no tomcat server to delete or stop

Repro Steps:

1. clean all tomcat servers
2. Run command "Delete Tomcat Server" in Command Platte

Expected:
A Info or warning message indicate that there is no tomcat server to delete.

Actual:
Error pops up.

Add context command for tomcat server to update HTTP port

Enhancement: Prompt user to restart when the server is running and the server.xml is saved.

Open web page button will be hidden by debug button in status bar

1. Open vscode in a laptop (screen is relative small)
2. Run tomcat, and the open web page button in the status not shown.

The reason is the button is too wide, and the priority is lower than debug button, so it will be hidden.

[0.2.1][Linux] Not working at all.

On version 0.2.1 it is not possible to use plugin. Commands "Debug on Tomcat Server" and "Run on Tomcat Server" do nothing,

Using menu View -> Command Palette... -> New Tomcat Server (or any other) shows an error:

command 'tomcat.createserver' not found

VS Code version: Version 1.18.1
OS: Linux x64

Add context command for tomcat server to update http port

deploy a helloworld.war package to the same running tomcat server twice throw error

1. create a dynamic web project by eclipse and generate a war package
2. deploy the war package to tomcat server on VScode, it will success
3. deploy the war package again to the same tomcat while it is running , error occured
   

This issue doesn't reproduce on the spring boot sample project from Here
If we stop the tomcat server and redeploy the package. This issue doesn't reproduce either

Configure VM Options from within Plugin

Hello,

I am trying out this plugin in conjunction with other java vscode tools to see if I can't cut netbeans out of my workflow. One thing that, while not mission critical, would behoove me is to be able to set options for tomcat and the JVM from within the tomcat maven plugin. This would be a lot easier for me than fiddling with setenv.sh , which doesn't really work that well for me.

I don't know if this is ME thing or something your average user can benefit from. If the former, feel free to close out this case.

Add telemetry for tomcat extension

tomcat still running after close vscode

After close vscode when a tomcat server is running. The tomcat process is still running. It should be closed.

Repro step:

1. deploy a war to a tomcat server
2. wait for it start running,close vscode
3. check the process list , tomcat is still running

[Enhancement] Group commands to start with "Tomcat:" for extension unique awareness

Current UI looks like:

Actually most extension will categorize their command with an unique prefix.

0.2.0 Test Plan

Features

Basic

• Can run war package
• Can debug war package
• Can link multiple tomcat instances
• Can shutdown the running tomcat instance
• Can delete the stopped tomcat instance
• The tomcat instances can be saved in work space

From 0.2.0

• Can open server.xml of selected tomcat instance
• Can update the server.xml and run tomcat instance based on the modification

OS

• Windows
• OS X

Reference

0.4.0 Endgame

Build

• 01/12 - Bump version to 0.4.0
• 01/12 - Add change logs
• 01/12 - Merge develop to master
• 01/12 - Build new version package

Test

• 01/15- 01/17 Run Test Plan #41
• 01/15 - 01/17 Fix bugs

Release

• Add version Tag
• Publish new version to marketplace
• Merge master back to develop

Add restart tomcat server command

Set Tomcat Working Directory via Settings

Hi!
Currently Tomcat seems to start with the Current Working Directory of VS Code, which is always the VS Code directory. This is usually write-protected and several servlets usually write files to the current working directory.
If there was an option to set the default Working Directory for Tomcat Startup one could set this however one needs. - Also defaulting to CATALINA_HOME (like tomcat statup.sh) would be a good default.

Error starting static Resources

Hello,

I've installed the 0.2.1 version and I'm currently running VSCode on OSX High Sierra. When I try to run or debug the war at my Tomcat 7 I got the following error:

SEVERE: Error starting static Resources
java.lang.IllegalArgumentException: Document base /Users/leonardogaona/Library/Application Support/Code/User/workspaceStorage/366a44dabac5ab2859b42aa6282f9271/adashen.vscode-tomcat/tomcat/apache-tomcat-7.0.82/webapps/distribution-centers-api does not exist or is not a readable directory

The current war is at the /Users/leonardogaona/workspace/distribution-centers-api folder. Any idea of I could be doing wrong? The dir showed at the error exists and is owned by my OS user.

Regards,

Add context command for tomcat server to update server port

0.5.0 Plan

• Check if the server directory valid when adding Tomcat Server

• Add refresh command in Tomcat Server Explorer

• fix issue #59

• fix issue #28

• Add support for user setting default working directory #58

• Add option to create new Tomcat Server when run command "Tomcat: Start Tomcat Server"

• Show command "Tomcat: Debug on Tomcat Server" in command platte

• Add "Tomcat: Restart Tomcat Server" context command in Tomcat Server Explorer

• show war packages that deployed to Tomcat Server in sub-tree in Tomcat Server Explorer

• provide further action to revert server port when user changed the server port of a running server

• automatically construct tomcat server name base on the install path and support renaming

• Support right-click to Create Tomcat Server in Tomcat Server Explorer

0.3.0 Test Paln

Features

Basic

• Can run war package
• Can debug war package
• Can link multiple tomcat instances
• Can shutdown the running tomcat instance
• Can delete the stopped tomcat instance
• The tomcat instances can be saved in work space
• Can open server.xml of selected tomcat instance
• Can update the server.xml and run tomcat instance based on the modification

From 0.3.0

• Can start Tomcat from Tomcat Explorer
• Can restart if server.xml is update during running
• Can open in browser from Tomcat Explorer

OS

• Windows
• OS X
• Linux

Reference

Allow user has option to keep server running when exit vscode

0.3.0 Plan

• Add start operation in context menu of tomcat explorer #9
• Add Open in browser operation in context menu of tomcat explorer
• Prompt user to restart when server.xml is change during running #8
• Solve Linux package issue #10
• Fix open web page button hidden in status bar issue. #7
• Fix tomcat still running after close #6

Server state track

server status in explorer maybe not match the exact state of the server.

Should we take the external operations on server in consider?
If so, how? And then we need refresh button in explorer to refresh servers state.

Add start operation to the tomcat node in explorer

0.5.0 Test Plan

Features

Basic

• Can run war package
• Can debug war package
• Can link multiple tomcat instances
• Can shutdown the running tomcat instance
• Can delete the stopped tomcat instance
• The tomcat instances can be saved in work space
• Can open server.xml of selected tomcat instance
• Can update the server.xml and run tomcat instance based on the modification
• Can start Tomcat from Tomcat Explorer
• Can restart if server.xml is update during running
• Can open in browser from Tomcat Explorer
• No command shows in Tomcat Server Explorer if there is no server in the tree
• User gets an info message saying "There are no Tomcat Servers." when run command "Tomcat: Delete Tomcat Server" from command platte and there is no server to delete
• Run command "Tomcat: Run on Tomcat Server", user could just navigate to select a war package then select a tomcat server without clicking "Browse..."
• All tomcat commands have same pattern "Tomcat: xx_command"
• User gets an info message saying "There are no Tomcat Servers." when run command "Tomcat: Stop Tomcat Server" from command platte and there is no server to stop
• User always has option to create a new tomcat server when run command "Tomcat: Start Tomcat Server" from command platte or right click a war package to "Run on Tomcat"
• User could click "+" button in tomcat server explorer to create a new tomcat server

From 0.5.0

• User get error message "Please make sure you select a valid Tomcat Directory." when selecting an invalid directory to create a new tomcat server
• User could "Restart Tomcat Server" from command platte
• In tomcat server explorer, running server has context command "Restart Tomcat Server", user could right-click to restart a running server
• User could Run command "Tomcat: Debug on Tomcat Server" from command platte
• User could set the tomcat servers workspace in settings and the server works just as no setting
• Error message will pop up when user change the server port of a running server
• Server will not restart when re-run a war package on it
• Server will not restart when re-debug a war package on it
• Server will restart when first run a war package on it, then debug the same war package on it
• Server will restart when first debug a war package on it, then run the same war package on it
• Users could find all war packages that deployed to the tomcat server in its sub-tree in tomcat server explorer
• Users could right-click to open war package in browser
• Users could just click 'revert' to revert the server port if he (accidentally) changed the server port of a running server
• Users could get a valid tomcat server name if he create tomcat servers base on same install directory
• Users could right-click a stopped tomcat server to rename it
• Warning message pop up when user change the http(s) port of a running server, and (s)he could click restart or cancel, or never to never see this warning anymore
• Browse a war package when its server not running, users could get a info message and an option to start server

OS

• Windows
• OS X
• Linux

Reference

README

server explorer tree loading is a little slow

load servers to explorer is sync

Update CI to auto publish when commit with tag

Using command to start a running server throw error and shutdown the running server

Retro steps:

Run command "Start Tomcat Server" from command platte
Select a running server
Expected:
A friendly error/info message to tell user what's going on, or even further filter the running servers.

Actual:
The running server is stopped.

separate the localization logic to save the coding effort

Have to write multiple copies of code snippet when the string need to be localized such as Utility.localize('tomcatExt.selectdirectory', 'Select Tomcat Directory').

Wrap the vscode localize function to a localize.ts file. And leverage it to define strings or MessageItems in a separate DialogMessage.ts file.

Add entry for command "debug on tomcat server" from command platte

Using command to delete a running server didn't kill all tomcat process

Retro steps:

Run command "Tomcat:Delete tomcat server " from command platte
Select a running server

Expected:
the tomcat server remove from the explorer and all process should be shutdown

Actual:
The tomcat server is deleted but tomcat process still run in background and occupy the port.

0.3.0 Endgame

Build

• 12/21 - Bump version to 0.3.0
• 12/21 - Add Change logs

Test

• 12/26~12/27 - Run test plan #4
• 12/26~12/27 - Fix bugs

Release

• Add version Tag
• Merge master to develop
• push to market

[Mac,Linux]debug on tomcat will fail if you have debug it before

Repro steps:

1. right click war package, click "debug on tomcat"
2. open the app url and wait for the breakpoint hit
3. click disconnect to stop debug and stop tomcat in tomcat explore
4. right click war package, click "debug on tomcat" again.
5. error occured
   

0.4.0 Plan

• Add command in server tree explorer for user to create a new server

• Fix bug #37: show no command when there is no server in the server tree explorer

• Show info message instead of error when this is no tomcat server to delete or stop #38

• Allow user to browser to create new tomcat server when there is no server to start

• Proceed with info message instead of pop up error when user creates same tomcat server #32

• Categorize and better naming commands #29

• Browse file explorer directly for user to select tomcat server or war package without clicking browser

Spawn jar ENOENT error when try to debug/run on tomcat server

Met this issue from the very beginning I use the extension.

jar command runs very well on any console in Windows 10. But when I tried to Debug a war on tomcat server, or run a war on tomcat server. It just failed with Error: Spawn jar ENONET.

Repro steps:

1. Add jdk/bin to the very end of Path
2. Launch VSCode with Tomcat Extension
3. Find a .war file, right-click Run on tomcat server

Expected:
Successfully run the war file on tomcat server.

Actual:
Error: Spawn jar ENOENT. And nothing continue.

The issue may be external to VSCode or NodeJS, but also file an issue to track it here.

0.2.0 Plan

• Open server.xml of tomcat instance #2
• Start debug session after start jvm #3

tomcat server disappear when open another folder in vscode

Repro steps:

1. open folder A with vsode
2. create a tomcat server
3. start the tomcat server
4. open folder B in same vscode windows

Expected:
The same tomcat server shows up in server explorer and is running.

Actual:
No server in server explorer.

Delete a tomcat server when the deploy process is still running throw error

repro step:

Deploy a war package (e.g the spring boot sample project ) to a tomcat server, when the deploy process is running delete the server ,error occur.

I think we may give a better error message for this issue or remind the user the deploy process is still running.

check if the selected tomcat directory valid

Open server.xml

Add entry to open server.xml from the tomcat instance in the workspace. So that user can view the current configurations and change port.

Command "Open server.xml" shows in TomcatServerTree view when there is non server

Repro Steps:

1. clean all tomcat servers in the tomcat server tree view
2. right-click the empty area

Expected: No commands

Actual: "Open server.xml" command shows up and error poped up when user clicks it.

0.4.0 Test Plan

Features

Basic

• Can run war package
• Can debug war package
• Can link multiple tomcat instances
• Can shutdown the running tomcat instance
• Can delete the stopped tomcat instance
• The tomcat instances can be saved in work space
• Can open server.xml of selected tomcat instance
• Can update the server.xml and run tomcat instance based on the modification
• Can start Tomcat from Tomcat Explorer
• Can restart if server.xml is update during running
• Can open in browser from Tomcat Explorer

From 0.4.0

• All tomcat commands have same pattern "Tomcat: xx_command"
• No command shows in Tomcat Server Explorer if there is no server in the tree
• User gets an info message saying "There are no Tomcat Servers." when run command "Tomcat: Delete Tomcat Server" from command platte and there is no server to delete
• User gets an info message saying "There are no Tomcat Servers." when run command "Tomcat: Stop Tomcat Server" from command platte and there is no server to stop
• User could browser to select a new tomcat server when run command "Tomcat: Start Tomcat Server" from command platte and there is no server to start
• User could click "+" button in tomcat server explorer to create a new tomcat server
• Run command "Tomcat: Run on Tomcat Server", user could just navigate to select a war package then a tomcat directory without clicking "Browse..." twice
• Fix issue #64 #60 #61 #62 #63

OS

• Windows
• OS X
• Linux

Reference

README

Error message shows not clear enough information to user when no server to stop

Retro steps:

1. Run command "Stop Tomcat Server" from command platte
2. Select a stopped server

Expected:
A friendly error/info message to tell user what's going on, or even further filter the stopped servers.

Actual:

0.2.0 Endgame

Build

• 12/6 - Bump version to 0.2.0
• 12/7 - Add Change logs

Test

• 12/6~12/7 - Run test plan #4
• 12/6~12/7 - Fix bugs

Release

• Add version Tag
• Merge master to develop
• push to market

[Enhancement] Update command title 'Run on tomcat server' to 'Deploy to tomcat server'

Following the most popular used terminology,

Restart tomcat failed after modify server.xml

Repro steps

1. modify server.xml of a running tomcat
2. VScode pop out a window and click yes
   
3. restart failed and the tomcat has been shutdown.
   
   

Add option to create new server to start

When run command "Tomcat: Start Tomcat Server", allow user to create new one to start.