adcade/puppet-thrift

puppet module for thrift

puppet-thrift's Issues

Resource Ordering Issue in instool.pp

Should the 'before' in the following from instool.pp...

  file{$instdir:
    ensure  => directory,
    recurse => true,
    source  => $tmpdir,
    before  => Exec['download_and_untar'],
  }

...be a 'require'...

  file{$instdir:
    ensure  => directory,
    recurse => true,
    source  => $tmpdir,
    require => Exec['download_and_untar'],
  }

This file resource is trying to recursively copy its contents from $tmpdir, but $tmpdir has no contents until Exec['download_and_untar'] is applied.

The module would not work for me until I made the above modification.

wget download error

I'm trying to install Thrift with puppet-thrift, but the wget download is failing.

Source:

class { 'thrift': }

Trace:

Error: wget -qO- https://dist.apache.org/repos/dist/release/thrift/0.9.0/thrift-0.9.0.tar.gz | tar xzf - -C /tmp returned 2 instead of one of [0]
Error: /Stage[main]/Thrift/Instool[thrift-0.9.0]/Exec[download_and_untar]/returns: change from notrun to 0 failed: wget -qO- https://dist.apache.org/repos/dist/release/thrift/0.9.0/thrift-0.9.0.tar.gz | tar xzf - -C /tmp returned 2 instead of one of [0]
Warning: /Stage[main]/Thrift/Instool[thrift-0.9.0]/File[/usr/local/lib/thrift-0.9.0]: Skipping because of failed dependencies
Warning: /Stage[main]/Thrift/Instool[thrift-0.9.0]/Exec[./configure]: Skipping because of failed dependencies
Warning: /Stage[main]/Thrift/Instool[thrift-0.9.0]/Exec[make]: Skipping because of failed dependencies
Warning: /Stage[main]/Thrift/Instool[thrift-0.9.0]/Exec[make install]: Skipping because of failed dependencies
Warning: /Stage[main]/Thrift/Instool[thrift-0.9.0]/Exec[make clean]: Skipping because of failed dependencies

Conflict with puppetlabs/ruby: duplicate package['tar']

See https://github.com/puppetlabs/puppetlabs-ruby/issues/26.

README: add example usage

I'm a little confused how to use puppet-thrift to install Thrift.

Could you please add an example Puppet code snippet to the README?