adempiere/proxy-adempiere-api

Storefront GraphQL API Gateway. Modular architecture. ElasticSearch included. Works great with Magento1, Magento2, Spree, OpenCart, Pimcore and custom backends

proxy-adempiere-api's Issues

Command error when build docker image

Current behavior

When I run docker-compose up, I get the next error on image construction.

/bin/sh: syntax error: unexpected "&&"
The command '/bin/sh -c apk --no-cache --update upgrade musl    && apk add --no-cache       --repository http://dl-cdn.alpinelinux.org/alpine/edge/community       --repository http://dl-cdn.alpinelinux.org/alpine/edge/main       --virtual .build-deps     curl          git              python          make            g++             ca-certificates                 wget &&   && yarn install --no-cache   && apk del .build-deps' returned a non-zero code: 2
ERROR: Service 'app' failed to build : Build failed

That is because in the image build, in the package installation, there are two "&&" together.

Expected behavior

Replace with one "&&" or add a missing command if necesary

Steps to reproduce the issue

Run docker-compose up

Endpoint test with curl outdated

Current behavior

The current example with curl with the actual endpoint is outdated, this not get a OK 200 code message

Expected behavior

Get a OK 200 code message

Steps to reproduce the issue

Run the curl command to an updated proxy instance

curl 'https://api.erpya.com/adempiere-api/user/login' \
    -X POST \
    -H 'content-type: application/json' \
    -H 'accept: */*;charset=UTF-8' \
    --data-binary '{"username":"demo","password":"demo"}'

[Security] Workflow docs.yml is using vulnerable action actions/checkout

The workflow docs.yml is referencing action actions/checkout using references v1. However this reference is missing the commit a6747255bd19d7a757dbdda8c654a9f84db19839 which may contain fix to the some vulnerability.
The vulnerability fix that is missing by actions version could be related to:
(1) CVE fix
(2) upgrade of vulnerable dependency
(3) fix to secret leak and others.
Please consider to update the reference to the action.