admin-ch/covidcertificate-management-service

covidcertificate-management-service's Issues

Unbounded Query when retrieving the revocation list

The implementation of findAllUvcis has an unbounded query. This is not an issue for 1000s of revocations, but considering that entire lots of certain vaccines could become known as ineffective, the number of revoked certificates may quickly increase by 10^5 certificates weekly. Devices calling this endpoint even in small numbers on a daily basis will potentially DoS the system, exceed any limits for response body sizes and provoke timeouts.

@Repository
public interface RevocationRepository extends JpaRepository<Revocation, UUID> {
    Revocation findByUvci(String uvci);

    @Query("SELECT r.uvci FROM Revocation r")
    List<String> findAllUvcis();
}

Hope this is..

I truly hope this is either a joke or a primary school project.

Wrong Signing-Certificate is used for Certificate-Conversion

This should actually reference the getVaccinationConversionSigningInformation(LocalDate validAt) function.

CovidCertificate-Management-Service/src/main/java/ch/admin/bag/covidcertificate/service/SigningInformationService.java

Line 103 in ef9df29

return getVaccinationTouristSigningInformation(LocalDate.now());

Code uses WebClient but blocks

The code uses the reactive WebClient but ends up calling #block() which, as the name suggests, blocks and therefore defeats the whole purpose of using WebClient in the first place. Examples:

• CovidCertificate-Management-Service/src/main/java/ch/admin/bag/covidcertificate/client/printing/internal/DefaultPrintQueueClient.java

  Line 43 in 638a260

  .block();

• CovidCertificate-Management-Service/src/main/java/ch/admin/bag/covidcertificate/client/valuesets/internal/DefaultValueSetsClient.java

  Line 41 in b03d2ef

  .block();

• CovidCertificate-Management-Service/src/main/java/ch/admin/bag/covidcertificate/client/inapp_delivery/internal/DefaultInAppDeliveryClient.java

  Line 53 in 74c2ca7

  .block();

The code should instead do one of the following:

• Avoid calling #block() and instead call #subscribe()
• Switch from the reactive WebClient to the blocking RestTemplate

Considering all the rest of the code is blocking (JpaRepository, …) WebClient seems like the better match.