admiralnelson/bannerlord-error-detector

BetterExceptionWindow

Throws silenced unhandled errors to the user. This helped identification of XML/DLL error without use of debugger

demo: https://www.youtube.com/watch?v=uu9iEFRz3eY&feature=youtu.be

bannerlord-error-detector's Issues

Crash when i try to upgrade troops

Hello. So im new to the whole modding community. Just downloaded my first mods and it crashed when i tryed to upgrade a unit. Anyone that could se the problem in this code since im new to this i have no idea what to really look for or what caused the issue in the first place :D thanks!

Also it asked me if i wanted to download the error bug but it just makes it a google chrome link and cant add it here. Maybe this will work

Crash when i try to upgrade troops

Crashes under 1.7.2

To Fix:
I added a reference to the Taleworlds.ScreenManager dll.
Updated all references to 1.7.2
Changed Main.vb
Imports TaleWorlds.ScreenSystem

line 65/66 :
<HarmonyPatch(GetType(ScreenManager), "Tick")>

Closing the window tramples diagnostic report generation

Since you've wired up the exception window to kill the application;

<button class='button' onclick='window.external.CloseProgram()'>

    Public Sub CloseProgram()
        Dim pid = Process.GetCurrentProcess().Id
        Dim proc As Process = Process.GetProcessById(pid)
        proc.Kill()
    End Sub

Further exception handlers don't get a chance to run.

Also, if somehow the exception is non-fatal, you kill the program anyway.

Could you consider not killing the program?

It'd let me at least get diagnostic reports generated when people crash while using Community Patch.

I got some guy recommending your modification together with the Community Patch, and it's quite annoying to get complaints that no diagnostic report was generated during a crash.