adonisjs/sink

Development Toolbox for AdonisJS providers

Code mods for AdonisJS project files

AdonisJS sink is a swiss knife for managing project files by applying minimal changes, inferring formatting from EditorConfig file and comes with specialized tasks for different file formats and file types.

Website | Guides | Contributing

_{Built with ❤︎ by Harminder Virk}

sink's Issues

ESM

Package version

5.3.0

Node.js and npm version

Node : 16.14.2
npm: 8.5.0

Sample Code (to reproduce the issue)

node ace configure @adonisjs/lucid

https://media.discordapp.net/attachments/971148771859791914/971149190849790022/Screenshot_10.png

peer dependency mismatch

This package depends on marked v2 and marked-terminal. marked-terminal has marked in its peer dependencies, but wants version ^1.0.0, so v2 is not compatible with that.

Warning with npm 7:

npm WARN ERESOLVE overriding peer dependency
npm WARN Found: [email protected]
npm WARN node_modules/marked
npm WARN   marked@"^2.0.0" from @adonisjs/[email protected]
npm WARN   node_modules/@adonisjs/sink
npm WARN     @adonisjs/sink@"^5.0.0" from @adonisjs/[email protected]
npm WARN     node_modules/@adonisjs/assembler
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer marked@">=0.4.0 <2.0.0" from [email protected]
npm WARN node_modules/marked-terminal
npm WARN   marked-terminal@"^4.1.0" from @adonisjs/[email protected]
npm WARN   node_modules/@adonisjs/sink

Update `marked` and `marked-terminal`

Versions 4 of marked and 5 of marked-terminal are available.
They are native ESM packages now, but since they are used in async functions, we could dynamically import() them.