Giter Site home page Giter Site logo

Comments (5)

rwwagner90 avatar rwwagner90 commented on June 2, 2024 1

@achambers seems reasonable to me

from ember-launch-darkly.

achambers avatar achambers commented on June 2, 2024

Ok, I've been spiking this out and I think I have a good idea of where this can get to and I think we can simplify this repo substantially.

Going to knock together a branch with the changes to get a better feel for them and to share some thoughts around the changes.

/cc @mansona

from ember-launch-darkly.

achambers avatar achambers commented on June 2, 2024

@mansona @jaredgalanis @rwwagner90 @patcoll

I've taken a stab at rewriting this addon in an Octane/@tracked world and I'd love to get some feedback and thoughts from any or all of you folks if you have any interest in it.

The PR is #225 however it's not review worthy as yet - I need to clean it up a lot.

But your best bet might be to have a look at the updated README.md and the new UPGRADING_TO_1.x.md files that are in the PR. They should give you a good idea as to what the public "api" might look like in the modern Octane world.

The changes are going to hugely simplify things and remove a number of files which is great.

Would need to discuss what this would mean for pre-Octane projects as I'm not sure how we should best handle this so I'm interested in your thoughts on that. But, for now, if you wouldn't mind giving me some feedback on the approach then that'd be much appreciated.

from ember-launch-darkly.

achambers avatar achambers commented on June 2, 2024

Ok, been chatting with @mansona on this and things look positive. Something I'm clearer on now is what the compatibility of this new world looks like.

This is my plan:

  1. Release the current https://github.com/adopted-ember-addons/ember-launch-darkly/releases/tag/v1.0.0-beta.0 as v1.0.0. This will be the version that is recommended for Ember versions pre 3.12
  2. Release the new Octane/tracked friendly version as v2.0.0 and recommend this for Ember versions 3.12 and above.

This is my plan. If there is any reason to reconsider this, I'd love to hear it @jaredgalanis @rwwagner90 . Otherwise, I'll go ahead and release v1.0.0 and get the new world changes ready for v2.0.0

from ember-launch-darkly.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.