Giter Site home page Giter Site logo

Comments (8)

SkoebaSteve avatar SkoebaSteve commented on June 9, 2024 1

@achambers

from ember-launch-darkly.

herzzanu avatar herzzanu commented on June 9, 2024

@SkoebaSteve It looks like we can close this one.

from ember-launch-darkly.

SkoebaSteve avatar SkoebaSteve commented on June 9, 2024

@herzzanu yes thanks for the work on this 💪

I think we can release v3 this week, I just want to see if we want to combine it with also using LD's new version as well: #391. It has some differences in how to use the context that we would need to see if it is compatible.

WDYT?

from ember-launch-darkly.

herzzanu avatar herzzanu commented on June 9, 2024

Yes, I think #391 needs some closer investigation first. I'll have a look at it.

In the same time I started porting it to a V2 addon, maybe we can ship it in V3 🙏

from ember-launch-darkly.

SkoebaSteve avatar SkoebaSteve commented on June 9, 2024

Just merged the v3 client of LD, looks to be non breaking: dd1d2fc

Let's move forward with the v3 version without migrating it to a v2 addon and do that after, I think dropping old ember and node versions, auto-import v2 is enough to release a new v3 :)

@herzzanu @achambers WDYT? If this is ok I'll update the docs as well this week before releasing

from ember-launch-darkly.

herzzanu avatar herzzanu commented on June 9, 2024

@SkoebaSteve Do we need a major release given the new LD api is non-breaking?

from ember-launch-darkly.

SkoebaSteve avatar SkoebaSteve commented on June 9, 2024

@SkoebaSteve Do we need a major release given the new LD api is non-breaking?

@herzzanu For me deprecating older ember and node versions meant it is breaking. Also just found out that there's one breaking change we need to fix 🙈 #409 (comment)

from ember-launch-darkly.

herzzanu avatar herzzanu commented on June 9, 2024

Yes, true. Forgot about that comment as well. It was the reason I mentioned it needs some investigation.

from ember-launch-darkly.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.