Support for LaunchDarkly's contexts upgrade

[tniezurawski]

Support for LaunchDarkly's contexts upgrade

[SkoebaSteve]

@tniezurawski thanks for sharing this. It's on my list to verify this at Qonto next week so if it's all ✅ we'll bump it after that.

[SkoebaSteve]

@tniezurawski yep you're right, we actually were not relying on the user getter here ourselves but it breaks indeed:

I'll create a fix for this, thanks for spotting!

[tniezurawski]

It looks it should be as easy as setting an extra property to pass to identify() method:

let customProps = {
 someKey: 'some-value'
};
let props = {
  key: user.id,
  kind: 'my-new-context',  // "user" by default
  anonymous: false,
  custom: customProps,
};

await identify(props);

I think no changes, besides bumping launchdarkly-js-client-sdk to version 3.0.0, would be needed.

---

Feel free to close it, or close when we have the SDK upgraded 👌

[SkoebaSteve]

I validated it on our side and there's no breaking change with the addon as far as I can see so I merged it, it will be part of our new v3 release where we will drop some older ember/node versions.

I'll keep you posted, should be this week

[tniezurawski]

Great stuff @SkoebaSteve 🙌 I'm not super familiar with internals here and probably don't use everything that is possible in this addon but do you think this code:

ember-launch-darkly/addon/-sdk/context.js

Line 112 in 8c06fac

return this.client.getUser();

might be affected by a breaking change and should be tweaked?

LDClient.getUser has been replaced with LDClient.getContext.