adopted-ember-addons/ember-metrics

Send data to multiple analytics integrations without re-implementing new API

ember-metrics's Issues

Accessing adapter's specific API

Using the Piwik service, I wanted to use its trackLink(url, linkType) function.

For now, it's possible, by implementing the trackLink function in the adapter, and calling it via metrics.invoke('trackLink', 'Piwik', { url: 'url', linkType: 'download' })

This seems obviously not possible to add each possible adapter function in the metrics api, so I wonder what could be done for such a case.

Maybe using invoke is just fine, and in that case, I will gladly open a PR to document it in the readme.

TypeError: Cannot read property 'identify' of undefined

Hello,

I'm getting the "Cannot read property" error when I try to run the following code:

    @get('metrics').identify('Mixpanel', {
      distinctId: '[email protected]'
    })

The error is coming from metrics.js line 130:
https://github.com/poteto/ember-metrics/blob/master/addon/services/metrics.js#L130

This code has been running fine in my 'production' environment. When I recently added a 'localhost' environment is when I got the error.

My config/environment.js looks like this:

  if (environment === 'localhost') {
      ENV.apiHost = 'http://localhost';
      ENV.apiURL = 'http://localhost'
      ENV.metricsAdapters = [{
          name: 'Mixpanel',
          environments: ['development'],
          config: { token: 'xxxxx' },
          includeAdapters: ['mixpanel']
      }, ]
  }
  if (environment === 'production') {
    ENV.apiHost = 'https://my-domain.com';
    ENV.apiURL = 'https://my-domain.com';
    ENV.metricsAdapters = [
      {
        name: 'Mixpanel',
        environments: ['production'],
        config:{ token: 'xxxxx' },
        includeAdapters: ['mixpanel']
      },
    ]
  }

Is there something weird because I have this 'localhost' env?

Any help is appreciated! Thanks!

Add support for Fastboot

I'm running into issues using ember-metrics with fastboot due to window being undefined. As I understand it, any use of browser globals need to be guarded. Working on a PR now that should solve it.

Error running ember test and ember server

Hi! I'm new to ember, so this could be something on my end, but I've followed the installation and configuration steps in the README, and am getting an error when running ember test and ember server.

Environment:

> ember -v
version: 0.2.3
node: 0.12.12
npm: 2.7.6

Changes:

> git diff
diff --git a/config/environment.js b/config/environment.js
index e928b12..647d58c 100644
--- a/config/environment.js
+++ b/config/environment.js
@@ -16,7 +16,17 @@ module.exports = function(environment) {
-    }
+    },
+
+    metricsAdapters: [
+      {
+        name: 'Mixpanel',
+        environments: ['development'],
+        config: {
+          token: 'XXXXXXXXXXXXXXXXXXXXXXXXXX'
+        }
+      }
+    ]
   };                                                                                                                                                                                                                           

diff --git a/package.json b/package.json
index df63ba3..3c53236 100644
--- a/package.json
+++ b/package.json
@@ -40,6 +40,7 @@
     "ember-data": "1.0.0-beta.16.1",
     "ember-drag-drop": "^0.1.4",
     "ember-export-application-global": "^1.0.0",
+    "ember-metrics": "0.6.0",
     "ember-select-2": "1.2.0",
     "ember-template-compiler": "^1.9.0-alpha",
     "ember-validations": "^2.0.0-alpha.3",

Error when running tests:

> ember test
ember test
version: 0.2.3

A new version of ember-cli is available (2.4.2). To install it, type ember update.
Invalid watchman found, version: [4.4.0] did not satisfy [^3.0.0], falling back to NodeWatcher.
Visit http://www.ember-cli.com/#watchman for more info.
Build failed.
File: frontend/initializers/metrics.js
Line 5: Unexpected token =
Error: Line 5: Unexpected token =
    at throwError (/Users/bploetz/frontend/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima-fb/esprima.js:2692:21)
    at throwUnexpected (/Users/bploetz/frontend/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima-fb/esprima.js:2754:9)
    at expect (/Users/bploetz/frontend/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima-fb/esprima.js:2763:13)
    at parseObjectInitialiser (/Users/bploetz/frontend/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima-fb/esprima.js:3303:17)
    at parseVariableDeclaration (/Users/bploetz/frontend/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima-fb/esprima.js:4650:18)
    at parseVariableDeclarationList (/Users/bploetz/frontend/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima-fb/esprima.js:4690:23)
    at parseConstLetDeclaration (/Users/bploetz/frontend/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima-fb/esprima.js:4721:24)
    at parseSourceElement (/Users/bploetz/frontend/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima-fb/esprima.js:6267:24)
    at parseFunctionSourceElements (/Users/bploetz/frontend/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima-fb/esprima.js:5603:29)
    at parseFunctionDeclaration (/Users/bploetz/frontend/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima-fb/esprima.js:5800:16)

Running ember server yields the same error:

> ember server
version: 0.2.3

A new version of ember-cli is available (2.4.2). To install it, type ember update.
Invalid watchman found, version: [4.4.0] did not satisfy [^3.0.0], falling back to NodeWatcher.
Visit http://www.ember-cli.com/#watchman for more info.
Livereload server on port 35729
Serving on http://localhost:4200/
File: frontend/initializers/metrics.js
Line 5: Unexpected token =
Error: Line 5: Unexpected token =
    at throwError (/Users/bploetz/frontend/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima-fb/esprima.js:2692:21)
    at throwUnexpected (/Users/bploetz/frontend/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima-fb/esprima.js:2754:9)
    at expect (/Users/bploetz/frontend/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima-fb/esprima.js:2763:13)
    at parseObjectInitialiser (/Users/bploetz/frontend/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima-fb/esprima.js:3303:17)
    at parseVariableDeclaration (/Users/bploetz/frontend/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima-fb/esprima.js:4650:18)
    at parseVariableDeclarationList (/Users/bploetz/frontend/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima-fb/esprima.js:4690:23)
    at parseConstLetDeclaration (/Users/bploetz/frontend/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima-fb/esprima.js:4721:24)
    at parseSourceElement (/Users/bploetz/frontend/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima-fb/esprima.js:6267:24)
    at parseFunctionSourceElements (/Users/bploetz/frontend/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima-fb/esprima.js:5603:29)
    at parseFunctionDeclaration (/Users/bploetz/frontend/node_modules/ember-cli/node_modules/broccoli-es3-safe-recast/node_modules/es3-safe-recast/node_modules/recast/node_modules/esprima-fb/esprima.js:5800:16)

Even if I remove the metricsAdapters from config/environment.js, the problem persists, so it seems as though simply having the ember-metrics dependency causes this.

Any ideas?

Use set prior to send?

I wonder if in the GA adapter, set shouldn't be used to update the tracker prior to send. The documentation indicates:

While technically the send command for pageview hits accepts an optional page field as the third parameter, passing the page field that way is not recommend when tracking single page applications. This is because fields passed via the send command are not set on the tracker—they apply to the current hit only. Not updating the tracker will cause problems if your application sends any non-pageview hits (e.g. events or social interactions), as those hits will be associated with whatever page value the tracker had when it was created.

https://developers.google.com/analytics/devguides/collection/analyticsjs/single-page-applications#tracking_virtual_pageviews

I'm not sure if how the way the adapter currently works (sending object to send with hitType) will address this, so thought I'd open this issue.

Content security policy not solved

mixpanel-2-latest.min.js:64 [Report Only] Refused to connect to 'http://api.mixpanel.com/track/?data=eyJldmVudCI6ICJwYWdlIHZpZXdlZCIsInByb3B…TJkODdlNDBiODZhNGRmMWQ1ZGRhYjg0NCIsIiRfX2MiOiAwfX0%3D&ip=1&_=1470169823818' because it violates the following Content Security Policy directive: "connect-src 'self' 'unsafe-inline' http://*.pubnub.com https://*.pubnub.com https://auth.firebase.com https://api.mixpanel.com wss://*.firebaseio.com wss://*.remoto.me:* http://*.remoto.me:* ws://*.remoto.me:* https://*.remoto.me:* ws://localhost:49152 ws://0.0.0.0:49152 http://undefined:4200/csp-report".

I have this error, but i already put mixpanel in content security policy in my environment.js

contentSecurityPolicy: {
  'default-src': "'none'",
  'script-src': "'self' https://api.mixpanel.com",
  'font-src': "'self'",
  'connect-src': "'self' https://api.mixpanel.com",
  'img-src': "'self'",
  'style-src': "'self'",
  'media-src': "'self'"
}

Depreciation in Ember 2.1

In 2.1 a deprecation was added:

DEPRECATION: The initialize method for Application initializer 'metrics' should take only one argument - App, an instance of an Application. [deprecation id: ember-application.app-initializer-initialize-arguments] See http://emberjs.com/deprecations/v2.x/#toc_initializer-arity for more details.

If I get a chance later, I'll try to create a PR to fix this. But if someone else has time to do it sooner, that'd be great.

Don't break if no config

Proposal: expose metrics.context for properties that should be included with every event

Most apps have certain pieces of context that should be included with every pageView or event e.g. currentUser.name, currentTenant.name.

I'd like to propose that we expose metrics.context. Anything that's bound to this context would be merged into the options e.g.

export default Ember.Route.extend({
    setupController(controller, model) {
        var currentTenant = model;
        this.set('metrics.context.tenantName', currentTenant.name);
    }
});

metrics.trackEvent({event: 'demo_requested'}); 
// => {event: 'demo_requested', tenantName: "name of current tenant"};

I'm currently adding it to an app by wrapping the metrics service with another analytics service that does the same thing but it occurred to me that it might be a useful feature to include in the library. If people are keen I'll put a PR together.

More integrations

On my phone, so I can't flesh this out, but I figured I'd leave this link here as a list of possible integrations to add, as people need them and/or want to contribute something. Several are already supported or WIP, yay!

http://www.practicalecommerce.com/articles/74832-14-Alternatives-to-Google-Analytics

KISSMetrics Adapter

Figure out how to get the script tag so it can be loaded on init

Not recognizing passed in services

I'm having issues specifying the specific services I want to use. Not sure what the correct syntax is but I've tried all combinations specified in the readme. An example of what I've tried:

this.get('metrics').trackEvent(['Mixpanel', 'Segment'], { event: "Event example" });

contentSecurityPolicy img-src

I believe that in the readme you forgot to include google 1x1 image, namely:

contentSecurityPolicy: {
    'img-src':     ["'self' www.google-analytics.com"]
}

Update readme with list of adapters

Prioritize local adapters over bundled adapters

Fastboot-friendly Usage Tips

The suggested usage of this addon points users toward something that won't work with Fastboot

// app/router.js
import Ember from 'ember';
import config from './config/environment';

const Router = Ember.Router.extend({
  location: config.locationType,
  metrics: Ember.inject.service(),

  didTransition() {
    this._super(...arguments);
    this._trackPage();
  },

  _trackPage() {
    Ember.run.scheduleOnce('afterRender', this, () => {


     // THIS LINE REFERS TO A GLOBAL THAT DOESN'T EXIST IN FASTBOOT LAND
      const page = document.location.pathname;
     // THIS LINE REFERS TO A GLOBAL THAT DOESN'T EXIST IN FASTBOOT LAND


      const title = this.getWithDefault('currentRouteName', 'unknown');

      Ember.get(this, 'metrics').trackPage({ page, title });
    });
  }
});

No-op for disabled services

Right now if I have a service configured for production only or don't have an API key present it throws a javascript error when I try to call functions on the metrics service. It would be super if it just resulted in a no-op instead so I wouldn't have to have all these guards in my code for its presence.

Depreciation in Ember 2.8

DEPRECATION: Enumerable#contains is deprecated, use Enumerable#includes instead. [deprecation id: ember-runtime.enumerable-contains] See http://emberjs.com/deprecations/v2.x#toc_enumerable-contains for more details.

TypeError: Cannot read property 'trackEvent' of undefined

I'm getting below error :
ember.debug.js:29169 Uncaught TypeError: Cannot read property 'trackEvent' of undefined

The Output of requirejs.entries is below

config/environment.js

`
module.exports = function(environment) {
var ENV = {
metricsAdapters: [
{
name: 'Mixpanel',
environments: ['all'],
config: {
token: 'mixpanel_token'
}
}
],
....

....
}
}

`

Add below code in my controller

`
import Ember from 'ember';
import config from './config/environment';

....
....

Ember.get(this, 'metrics').trackEvent('Mixpanel', {
title: 'New Event'
});

....
.....
`

Please look into this. I'm using "ember-cli": "1.13.8" version

Finish augmented LinkComponent

• Ability to specify adapter name

Blueprint should also generate a unit test

• Verify that method returns the correct response shape

Event Example

Having a bit of trouble calling a track event from a controller. Not too sure if I've found a bug or I'm just doing it wrong. Can someone post an example?

Reinitialize Adapters for Different Pods

We have a rather large app with a bunch of different pods under. Right now, I can pass the info in using lazy loading but only the info from the first loaded pod is used. Sounds crazy, right? (We're using Segment for this example)

Why would you do something like that you ask?

Because it would allow us to treat our pods like separate apps all living under the same umbrella with different and distinct tracking information. I'd really hate to have to split all our code into separate apps just to get the tracking info working as described.

I think it would be awesome if I could use the lazy loading technique to override an adapter instance with a new key when loading into a route.

Do you have any suggestions on how to accomplish this?

Version bump / facebook pixel adapter

A "facebook pixel" adapter has been added about a month ago. It is very confusing to read about it on README.md file a then find out it is not available on latest release (version 0.7.0).

What are contributing rules in such situations? What do you think about releasing more often?

Issues when running `ember test`

We're currently experiencing an error when running ember test in our app:

Attempting to inject an unknown injection: `service:metrics`

We currently have over ~150 failing tests due to this issue.

If we add the following, the test passes:

moduleForComponent('box-tabs', {
+  needs: ['service:metrics']
});

Is the right approach to add in the needs in all ~150 failing tests, or, is there a better solution?

[DEPRECATION] Use new `getOwner` API for accessing container

Example of Google Tag Manager

Could you please provide an example of how to use Google TagManager with the dataLayer property being populated.

It would be really appreciated.

Thank you.

Update ember-cli to 2.3.0

Pass in a hash of integrations instead of a string to the service

e.g.

metrics.trackEvent({
  integrations: {
    GoogleAnalytics: true,
    Mixpanel: false,
    'customer.io': true
  },
  event: 'foo',
  action: 'bar'
});

Potential issues:

• What if I want to send a property to the analytics service that is called integrations?
  • possible solutions – prefix integrations, pass in 2 objects as args

Debug State

It would be nice if there were a way to turn on debug logging when implementing events in ember metrics. For instance, instead of tracking events with google analytics, it logs some info in the console about what would be sent up to GA.

Crazy Egg Adapter

Not working with child addon

When I include ember-metrics addon into a another addon, I am getting an error.

Could not find metrics adapter GoogleAnalytics

I'm attempting to add ember-metrics to my Ember project, starting with Google Analytics.

I've set my app/router.js and config/environment.js as per this projects README:

config/environment.js

var ENV = {
...
    metricsAdapters: [
      {
        name: 'GoogleAnalytics',
        environments: ['all'],
        config: {
          id: 'UA-XXXX-Y'
        }
      }
    ],
...
}

app/router.js

import Ember from 'ember';
import config from './config/environment';

const Router = Ember.Router.extend({
  location: config.locationType,
  metrics: Ember.inject.service(),

  didTransition() {
    this._super();
    this._trackPage();
  },

  _trackPage() {
    Ember.run.scheduleOnce('afterRender', this, () => {
      const page = document.location.pathname;
      const title = this.getWithDefault('currentRouteName', 'unknown');

      Ember.get(this, 'metrics').trackPage({ page, title });
    });
  }
});

export default Router;

However I don't see the GA code snippet being inserted into my compiled JS, and I am getting the following error in my dev console

Uncaught Error: Assertion Failed: [ember-metrics] Could not find metrics adapter GoogleAnalytics.assert @ ember.debug.js:6254assert @ ember.debug.js:16075_activateAdapter @ metrics.js:223(anonymous function) @ metrics.js:148activateAdapters @ metrics.js:145init @ metrics.js:90superWrapper @ ember.debug.js:22633Class @ ember.debug.js:36144ClassMixinProps.create @ ember.debug.js:36422instantiate @ ember.debug.js:1511lookup @ ember.debug.js:1361Container.lookup @ ember.debug.js:1291(anonymous function) @ ember.debug.js:32719injectedPropertyGet @ ember.debug.js:16861ComputedPropertyPrototype.get @ ember.debug.js:14893get @ ember.debug.js:20290(anonymous function) @ router.js:19Queue.invoke @ ember.debug.js:327Queue.flush @ ember.debug.js:391DeferredActionQueues.flush @ ember.debug.js:192Backburner.end @ ember.debug.js:570Backburner.run @ ember.debug.js:692Backburner.join @ ember.debug.js:712run.join @ ember.debug.js:20709(anonymous function) @ ember.debug.js:20772fire @ jquery.js:3099self.fireWith @ jquery.js:3211jQuery.extend.ready @ jquery.js:3417completed @ jquery.js:3433```

Is there something I'm missing?

I've created an adapter addon for Chameleon

I've just created today this addon: https://github.com/cibernox/ember-metrics-chameleon-adapter

It's basically code that I wrote ~6m ago, but now I happen to need in two projects and I decided to extract it into an addon.

Chameleon is not exactly a tracking library, but the similarities are enough to make ember-metrics somehow useful and a good abstraction around any library that that you want to lazy-initialize from an external script to then identify/trackEvents with it.

If you even want to merge this adapter into the default set of adapter just let me know and I'll be happy to PR those changes here.

Support for Piwik

I would be very interested in contributing tracking for Piwik. Would that be something you are interested in?

Consider Integrating Analytics.js

Analytics.js has a ton of existing integrations with a bunch of different providers. Figured I'd mention it since your project has a similar goal.

Cheers

The intercom adapter does not load the Intercom API correctly

The intercom adapter does not always load the Intercom API correctly as it's dependent on window.load.

[QUESTION] Test extended built-in adapters

I cleanup my own Piwik adapter using the built-in one. I just have some customization for the adapter (like sending custom dimensions).

I have define a app/metrics-adapters/piwik.js, like this:

import PiwikAdapter from 'ember-metrics/metrics-adapters/piwik';

export default PiwikAdapter.extend({
  identify(options = {}) {
    this._super(...arguments);
    window._paq.push(['setCustomDimension', 1, options.organizationName]);
    window._paq.push(['setCustomDimension', 2, options.userId]);
  }
});

So far, so good, but when I wanted to test it, I can"t find a way to resolve ember-metrics/metrics-adapters/piwik.

In the needs property of my unit test, I tried to add a reference to ember-metrics@metrics-adapter:piwik with no success, I encounter this error: Attempting to register an unknown factory: 'ember-metrics@metrics-adapter:piwik'.
When referencing ember-metrics@metrics-adapter:base, it seems like the BaseAdapter is beeing correctly resolved.

So my question: How can I test an extended adapter ?

Intercom adapter

We use Intercom in our app and we're currently adding it to a custom ember-metrics adapter. Would be happy to create a PR if you'd consider adding Intercom support to ember-metrics core?

The adapter generator does not include a willDestroy method.

According to the README, the willDestroy method is required but when generating a new adapter the method is not included in the stub.

$ ember generate metrics-adapter foo-bar

import BaseAdapter from 'ember-metrics/metrics-adapters/base';

export default BaseAdapter.extend({
  toStringExtension() {
    return 'foo-bar';
  },

  init() {

  },

  identify() {

  },

  trackEvent() {

  },

  trackPage() {

  },

  alias() {

  }
});

getting Cannot read property 'alias' of undefined

Hello,

I'm having issues when calling the alias function (I'm using Mixpanel and GoogleTagManager adapter) from a unauthenticatedRouteMixin mixin that I use for my app routes. It looks like Ember.get(this, 'metrics') is undefined.

The error occurres when I do:

const metrics = Ember.get(this, 'metrics');
metrics.alias(distinct_id);

Here's my configuration:

    metricsAdapters: [
      {
        name: 'GoogleTagManager',
        environments: ['development', 'production'],
        config: {
          id: 'GTM-KKHS44'
        }
      },
      {
        name: 'Mixpanel',
        environments: ['development', 'production'],
        config: {
          token: 'bcb8f05d6f6fbac46a206227b4ec7'
        }
      }
    ],

The other methods - identify, trackEvent and trackPage seems to be working fine..

Why is that?

Thanks

Support ember under 1.13

Since Ember.LinkComponent is not present in older versions it throws error when trying to use/initialize the addon.

Maybe it should fallback to Ember.LinkView when LinkComponent is not present.

I'm using:
ember: 1.12.0
ember-cli: 0.2.7

Filter adapters on build tree according to environment options

Today all the adapters on metrics-adapters folder are included in the build tree even if on the config there's only one selected, e.g. if on the environment there's only GoogleAnalytics setup Mixpanel and others are included as well on the vendor.js script.
A better approach would be to filter the files on the build process to include only the ones declared on environment + base.js.

This could be done on the treeForAddon hook in the index.js file, excluding from the broccoli tree the adapters that are not on environment, keeping only necessary adapters + base.js. Would be even better if the base.js file was not on the same folder so the filter doesn't have to care about it.

Let me know your thoughts.

throwing error when in development

When I have the config for mixpanel set to only do it in production when I'm in development and come across code that implements identify I'm getting an error in the console saying

Error while processing route: index.index Cannot read property 'identify' of undefined TypeError: Cannot read property 'identify' of undefined

And

TypeError: Cannot read property 'identify' of undefined

Add support for environments to Google Tag Manager adapter

Google Tag Manager has support for different environments. This could be useful for publishing different versions of containers to production vs a staging environment. In order to consume these different containers there are additional query params on the script tag for gtm.js:

• gtm_auth
• gtm_preview
• gtm_cookies_win

I've implemented a local version of the gtm adapter supporting this, and I'd be happy to PR it to the official adapter if there's interest.

alias / identify function formats

Hello,

I'm wondering why is the function call designed, so that I have to call identify and alias and trackEvent in such a non-pretty form, when those function will always take 1 parameter (distinctId as a string)?

It would be much nicer to do:
Ember.get(this, 'metrics').alias(distinct_id); // distinct_id must always be there

instead of
Ember.get(this, 'metrics').alias({ distinctId: distinct_id});

If there's a chance that a hash of options can be passed to a function, it should be the second argument.

The same goes with identify and trackEvent (which always takes at least event name).

Is `activate` the right place to call `trackPage`?

Due to the way Single Page Applications implement routing, you will need to call this on the activate hook of each route to track all page views.

Is activate really the best place to call this? what if I'm moving between pages on the same route (i.e. multiple products). activate only runs the first time the route is entered, and not between model changes.

Should the Docs instead suggest this be be called in a didTransition action?

option `hitCallback` doesn't work for google analytics.

I'm trying to track outbound link navigations, and found that the way to do this with google analytics is to send an event and in the options set a hitCallback key to a function that will be called when the event has been received. This just flat out doesn't seem to work.. here's my component.js:

function exitToMessenger() {
  console.log('redirecting to messenger.com!!')
  window.location.href = 'https://www.messenger.com/t/heyimlea';
}

export default Ember.Component.extend({
  metrics: Ember.inject.service(),
  actions: {
    sendToMessenger() {
      console.log('send to messenger called')
      var metrics = Ember.get(this, 'metrics')

      var eventData = {
        hitType: 'event',
        eventCategory: 'Outbound Link',
        eventAction: 'click',
        eventLabel: 'Sent to messenger!',
        eventValue: 'https://www.messenger.com/t/heyimlea'
      };

      // if (navigator.sendBeacon) {
      //   //https://github.com/googleanalytics/autotrack/blob/bcdd409c22430553a2a43275386877bf37600e68/lib/plugins/outbound-form-tracker.js#L77
      //   //https://developer.mozilla.org/en-US/docs/Web/API/Navigator/sendBeacon
      //   eventData.transport = 'beacon'
      //   metrics.trackEvent(eventData)
      //   //metrics.trackPage({page: '/sent2messenger', title: "exiting to messenger" });
      //   //be sure analytics.js calls sendBeacon before exiting
      //   setTimeout(exitToMessenger, 4)
      // } else {
        eventData.hitCallback = exitToMessenger;
        metrics.trackEvent(eventData)
      // }
    }
  }

Searching something along the lines of 'analytics track outbound link' I find this help article from google analytics suggesting this method: https://support.google.com/analytics/answer/1136920?hl=en
Here's the docs on hitCallback: https://developers.google.com/analytics/devguides/collection/analyticsjs/sending-hits#hitcallback

I'd love to get this fixed and tested asap so that the ember community can have one comprehensive addon for analytics

Finish Mixpanel adapter

Allow us to disable in development

I only want to collect metrics in production.

Currently there is no way to turn them off based on your environment.