adopteitor/adopteitor-api

Backend for adopteitor

adopteitor-api's Issues

Mongo connection failure on test run

Do you think we should maybe tell the app to not try to connect to the DB when only it's running tests via some config option?

Also for error logging like in 404 tests like this:

    404
error: Page not found {"type":"FeathersError","name":"NotFound","code":404,"className":"not-found","data":{"url":"/path/to/nowhere"},"errors":{}}

      ✓ shows a 404 HTML page

Or do we plan to test DB connection? In that case we could dockerize it too 🐳

WDYT @smarbos @josx ?

Breed and Species

Im adding these two services. Both with the same schema:

    displayName: {
      type: String,
      required: true
    },
    default: {
      type: Boolean,
      default: false,
      required: true
    }
``

displayName is the name we will show, for referencing we will use the _id field.
Default will specify wich option will be preselected when creating a new animal.

Contracts endpoint

Description:
Create a Contracts Linking an Animal and a Human.

Parameters:

• humanId (string)
• animalId (string)

Todo:

• I think we can use a BEFORE hook to check if both human and animal exists (and do any more check if we need) and then creating the contract. @anabellaspinelli what do you think?
• Define contract, maybe this should be a variable set by the shelter.

Create Users

Create Users

• Model
• Collection
• Service
• something more?

About Animal Schema

const AnimalSchema = new Schema({
  stage: { / SHouldn't this be autocalculated based on the dateOfBirth?
    type: String,
    required: true
  },
  name: { // Should be displayName?
    type: String,
    required: true
  },
  dateOfBirth: {
    type: Date,
    required: true
  },
  description: { // A description of the animal.
    type: String,
    required: true
  },
  sex: {
    type: String,
    required: true
  },
  location: { // A string describing where in the world the animal is located
    type: String,
    required: false
  },
  entryDate: {
    type: Date,
    required: true
  }
  state: { // Adopted, in adoption, other?
    type: String,
    required: true
  }
});

• I added a state field to indicate if the animal is in adoption, adopted or any other condition.
• I wondered if the stage field should automatic generated based on the dateOfBirth and a "threshold setting" for the "stages"?
• Also, how can we handle different species? Maybe a shelter could have dogs and cats, and show them separately? I think this could be a common scenario.
• I added location field because right now in Adopta un Galgo en Argentina, we have Galguitos in Buenos Aires and Rosario City.

Breed and Species behaviour

We must implement a before hook to check if there's another "default" selected, and deselect it before selecting the new one.

• Add a restriction so that only one can be default.
• On Updates too, if another breed/specie is selected as default, the previous default should be changed to false.

Add production docker-compose.yml

Add a new version of docker-compose.yml that does not mount volumes and just runs it.

Add Photos to animals.

Animal schema have a photos property, that will contain the path to the uploaded images.
https://github.com/feathersjs/docs/blob/master/guides/advanced/file-uploading.md

The path for this could be something like POST animals/:id/photos
The image should be in the payload, and we need the handler on this route, to save the image in the server and push the path to the corresponding animal photo's array.

Authentication

We need to authenticate requests and both:

• Look up for options. [Check this link]
• Create Users collection, service and more [ #10 ]
• Only users with a Token provided by the adopteitor-client can make requests to the server.
• Only loged in users with admin privileges can edit the resources.

https://docs.feathersjs.com/api/authentication/server.html