adrianskierniewski/eloquent-tree

Eloquent Tree is a tree model for Laravel Eloquent ORM.

eloquent-tree's Issues

My own table name

How can I modify the migration and choose another table name?

How to listen for and respond to fired events like updatedParent

Does anyone have a snippet to share showing how to listen and respond to a TreeEvents like updatedParent?

Thank you. :)

Laravel 5 Support

Is there any plan to upgrade to Laravel 5 ?

setChildOf on newly created Tree

Hello,

We're using eloquent-tree to handle hierarchy between users. We spoted some performance issue when registering a new user and could track it down to setChildOf().

The problem is that when we want to assign a user newly created to as a child of the currently logged user, path and level are not filled yet. findDescendants() requests all users WHERE path LIKE '<null>%' which returns the whole users table!

I don't know if we're using the package properly, for this purpose, but in any case, I would expect a note in the documentation or something preventing to return the whole table.

What do you think ?

Thanks

Laravel 5

Do you have plans to support Laravel 5?

Can setAsRoot() be called automatically if parent_id is null ?

Hello,

When you modify a record by setting parent_id = null, the path and level values are not updated. Then if you want to call setAsRoot(), it doesn't work because the parent_id value is already null.
Isn't it possible to automatically call setAsRoot() if parent_id is null?

If this is not possible, simply modify the isRoot() function like this to allow setAsRoot() to start even if parent_id is null:

public function isRoot()
{
        // return (empty($this->{$this->getTreeColumn('parent')})) ? true : false;

        return $this->{$this->getTreeColumn('path')} === $this->getKey() . '/'
                && $this->{$this->getTreeColumn('level')} === 0;
}

getRoots() error

Need to add get() onto end of whereNull

/**
     * Gets all root nodes
     *
     * @return \Illuminate\Database\Eloquent\Builder
     */
    public static function getRoots()
    {
        return static::whereNull(static::getTreeColumn('parent'))->get();
    }

Bug Tree::renderRecursiveTree()

In version 2.1 of eloquent-tree in Tree.php, line 511, you have $child->children instead of $child->children(), which in turn is causing Tree:render() to fail to render sub-levels beyodn the first sub-level.

Changing the line to children() appears to fix this issue.

Presenter

Whenever I try to pass presenter class to buildTree method, I get few errors (issues):

• Presenter has to be a class of "Tree", while I'm building one separated (that's the idea of presenters, heh). I suggest to remove "Tree" requirement from "_addChildToCollection" method:

// remove "Tree" declaration here
protected function _addChildToCollection(Tree &$child) {
// to something
protected function _addChildToCollection(&$child) {

• Also, root elemend doesn't get presenter applied. Probably buildTree method needs patching, something like (or even better - move representation of element to separate method, so it can be applied to $node and $root):

if ( isset($root) )
{
    return isset($presenter) && class_exists($presenter) ? new $presenter($root) : $root;
}
else
{
    return FALSE;
}

Setting multiple nodes as childs at once?

Is there a way to talk to the database once, instead of using setChildOf() within a loop?

$child_1 = factory(User::class)->states('active')->create();
    $child_1_1 = factory(User::class)->states('active')->create()->setChildOf($child_1);
        $child_1_1_1 = factory(User::class)->states('active')->create()->setChildOf($child_1_1);
        $child_1_1_2 = factory(User::class)->states('active')->create()->setChildOf($child_1_1);
        $child_1_1_3 = factory(User::class)->states('active')->create()->setChildOf($child_1_1);
        $child_1_1_4 = factory(User::class)->create()->setChildOf($child_1_1);

$child_1_1->cap();

public function cap()
{
    $actives = $this->children()
                ->whereActive(true)
                ->limit(2)
                ->get();

    $actives->each(function($active) {
        $active->setChildOf($this->parent);
    });
}