adriennejohnson/fairshare

fairshare's Issues

A shareholder can be added without a specified role

Choosing a role isn't required in the FE validation or in the post endpoint

No way of signing out

Add a button that allows the user to sign out

FE validation of form inputs

Add better FE validation on user inputs during onboarding and on the dashboard
-User email and company name should be required to proceed to next step
-Shareholder name should be required
-Check for negative numbers or other weird cases we wouldn't want?

Pie chart shows opposite data than expected

Viewing the data By Group showed the By Investor breakdown, and vice versa.

No way to sign up as a new user without creating a company

The onboarding flow doesn't check if the user is associated with an existing company or an existing shareholder, so they are taken through the onboarding flow for a new company in order to sign up and log in.

A new user signing up should also be associated with a shareholder (if one with the same email already exists).

Accessibility

Axe dev tools raises some issues that could be audited

Input for entering number of shares during onboarding only allows one digit

During onboarding flow, when the user clicks to add a grant, it's not possible to type in number of shares great than one digit.

Backend validations?

Another thing that I’m not sure is an area of improvement or just expected from the setup, so just in case: more error handling and data validation in the endpoints

Navigating to the shareholder page with an ID that doesn’t exist

Visiting /shareholder/[anything not a shareholder id] breaks the page

Incomplete: Show value metric on chart

The chart is viewable by number of share and metric, but I was short on time so the tests on the calculation itself are very minimal and non-existent for the user interactions (i.e., not sure how reliable the feature is currently).

To do:
-Update function calculateShareTotals because it might be redundant to some extent now that calculateChartData is returning both metrics
-Tests for user interaction, chart updates, and a greater variety of grant/shareholder data

Incomplete: Edit share value

To do:

-Add icon button to next to each share value on Dashboard.
-Icon button will toggle a modal with a form to enter a new share value.
-When the form is submitted, trigger a mutation to update the current value of the share
-Ensure that calculations and displayed data update if the mutation is successful

An update endpoint is added but not in use yet.

I thought it could be nice if the app kept track of the starting share value, instead of just overwriting it, so I updated the fields on Share to include startValue and currrentValue.

UX: Closing modals

Modals don't have a close/cancel button

UX: Pie chart layout

The empty state or near-empty state (i.e., only one shareholder) of the pie chart is a little wonky.
-Values that don’t exist yet still appear as labels
-Some labels overlap

And in general:
Labels on pie chart get cut off.

Unnecessary error message flash

An error message flashes briefly when navigating to the dashboard page.

UX: Navigating from the shareholder page

Add a nav or a link back to the dashboard on the individual shareholder page.

Ability for more than one company to exist?

Not sure if this is a bug or just an intended side effect of the contrived/simplified setup, but creating a new company overrides the old one and there’s no way to associate shareholders with different, specific companies.

Loop during onboarding flow and loss of data

If other shareholders are added during onboarding, the user gets redirected back to the starting point once they try to advance to the shareholder grants step. The data they had entered is lost.