aduis/hapi-rabbit

rabbitMQ hapijs plugin

hapi-rabbit's Issues

Should not JSON.parse(message) actually be JSON.stringify(message)?

Nice work! But ran into an error when subscribed data is received from RabbitMQ. I got if fixed by changing JSON.parse(message) to JSON.parse(message)

hapi-rabbit/lib/index.js

                    sub.on('data', function (message) {

                        // callback(null, JSON.parse(message)); -> throw an error
                        callback(null, JSON.stringify(message));

                    });

Question: Plugin vs Native Rabbit

This may be a dumb question but I'm not sure I understand what you get by making this a plugin versus just using a native RabbitMQ module? I'd really appreciate it if someone can explain this to me.

Thanks

Is this compatible with hapi 8?

plugin.events.once('start', function () {
...

TypeError: Cannot read property 'once' of undefined

Hapi v17 Support

Overview

If you are not aware yet, Hapi v17 is making the transition from callbacks to async/await, as well as deprecating some other rarely used functionality. This is a breaking change that may make your plugin no longer compatible with the Hapi API.

Changelog

Draft release notes can be found here: hapijs/hapi#3658

Target Release

The target release date for v17 is the beginning of November.

Tasks

• Reply to this to acknowledge that you are actively maintaining this module and are willing to update it
• Update plugin to be fully async/await compatible using the v17 branch from Hapi for testing

  Possible dev flow for updating

  • Clone Hapi
  • npm link within the Hapi repo
  • npm link hapi within your plugin repo
  • Your plugin will now be using v17 of Hapi branch for tests
• Release new major version of your plugin on npm. Please use a major version increment as this will be a breaking change and it would be terrible for it to sneak into current versions of Hapi.

Notes

• Support is being dropped for all versions of Node <8.0.0.
• Hapi v16 will continue to be supported for as long as there exists a Node LTS actively being supported that is not compatible with v17.
• Targeted release date is November 1st, 2017. Please try to have your plugin updated before then.

ValidationError: messageType must only contain alpha-numeric characters

messageType in rabbit.publish function should allow special characters like ".", "*", "#" in order to respect rabbit topic routing_key format . RabbitMq Topic.

Your plugin instead allow only alphanumeric characters.