internal properties

[npolyak]

internal properties

[aelij]

It's already supported, as properties (and events) are included in the Methods property in Cecil (unlike Reflection).

[npolyak]

Well, seems like it is not - I was trying to expose some properties on Avalonia DataGrid e.g. DataGrid.SlotCount (for read only) and it was not exposed without my modifications

    internal int SlotCount
    {
        get;
        private set;
    }

Neither many others - e.g. VisibleSlotCount or RowGroupHeadersTable or HorizontalScrollBar:

    internal IndexToValueTable<DataGridRowGroupInfo> RowGroupHeadersTable
    {
        get;
        private set;
    }

   internal ScrollBar HorizontalScrollBar => _hScrollBar;

[npolyak]

I modified your project to add some functionality that I need and created a new repo while giving you the proper attribution. Please, take a look at DotNetBinaryAdjuster

[weltkante]

It sounds like your fork is permanently patching assemblies, not just providing access to internals at compiletime while still running the original assembly at runtime?

[npolyak]

It sounds like your fork is permanently patching assemblies, not just providing access to internals at compiletime while still running the original assembly at runtime?

To tell you the truth, I am not sure. It works for me and I thought I followed everything from IgnoresAccessChecksToGenerator. If you think I did something wrong, please, be specific - it could have easily happened since I do not know much about mono.cecil.

Thanks

[npolyak]

It sounds like your fork is permanently patching assemblies, not just providing access to internals at compiletime while still running the original assembly at runtime?

I just realized - my attempt at virtualization did not work - the old method is still being called. I guess it is not as good as I hoped it would be.

[weltkante]

I just realized - my attempt at virtualization did not work

Ye that was what I meant, things like that require permanent patching, since it affects runtime and not compile time.

Generally, turning private to public may not always work either, I've run into a lot of problems doing that on framework assemblies and given up on it eventually.

[npolyak]

I just realized - my attempt at virtualization did not work

Ye that was what I meant, things like that require permanent patching, since it affects runtime and not compile time.

Any ideas or links on how to patch it permanently - e.g. create another dll and use it instead of the original one?

[weltkante]

I just realized - my attempt at virtualization did not work

Ye that was what I meant, things like that require permanent patching, since it affects runtime and not compile time.

Any ideas or links on how to patch it permanently - e.g. create another dll and use it instead of the original one?

Well, you just do the same, use Mono.Cecil during build time to rewrite the assembly, but not just for the compiler input. Frameworks doing that exist but I never used them, check maybe https://stackoverflow.com/questions/189359/what-is-il-weaving for ideas on where to look.

Alternatively do it outside the buildchain and just do the occasional manual processing tool run to generate your modified version whenever your dependencies need to be updated. Can easily write a console tool to rewrite assemblies with Mono.Cecil.

Obviously need to check if licenses allow to distribute modified versions of third party code.

[npolyak]

Thanks man, I work with Avalonia - which is open source under MIT license, so I do not expect any copyright problems
Eventually in order to avoid the weaving somersaults and jumping jacks, Avalonia will have to make its code a bit easier to modify it without resorting to extreme measures or completely re-writing its packages. I'll probably give them some ideas after being done with this exercise.

[npolyak]

@weltkante , sorry, as I mentioned before I am pretty new to Cecil. It seems like the modified assembly is saved by the call to

assembly.Write(target);

But even if I use that saved assembly, it is not performing the override. What am I doing wrong? Perhaps you can recommend some websites where cecil is explained?

[weltkante]

That should work, if it doesn't something went wrong with your modifications. Can't really recommend any guides since I just learned it by trial & error myself and reading code like this repo. What I'm usually doing is writing a console app that loads the assembly, modifies it, and writes it back under a different name - then use ilspy to verify my edits. If I need a reference to how something needs to look at the IL level I write a dummy c# project just doing the one thing I need to know how it looks and open the assembly in ILSpy, then replicate it in Mono.Cecil. Thats relly all there is to it as far as I'm concerned.

[npolyak]

Thanks @weltkante !