Giter Site home page Giter Site logo

Comments (4)

zhuoqinyue avatar zhuoqinyue commented on August 18, 2024

你好, 我想提问, 如果有人对我的PR修改了, 然后我应用了他的修改并且commit了, 那最后的push动作由谁来执行呢?

from blog.

aermin avatar aermin commented on August 18, 2024

你好, 我想提问, 如果有人对我的PR修改了, 然后我应用了他的修改并且commit了, 那最后的push动作由谁来执行呢?

由他把他所修改的commit push到你的分支

from blog.

zhuoqinyue avatar zhuoqinyue commented on August 18, 2024

感谢, 但是最后发生的情况并不是这样的. 我复述一下吧.

我提了个PR, 然后审核者给出了修改代码, 我直接应用, 并且在PR的界面里直接commit.
后面发现, 这段代码是合并到我的这次commit里面, 只要审核者merge, 就有最新的修改代码了.

from blog.

aermin avatar aermin commented on August 18, 2024

感谢, 但是最后发生的情况并不是这样的. 我复述一下吧.

我提了个PR, 然后审核者给出了修改代码, 我直接应用, 并且在PR的界面里直接commit. 后面发现, 这段代码是合并到我的这次commit里面, 只要审核者merge, 就有最新的修改代码了.

没听懂你说的😂修改的commit是他的吧，然后push到你的pr，然后你的pr最后应该会被squash merge

from blog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.