Giter Site home page Giter Site logo

2.0b Unnecessary shader instances about minko HOT 2 CLOSED

aerys avatar aerys commented on July 19, 2024
2.0b Unnecessary shader instances

from minko.

Comments (2)

osmetanin avatar osmetanin commented on July 19, 2024

Sorry, that's my mistake. As I've figured out, duplicate shader instances we created because I instantiated new Effect each time I created a Mesh. Closing the issue

from minko.

JMLX42 avatar JMLX42 commented on July 19, 2024

That's amazing to see people digging that deep in the code :)

A nice patch would be to be able to share the signature-instance map so this problem
does not occur. That's something we might patch. But for now we just though that creating the same
shader object over and over was something people shouldn't do.

Saddly, this is a situation we can't ignore. Sometimes, it's really to much of a constraint.

This pathc could be to make the signature-to-instances map a static variable.
But I think we have to do something like a (shader) Class to signature-to-instances static Dictionnary.

That should do the trick... if you have the time to do this patch we will gladely merge it :p

Thanks for your feedback and all your good work!

from minko.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.