Matrix4x4.toString() called in CameraController.localToWorldChangedHandler event chain

[aerys]

Matrix4x4.toString() called in CameraController.localToWorldChangedHandler event chain

[JMLX42]

Hello and thank you for your report.

Matrix4x4.toString can be called implicitly when uaing the Matrix4x4 object
as a key in an Object I guess.

But I don't understand how the latest commits could have an impact on this.
Plus if it is sone in the CameraController it's likely to be done just once
per frame max which should not affect performances at all...

Still, it should not happen indeed.

[JMLX42]

After reading the call stack you posted, the problem is in a closure
function. You can see this because it is called anonymous.

I'm pretty sure there isn't a single closure in minko so this must be in
your own code.

Please confirm by closing this issue. Then if you need further help on
this, please post on Answers:

http://answers.aerys.in

[stevewoolcock]

Hmm, I'm pretty sure it's not my code. The only thing I changed in the code base was to pull the latest version of /dev, then update my Effect classes to work with the new API. I never access Matrix4x4.toString() in any of my code. I should note that this problem still occurs even if I use the built in effects (PhongEffect, etc) and none of my own.

Edit
The following example should illustrate that the problem lies within the Minko core. It creates 400 boxes, which will append a rotation each frame. If you check the function call list in Scout, you'll see the call to Matrix4x4.toString() is still there. The anonymous/closure Function call appears to come from within the internals of Flash Player.

package
{
    import aerys.minko.render.Effect;
    import aerys.minko.render.geometry.primitive.CubeGeometry;
    import aerys.minko.render.material.basic.BasicMaterial;
    import aerys.minko.render.Viewport;
    import aerys.minko.scene.controller.camera.ArcBallController;
    import aerys.minko.scene.node.camera.Camera;
    import aerys.minko.scene.node.Mesh;
    import aerys.minko.scene.node.Scene;
    import aerys.minko.type.math.Matrix4x4;
    import aerys.minko.type.math.Vector4;
    import flash.display.Sprite;
    import flash.events.Event;

    public class Main extends Sprite 
    {
        private var scene:Scene;
        private var camera:Camera;
        private var viewport:Viewport;
        private var boxes:Array;

        public function Main():void 
        {
            viewport = new Viewport();
            addChild(viewport);

            camera = new Camera();
            camera.transform.translationZ = -10;

            var control:ArcBallController = new ArcBallController();
            control.bindDefaultControls(stage);
            camera.addController(control);

            scene = new Scene();
            scene.addChild(camera);

            boxes = [];
            for (var i:int = 0; i < 400; ++i)
            {
                var box:Mesh = new Mesh(CubeGeometry.cubeGeometry, new BasicMaterial( { diffuseColor: 0x222222FF } ));
                scene.addChild(box);
                boxes[i] = box;
            }

            stage.addEventListener(Event.ENTER_FRAME, update);
        }

        private function update(e:Event):void
        {
            for (var i:int = 0; i < boxes.length; ++i)
            {
                var box:Mesh = Mesh(boxes[i]);
                box.transform.appendRotation(0.01, Vector4.Y_AXIS);
            }

            scene.render(viewport);
        }
    }
}

[JMLX42]

The anonymous/closure Function call appears to come from within the internals of Flash Player.

That would indicate that the toString() method is indeed called because the Matrix4x4 is used as a key in an Object.

[stevewoolcock]

That would make sense, although this wasn't happening before the commit I listed above, so something must have changed.

Edit
I see 8df8c10 has fixed this issue. Keep up the good work guys!