aevitas/bluerain

BlueRain is a fully-featured, managed memory manipulation library written in C#

bluerain's Issues

`ExternalProcessMemory` throws `NullReferenceException` when `createInjector = true`

MCVE:

    internal class Program
    {
        private static void Main(string[] args)
        {
            var dllPath = @"C:\mydll.dll";
            var process = Process.GetProcessesByName("csgo").Single();
            var memory = new ExternalProcessMemory(process, true);
            var module = memory.Injector.Inject(dllPath);
        }
    }

The ExternalProcessMemory constructor throws a NullReferenceException when being called with createInjector = true. This is due to the constructor in question calling its base constructor (in which the Injector gets instantiated) before the ProcessHandle gets instantiated, which is required for injection.

See https://github.com/aevitas/bluerain/blob/v2/src/BlueRain/ExternalProcessMemory.cs#L36

My suggestion is to move
ProcessHandle = OpenProcess(access, false, process.Id);
up into its base constructor with sane ProcessAccess defaults.

Any thoughts?

Optimize Read<T> to avoid marshalling of primitive types

Currently, the implementation of ExternalProcessMemory simply calls ReadBytes to read the length of type T from memory, and then feeds it to the marshal. Since marshalling is relatively expensive (read: very expensive), we should consider directly dereferencing the buffer ptr, and avoid the marshal entirely.

about marshalling

hi, i tested a method inspirated by yours like 👍

Marshal.SizeOf(typeof(T)); to get the buffer size in generic Read method... i got it work with an integer

is that a correct way to doit?

IsExternal/isLocalProcessMemory mismatch in Injector.Dispose

Mismatch in method call and method definition:

public bool Free(bool isLocalProcessMemory)
vs
if (!InjectedModule.Value.Free(Injector.IsExternal))

There's no public API for setting Injector._ejectOnDispose

As the Injector constructor is internal, theres just ExternalProcessMemory.ctor to instantiate an Injector. However, there's no way to set _ejectOnDispose if you want the injected modules to get free'd.

Ideas:

• Expose _ejectOnDispose as a public get/set property
  • as long as there aren't too many options to pass, this might be a simple and clean solution
• Add InjectorInitializationParameters to the ExternalProcessMemory.ctor
  • This can also bundle createInjector, which seems like a clean approach
• Pass it as an optional argument to ExternalProcessMemory.ctor
  • this may clutter the API as well as being a breaking change

Implement pattern scanner