affirm/affirm-ios-sdk

:no_entry: [DEPRECATED] Active at

affirm-ios-sdk's Issues

Logout current user

In our app the user is able to logout. We couldn't find a way to also logout current user from the Affirm SDK, so when the new user tries an Affirm payment, the old user credentials are still present.

Terms of Service Link don't present on top of current Affirm View Controller

We are showing the Affirm View on a Modal dialog. If the user click the Affirms Terms of Service Link, the page will open on the root tab controller inside of being displayed on top of the current view.

Unable to cancel checkout twice

There seems to be an issue with trying to cancel out the affirm checkout controller twice.
Step to reproduce.

1. Clone the example project https://github.com/Affirm/affirm-ios-sdk-demo
2. Select "Buy with Affirm" -> this will present the affirm web view
3. Tap the close icon on the left side and click "ok" on the pop up -> this will close the controller
4. BUG: Repeat steps 2 and 3 and you will notice that the affirm web view will not call the delegate

I was able to reproduce this on xcode 8, ios 9 - 10

Unexpected CFBundleExecutable key

This issue has already been fixed in commit ecba6cc, however a new release that includes this change has not been created yet.

Would you be able to create a new release including this change?

WKWebView appearance issue while presenting modal

We are using Affirm SDK in our Wayfair iOS app. In recent version we're seeing unintended behavior while trying to present AffirmBaseModalViewController from the app. The issue occurs where base web view (WKWebView) is positioned awkwardly in the scene. (Attaching screenshots for reference)

We started experiencing this problem when Affirm SDK upgraded its web view from basic UIWebView to WKWebView. As per our observation, Affirm payment modal was presented properly before SDK received this update.

We tried to debug this bug on our end as much as possible with no luck. This bug appears on both simulator and actual iOS device. It is bit more confusing, since AffirmBaseModalViewController shows the correct behavior on the demo app that is provided along with library. Have any of your other users experienced similar problem? Let us know if you need any other information from our end that can make debugging easier for you.

App preview

View Debugger output

Crash on production env, promotional button

Hello, I setup Promotional button, for sandbox everything good, but for Production key and Env I have crash in SDK on this line: http://prntscr.com/nibcdi .

Logs:

*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[0]' *** First throw call stack: ( 0 CoreFoundation 0x000000011325d1bb __exceptionPreprocess + 331 1 libobjc.A.dylib 0x00000001127fb735 objc_exception_throw + 48 2 CoreFoundation 0x00000001131a94ec _CFThrowFormattedException + 194 3 CoreFoundation 0x00000001132cc541 -[__NSPlaceholderDictionary initWithObjects:forKeys:count:] + 321 4 CoreFoundation 0x0000000113258c9b +[NSDictionary dictionaryWithObjects:forKeys:count:] + 59 5 AffirmSDK 0x000000010af62a12 -[AffirmErrorResponse dictionary] + 296 6 AffirmSDK 0x000000010af60878 __86-[AffirmPromotionalButton configureWithAmount:affirmLogoType:affirmColor:maxFontSize:]_block_invoke + 794 7 AffirmSDK 0x000000010af5a427 __59+[__protocolContainer_AffirmClientProtocol_2 send:handler:]_block_invoke_2 + 295 8 libdispatch.dylib 0x000000011443d595 _dispatch_call_block_and_release + 12 9 libdispatch.dylib 0x000000011443e602 _dispatch_client_callout + 8 10 libdispatch.dylib 0x000000011444b99a _dispatch_main_queue_callback_4CF + 1541 11 CoreFoundation 0x00000001131c23e9 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 9 12 CoreFoundation 0x00000001131bca76 __CFRunLoopRun + 2342 13 CoreFoundation 0x00000001131bbe11 CFRunLoopRunSpecific + 625 14 GraphicsServices 0x0000000116c4d1dd GSEventRunModal + 62 15 UIKitCore 0x000000011a2c581d UIApplicationMain + 140 16 Shiekh Shoes Beta 0x00000001092d5037 main + 71 17 libdyld.dylib 0x00000001144b4575 start + 1 ) libc++abi.dylib: terminating with uncaught exception of type NSException

AppStore upload error issue on latest pod AffirmSDK v 2.2.0

Using Xcode 7.3.1

I am getting an upload error after I updated Affirm from v 2.1.1 to 2.2.0. I was able to rebuild on 2.1.1, so I'm pretty sure it has to do with 2.2.0

Here's the error:
ERROR ITMS-90535: "Unexpected CFBundleExecutable Key. The bundle at 'Payload/MYAPPName.app/AffirmSDK.bundle' does not contain a bundle executable. If this bundle intentionally does not contain an executable, consider removing the CFBundleExecutable key from its Info.plist and using a CFBundlePackageType of BNDL. If this bundle is part of a third-party framework, consider contacting the developer of the framework for an update to address this issue." ERROR ITMS-90535: "Unexpected CFBundleExecutable Key. The bundle at 'Payload/MYAPPName.app/AffirmSDK.bundle' does not contain a bundle executable. If this bundle intentionally does not contain an executable, consider removing the CFBundleExecutable key from its Info.plist and using a CFBundlePackageType of BNDL. If this bundle is part of a third-party framework, consider contacting the developer of the framework for an update to address this issue."

Any ideas on why this is happening?

AffirmSDK/AffirmCreditCard.h file not found

Version 4.0.16 appears to have introduced a bug where the compiler complains with the following message:

'AffirmSDK/AffirmCreditCard.h file not found'

Using:
Carthage v0.32.0
Swift 4.2
Xcode 10.1 (10B61)