agave-dao/agave-frontend

agave-frontend's Issues

Add Reserve Factor to Reserve Overview Page

See image

On Main Deposit Page wxDai balance is shown instead of xDai

On the main deposit page under balances, what I see next to my xDai balance is actually the wxDai in my wallet that I wrapped a few days ago. It shows the wxDai balance correctly as follows.

Also, on reserve overview page, the same issue above repeats as it can be seen on the left side of the following screen:

However, after clicking xDai on that main deposit screen, I see the amount of xDai and not wxDai balance, which I assume is how it should have shown on the first screen as well.

Relevant Forum Link: https://forum.1hive.org/t/feedback-on-agave-platform/4297/6

It should be showing xDai on the main deposit page as well is what I guess.

if the account has sufficient allowance show them directly step2 (deposit) after they enter the amount.

Move the allowance check directly when the view is loaded rather than when the approve button is clicked

Get balance res undefined

Path: src/utils/contracts/getBalance.js

Sometimes res is undefined and it crashes the whole app

return new Promise((resolve, reject) => {
            contractInstance.methods.balanceOf(address).call({ from: address }, (err, res) => {
                if (err) reject(err);
                let balance = parseInt(web3.utils.fromWei(res, 'ether')).toFixed(4);
                resolve(balance)
            });
        })

Add a check for this undefined? Maybe a try catch?

return new Promise((resolve, reject) => { 
            contractInstance.methods.balanceOf(address).call({ from: address }, (err, res) => {
                if (err) reject(err);
                if(!res === undefined) {
                    let balance = parseInt(web3.utils.fromWei(res, 'ether')).toFixed(4);
                    resolve(balance)
                }
            });
        })

Favicon not showing up on some web3 browsers

Repro'd on Coinbase Wallet. Can someone repro on any other mobile web3 browsers?

Comparing this to Gardens UI using a favicon checker, a fix may be to include a favicon.ico in the code base.

Agave

https://realfavicongenerator.net/favicon_checker?protocol=http&site=agave.finance

Gardens

https://realfavicongenerator.net/favicon_checker?protocol=https&site=gardens.1hive.org%2F

-Keppa