agentejo/2fa

2FA addon for Cockpit CMS

2fa's Issues

accounts/account page unresponsive after adding the 2FA addon using nginx without docker

Hey!

Would like to flash back to an issue that was raised on the main cockpit repo: Cockpit Issue - 2FA authentication question

Context:
Using ubuntu 20.04
I use a direct installation (so no docker) - cockpit-next and cockpit-master result in the same situation.
Using nginx as the webserver.
Simply adding the 2FA folder to the cockpit/addons folder by following the instructions here

Result:
500 code in the console, no errors in the error log, only a single row with response 500 in. the access log.
And the page looks like
this, same picture as the former issue

Curious to hear if you have any tips on debugging this issue!
Would be great to have resolved.

Not compatible with PHP 8

The login works fine but when I try to open the account page of a user (e. g. /accounts/account/5e8c4a1f30656581770002f3). The following error can be found in the log:

[Sun Apr 17 23:22:58.845694 2022] [php:error] [pid 178415] [client 144.2.110.170:5461] PHP Fatal error:  DASPRiD\\Enum\\AbstractEnum::__sleep(): Return type must be array when declared in 
/var/www/cockpit/addons/2FA/lib/DASPRiD/Enum/AbstractEnum.php on line 217, referer: ...

Additionally there are a few warnings
PHP Warning: Private methods cannot be final as they are never overridden by other classes

I think this is because of PHP 8