Comments (5)
Currently, the plugin does not close the dialog when the confirmation button is pressed — this was by design, for what I felt was the more common case of these dialogs triggering full page refreshes as opposed to Ajax or front-end MVC updates (the idea being that leaving the dialog up while the new page loads prevents any other actions from being taken in the mean time if the response is not immediate).
I will see about adding a configuration option for this behavior, probably something along the lines of close_after_ok
or the like, for cases where people want to use this to confirm actions that don't entail a page refresh.
from confirm-with-reveal.
Cheers, I can live with that. However it it was to close by default, the people using it to link to other pages would not have any downside either?
from confirm-with-reveal.
The only downside to closing the dialog by default when the OK button is hit is that if the dialog is confirming (for example) deletion of a resource, or some other important action, and the server response takes more than a few tenths of a second to refresh the page in the user's browser, the user may mistakenly think that the action was carried out via Ajax, and navigate off the page before the response arrives.
I recognize the value of having a close_after_ok
option and will look into adding that, but I think the safer or more conservative setting is to have that behavior as a configuration option that must be explicitly chosen by the developer using the plugin.
from confirm-with-reveal.
Fixed with this in code on 49 line, before:
if ($el.is('form, :input')) {
return $el.closest('form').removeAttr('data-confirm').submit();
}
After:
if ($el.is('form, :input')) {
modal.foundation('reveal', 'close');
return $el.closest('form').removeAttr('data-confirm').submit();
}
from confirm-with-reveal.
I agree closing the modal when clicking confirm should become the deafult. (Nowadays most apps are SPA i.e. there's no full page reload after clicking confirm.)
However IMHO modal.foundation('reveal', 'close');
should be one line above (outside of the if clause).
from confirm-with-reveal.
Related Issues (18)
- Do not work with "build/confirm_with_reveal.js"... HOT 3
- Demo page and/or docs outdated HOT 3
- OK Button Does Nothing. HOT 3
- [Question] Return different confirms from one page HOT 1
- Return a POST variable on confirm HOT 1
- Did you just Rick-roll me? HOT 2
- No longer works with Foundation 6 HOT 1
- Password prompting twice in Foundation 6 HOT 1
- make jQuery plugin compatible with jQuery.noConflict(); HOT 2
- Using a json object in data-confirm still gives vanilla danger
- "Enter" key does not confirm dialog
- calling confirmWithReveal breaks top menu and dropdown buttons in F5.5.3
- Bower package? HOT 4
- Foundation 5 support HOT 7
- Bower version mismatch HOT 1
- Execute JS on confirm HOT 4
- Rails’ UJS adapter causes confirm loop HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from confirm-with-reveal.