Giter Site home page Giter Site logo

Comments (7)

jletourneau avatar jletourneau commented on August 17, 2024

Have not attempted to integrate this with Foundation 5 yet. I'll take a look at it.

from confirm-with-reveal.

marclennox avatar marclennox commented on August 17, 2024

Cool. I'm getting a javascript error within Foundation's reveal.js file because the modal window is missing the data-reveal-init attribute. I tried hacking a bit but couldn't get it working... I'll try again later when I have some time.

from confirm-with-reveal.

jletourneau avatar jletourneau commented on August 17, 2024

@marclennox That code change should take care of it. I've updated the demo page to use the latest version of Foundation (5.1.1) and the confirmation modals look to be working properly.

from confirm-with-reveal.

marclennox avatar marclennox commented on August 17, 2024

@jletourneau just tested it, works great! Thanks very much!

from confirm-with-reveal.

Fraugher avatar Fraugher commented on August 17, 2024

Have set this up with Foundation 5, easy setup thank you, and seeing the nice modal appear no problem. Trouble here is the modal reappears continually on selecting the affirmative/yes button, caught in an infinite confirm (deletion) loop... submittal is for a delete link which triggers a confirm automatically.

from confirm-with-reveal.

jletourneau avatar jletourneau commented on August 17, 2024

@Fraugher Can you post a test case for this problem somewhere public? The plugin strips the data-confirm property off the confirmation button it puts in the modal, so clicking "OK" in the modal should not trigger another confirmation. I think I'd need to see the problem reproduced in order to debug what you're describing.

If you can provide a reproducible test case, it would be great if you would open a new issue on this repo and attach the link there. Thanks!

from confirm-with-reveal.

Fraugher avatar Fraugher commented on August 17, 2024

My suspicion is it has to do with the Rails handler, which appears to throw a confirmation dialogue of its own accord for :delete links whether it is developer-specified or not. (Apparently not a Foundation 5 issue).

from confirm-with-reveal.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.