agorava/agorava-facebook

Agorava module to connect to Facebook

agorava-facebook's Issues

Clean Exception names in JavaDoc

JavaDoc refers to non-existing Exception classes like. This should be cleaned up. Either replacing it with AgoravaException or rephrasing/reducing the exceptions to those actually thrown by each method call.

see https://issues.jboss.org/browse/AGOVA-51

java.lang.IllegalArgumentException: Must provide a valid url as callback. Facebook does not support OOB

Could not make Agorava work for Facebook Module VERSION 6.0.
I guess the code is fine. I can't tell if that's a configuration issue from my side!
I get the following exception informing that there is no valid Callback url and that Facebook service does not support OOB:

(The controller bean can be read here: https://github.com/hanynowsky/honeybee/blob/master/src/main/java/org/otika/honeybee/util/SocialServiceBean.java)

Could you please tell what is wrong!

---

18:30:54,069 INFO org.otika.honeybee.util.SocialServiceBean Initiating new session for Facebook
18:30:54,596 ERROR org.apache.catalina.core.ContainerBase.[jboss.web].[default-host].[/honeybee].[Faces Servlet] Servlet.service() for servlet Faces Servlet threw exception: java.lang.IllegalArgumentException: Must provide a valid url as callback. Facebook does not support OOB
at org.scribe.utils.Preconditions.check(Preconditions.java:82) [scribe-1.3.3.jar:]
at org.scribe.utils.Preconditions.checkValidUrl(Preconditions.java:54) [scribe-1.3.3.jar:]
at org.scribe.builder.api.FacebookApi.getAuthorizationUrl(FacebookApi.java:21) [scribe-1.3.3.jar:]
at org.scribe.oauth.OAuth20ServiceImpl.getAuthorizationUrl(OAuth20ServiceImpl.java:69) [scribe-1.3.3.jar:]
at org.agorava.core.oauth.scribe.OAuthProviderScribe.getAuthorizationUrl(OAuthProviderScribe.java:86) [agorava-core-impl-0.6.1.jar:]
at org.agorava.core.oauth.scribe.OAuthProviderScribe$Proxy$_$$WeldClientProxy.getAuthorizationUrl(OAuthProviderScribe$Proxy$$$WeldClientProxy.java) [agorava-core-impl-0.6.1.jar:]
at org.agorava.core.cdi.OAuthServiceImpl.getAuthorizationUrl(OAuthServiceImpl.java:94) [agorava-core-impl-cdi-0.6.1.jar:]
at org.agorava.core.cdi.OAuthServiceImpl$Proxy$$$WeldClientProxy.getAuthorizationUrl(OAuthServiceImpl$Proxy$$$WeldClientProxy.java) [agorava-core-impl-cdi-0.6.1.jar:]
at org.agorava.core.cdi.MultiSessionManagerImpl.initNewSession(MultiSessionManagerImpl.java:108) [agorava-core-impl-cdi-0.6.1.jar:]
at org.agorava.core.cdi.MultiSessionManagerImpl$Proxy$$$WeldClientProxy.initNewSession(MultiSessionManagerImpl$Proxy$$$WeldClientProxy.java) [agorava-core-impl-cdi-0.6.1.jar:]
at org.otika.honeybee.util.SocialServiceBean.serviceInit(SocialServiceBean.java:195) [classes:]
at org.otika.honeybee.util.SocialServiceBean$Proxy$$$WeldClientProxy.serviceInit(SocialServiceBean$Proxy$$$_WeldClientProxy.java) [classes:]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [rt.jar:1.7.0_11]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) [rt.jar:1.7.0_11]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [rt.jar:1.7.0_11]
at java.lang.reflect.Method.invoke(Method.java:601) [rt.jar:1.7.0_11]
at org.apache.el.parser.AstValue.invoke(AstValue.java:262) [jbossweb-7.0.13.Final.jar:]
at org.apache.el.MethodExpressionImpl.invoke(MethodExpressionImpl.java:278) [jbossweb-7.0.13.Final.jar:]
at org.jboss.weld.util.el.ForwardingMethodExpression.invoke(ForwardingMethodExpression.java:39) [weld-core-1.1.5.AS71.Final.jar:2012-02-10 15:31]
at org.jboss.weld.el.WeldMethodExpression.invoke(WeldMethodExpression.java:50) [weld-core-1.1.5.AS71.Final.jar:2012-02-10 15:31]
at com.sun.faces.facelets.el.TagMethodExpression.invoke(TagMethodExpression.java:105) [jsf-impl-2.1.7-jbossorg-2.jar:]
at com.sun.faces.facelets.tag.jsf.core.DeclarativeSystemEventListener.processEvent(EventHandler.java:128) [jsf-impl-2.1.7-jbossorg-2.jar:]
at javax.faces.component.UIComponent$ComponentSystemEventListenerAdapter.processEvent(UIComponent.java:2486) [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
at javax.faces.event.SystemEvent.processListener(SystemEvent.java:106) [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
at com.sun.faces.application.ApplicationImpl.processListeners(ApplicationImpl.java:2168) [jsf-impl-2.1.7-jbossorg-2.jar:]
at com.sun.faces.application.ApplicationImpl.invokeComponentListenersFor(ApplicationImpl.java:2116) [jsf-impl-2.1.7-jbossorg-2.jar:]
at com.sun.faces.application.ApplicationImpl.publishEvent(ApplicationImpl.java:288) [jsf-impl-2.1.7-jbossorg-2.jar:]
at com.sun.faces.application.ApplicationImpl.publishEvent(ApplicationImpl.java:246) [jsf-impl-2.1.7-jbossorg-2.jar:]
at org.jboss.as.weld.webtier.jsf.ForwardingApplication.publishEvent(ForwardingApplication.java:293) [jboss-as-weld-7.1.1.Final.jar:7.1.1.Final]
at com.sun.faces.lifecycle.RenderResponsePhase.execute(RenderResponsePhase.java:108) [jsf-impl-2.1.7-jbossorg-2.jar:]
at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:101) [jsf-impl-2.1.7-jbossorg-2.jar:]
at com.sun.faces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:139) [jsf-impl-2.1.7-jbossorg-2.jar:]
at javax.faces.webapp.FacesServlet.service(FacesServlet.java:594) [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:329) [jbossweb-7.0.13.Final.jar:]
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:248) [jbossweb-7.0.13.Final.jar:]
at org.otika.honeybee.util.UriFilter.doFilter(UriFilter.java:96) [classes:]
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:280) [jbossweb-7.0.13.Final.jar:]
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:248) [jbossweb-7.0.13.Final.jar:]
at org.primefaces.webapp.filter.FileUploadFilter.doFilter(FileUploadFilter.java:79) [primefaces-3.5.jar:]
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:280) [jbossweb-7.0.13.Final.jar:]
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:248) [jbossweb-7.0.13.Final.jar:]
at org.jboss.weld.servlet.ConversationPropagationFilter.doFilter(ConversationPropagationFilter.java:62) [weld-core-1.1.5.AS71.Final.jar:2012-02-10 15:31]
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:280) [jbossweb-7.0.13.Final.jar:]
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:248) [jbossweb-7.0.13.Final.jar:]
at org.agorava.core.web.CaptureAbsolutePathFilter.doFilter(CaptureAbsolutePathFilter.java:51) [agorava-core-impl-0.6.1.jar:]
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:280) [jbossweb-7.0.13.Final.jar:]
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:248) [jbossweb-7.0.13.Final.jar:]
at org.ocpsoft.rewrite.servlet.RewriteFilter.doFilter(RewriteFilter.java:199) [rewrite-servlet-2.0.5.Final.jar:2.0.5.Final]
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:280) [jbossweb-7.0.13.Final.jar:]
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:248) [jbossweb-7.0.13.Final.jar:]
at org.otika.honeybee.util.CharacterEncodingChecker.doFilter(CharacterEncodingChecker.java:32) [classes:]
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:280) [jbossweb-7.0.13.Final.jar:]
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:248) [jbossweb-7.0.13.Final.jar:]
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:275) [jbossweb-7.0.13.Final.jar:]
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:161) [jbossweb-7.0.13.Final.jar:]
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:397) [jbossweb-7.0.13.Final.jar:]
at org.jboss.as.jpa.interceptor.WebNonTxEmCloserValve.invoke(WebNonTxEmCloserValve.java:50) [jboss-as-jpa-7.1.1.Final.jar:7.1.1.Final]
at org.jboss.as.web.security.SecurityContextAssociationValve.invoke(SecurityContextAssociationValve.java:153) [jboss-as-web-7.1.1.Final.jar:7.1.1.Final]
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:155) [jbossweb-7.0.13.Final.jar:]
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) [jbossweb-7.0.13.Final.jar:]
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) [jbossweb-7.0.13.Final.jar:]
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:368) [jbossweb-7.0.13.Final.jar:]
at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:877) [jbossweb-7.0.13.Final.jar:]
at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:671) [jbossweb-7.0.13.Final.jar:]
at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:930) [jbossweb-7.0.13.Final.jar:]
at java.lang.Thread.run(Thread.java:722) [rt.jar:1.7.0_11]

---

Refactor Fql elements into a separate package

The Fql* elements in org.agorava.facebook.model seem quite separate and not like true "model" objects.
Would it be possible to factor these into a separate sub-package like org.agorava.facebook.fql instead?
Unless modularization should be taken further it probably doesn't have to go into a new Maven module, API looks fine.

See https://issues.jboss.org/browse/AGOVA-50 maintaining the task with actual connector, allowing the JIRA ticket to be closed eventually.