Comments (3)
Back when this plugin was conceived rollup did not allow for null or undefined to be passed in as entries in the plugin array. However, this is not the case anymore and the syntax you provided does exactly the same thing.
The only potential benefit would then be readability, but that lies in the eyes of the beholder:
export default {
plugins: [
...isProduction ? [
plugin1(),
plugin2()),
...isSomethingElse ? [
plugin3(),
plugin4()
] : []
] : []
]
}
vs
export default {
plugins: [
conditional(isProduction, [
plugin1(),
plugin2()),
conditional(isSomethingElse, [
plugin3(),
plugin4()
])
])
]
}
I'll look into some use cases and if I don't receive any complaints then I'll consider retiring this plugin.
from rollup-plugin-conditional.
Ah, historical reasons makes sense. x && …
or ...x ? […] : []
are certainly more efficient inasmuch as they don’t even instantiate the plugin. If you want an interesting closely related domain where ergonomic wins could be achieved, when a plugin isn’t needed most people still import it, and that importing can be surprisingly expensive sometimes. I myself make a habit of only importing what I need. I recently showed in rollup/rollup#2627 how to combine an async IIFE and dynamic imports to avoid unnecessary imports, but that pattern can get very messy when multiple inputs are involved.
from rollup-plugin-conditional.
I’ve decided to retire this plugin and recommend the syntax discussed in this thread. This has been documented in the readme. Thanks for your input @chris-morgan
from rollup-plugin-conditional.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rollup-plugin-conditional.