agronkabashi/rollup-plugin-conditional

Conditionally execute rollup plugins.

rollup-plugin-conditional's Issues

Update README with badges

Badges can be created here: https://shields.io/#/

Consider adding:

• dependencies
• size
• downloads (npm)
• license
• version

Compatibility with rollup v1.1

• Add writeBundle hook
• Conform to documentation regarding parallel/sequential execution

Terser or Uglify doesn't execute inside a Conditional

Am I misusing the api? Expected behavior is if the conditional is true the bundle gets minified...

My rollup config looks like this:

// rollup.config.js
...
import { terser } from 'rollup-plugin-terser'
import { argv } from 'yargs'

const isProduction = argv.configProd === true

export default [{
 ...
  plugins: [
    babel({ exclude: 'node_modules/**' }),
    commonjs(),
    resolve(),
    conditional(isProduction, [
      terser()
    ])
  ]
...
}]

Why does this plugin exist?

Take the usage example:

export default {
  plugins: [
    conditional(isProduction, [
      licence(),
      strip(),
      uglify(),
      gzip()
    ]),

    conditional(!isProduction, [
      filesize()
    ])
  ]
})

Is this not equivalent to the following (using two different styles):

export default {
  plugins: [
    ...isProduction ? [
      licence(),
      strip(),
      uglify(),
      gzip()
    ] : [],

    !isProduction && filesize()
  ]
})

Is there some other advantage to this plugin that I’m missing?

Reduce complexity by removing deprecated hooks

In order to increase backwards compatibility, support for deprecated rollup API calls was added in 2.1.1.

These code changes should be reverted after rollup v1.0 is released.