Giter Site home page Giter Site logo

equipmentcompare's Introduction

Hey there, I'm Grend.

I'm currently doing indie game development for a small studio and spending a lot of my free time on modding and personal projects.

Note that I am not currently accepting pull requests on any repositories. However, if you've discovered a bug or want to request a new feature, I'll be happy to implement this myself. Just raise an issue.

You can check out some of my open source projects here, or you can find me elsewhere on the web:


 🏠 Website

  CurseForge

  NexusMods

  Discord

equipmentcompare's People

Contributors

ahilyard avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

equipmentcompare's Issues

[Fabric/1.18.2] Compare tooltip fails to display when comparing trinkets

When hovering an item that can be equipped as a trinket, an InvokationTargetException is thrown by the call to TrinketSlot.canInsert() in TrinketsHandler, causing the tooltip to not display.

This is caused by an incompatibility with newer Trinkets versions, updating the included Cardinal Components dependencies seems to resolve the issue.

Versions:

  • Minecraft 1.18.2
  • Fabric Loader: 0.13.3
  • Fabric API: 1.0.38
  • Equipment Compare: 1.2.11
  • Trinkets: 3.3.0

Ver. 1.3.6. ignores Keybinds, reverts to default

Running on Fabric Loader 0.14.21-1.20.1
All changes to keybinds are ignored and instead reverted to their respective defaults upon launching this version.
The menu still displays whatever the keybinds are set to, however the changes don't take effect.

Rendering Bug found for Minecraft MC 1.12.2

The Last new Mod was SnowTime Mod Version 1.0 and I think it give in this area a Problem then I look then the crash was. In the main menu is all good and only by the Singleplayer area of Worlds crash the game. I hope you can a Fix for Minecraft MC 1.12.2 in next time make.

---- Minecraft Crash Report ----

WARNING: coremods are present:
Fluidlogged API Plugin (Fluidlogged-API-v1.8.1e-mc1.12.2.jar)
Contact their authors BEFORE contacting forge

// Surprise! Haha. Well, this is awkward.

Time: 10/17/22 7:05 PM
Description: Rendering screen

java.lang.NullPointerException: Rendering screen
at com.anthonyhilyard.equipmentcompare.gui.ComparisonTooltips.render(ComparisonTooltips.java:142)
at com.anthonyhilyard.equipmentcompare.gui.ComparisonTooltips.render(ComparisonTooltips.java:130)
at net.minecraft.client.gui.GuiScreen.handler$zza000$renderTooltip(GuiScreen.java:791)
at net.minecraft.client.gui.GuiScreen.drawHoveringText(GuiScreen.java)
at net.minecraft.client.gui.GuiScreen.func_146283_a(GuiScreen.java:177)
at net.minecraft.client.gui.GuiWorldSelection.func_73863_a(SourceFile:110)
at net.minecraftforge.client.ForgeHooksClient.drawScreen(ForgeHooksClient.java:396)
at net.minecraft.client.renderer.EntityRenderer.func_181560_a(EntityRenderer.java:1124)
at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1119)
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:398)
at net.minecraft.client.main.Main.main(SourceFile:123)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head --
Thread: Client thread
Stacktrace:
at com.anthonyhilyard.equipmentcompare.gui.ComparisonTooltips.render(ComparisonTooltips.java:142)
at com.anthonyhilyard.equipmentcompare.gui.ComparisonTooltips.render(ComparisonTooltips.java:130)
at net.minecraft.client.gui.GuiScreen.handler$zza000$renderTooltip(GuiScreen.java:791)
at net.minecraft.client.gui.GuiScreen.drawHoveringText(GuiScreen.java)
at net.minecraft.client.gui.GuiScreen.func_146283_a(GuiScreen.java:177)
at net.minecraft.client.gui.GuiWorldSelection.func_73863_a(SourceFile:110)
at net.minecraftforge.client.ForgeHooksClient.drawScreen(ForgeHooksClient.java:396)

-- Screen render details --
Details:
Screen name: net.minecraft.client.gui.GuiWorldSelection
Mouse location: Scaled: (105, 134). Absolute: (421, 437)
Screen size: Scaled: (480, 244). Absolute: (1920, 974). Scale factor of 4
Stacktrace:
at net.minecraft.client.renderer.EntityRenderer.func_181560_a(EntityRenderer.java:1124)
at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1119)
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:398)
at net.minecraft.client.main.Main.main(SourceFile:123)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

-- System Details --
Details:
Minecraft Version: 1.12.2
Operating System: Windows 10 (amd64) version 10.0
Java Version: 1.8.0_51, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
Memory: 322403768 bytes (307 MB) / 1073741824 bytes (1024 MB) up to 10737418240 bytes (10240 MB)
JVM Flags: 8 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xmx10G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M
IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0
FML: MCP 9.42 Powered by Forge 14.23.5.2860 12 mods loaded, 12 mods active
States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored

| State  | ID                | Version      | Source                               | Signature                                |
|:------ |:----------------- |:------------ |:------------------------------------ |:---------------------------------------- |
| LCHIJA | minecraft         | 1.12.2       | minecraft.jar                        | None                                     |
| LCHIJA | mcp               | 9.42         | minecraft.jar                        | None                                     |
| LCHIJA | FML               | 8.0.99.99    | forge-1.12.2-14.23.5.2860.jar        | e3c3d50c7c986df74c645c0ac54639741c90a557 |
| LCHIJA | forge             | 14.23.5.2860 | forge-1.12.2-14.23.5.2860.jar        | e3c3d50c7c986df74c645c0ac54639741c90a557 |
| LCHIJA | equipmentcompare  | 1.3.3        | EquipmentCompare-1.12.2-1.3.3.jar    | None                                     |
| LCHIJA | firstaid          | 1.6.21       | firstaid-1.6.21.jar                  | 7904c4e13947c8a616c5f39b26bdeba796500722 |
| LCHIJA | fluidlogged_api   | 1.8.1e       | Fluidlogged-API-v1.8.1e-mc1.12.2.jar | None                                     |
| LCHIJA | legendarytooltips | 1.1.8        | LegendaryTooltips-1.12.2-1.1.8.jar   | None                                     |
| LCHIJA | payday            | 3.0          | payday-3.2-1.12.2.jar                | None                                     |
| LCHIJA | quickstore        | 1.4          | quickstore-1.5.jar                   | None                                     |
| LCHIJA | snowtime          | 1.0-SNAPSHOT | snowtime-1.0-SNAPSHOT.jar            | None                                     |
| LCHIJA | worlddefender     | 1.2.0        | worldDefender-1.2.0.jar              | None                                     |

Loaded coremods (and transformers): 

Fluidlogged API Plugin (Fluidlogged-API-v1.8.1e-mc1.12.2.jar)
git.jbredwards.fluidlogged_api.mod.asm.ASMHandler$Transformer
GL info: ' Vendor: 'NVIDIA Corporation' Version: '4.6.0 NVIDIA 522.25' Renderer: 'NVIDIA GeForce GTX 1060 6GB/PCIe/SSE2'
Launched Version: 1.12.2-forge-14.23.5.2860
LWJGL: 2.9.4
OpenGL: NVIDIA GeForce GTX 1060 6GB/PCIe/SSE2 GL version 4.6.0 NVIDIA 522.25, NVIDIA Corporation
GL Caps: Using GL 1.3 multitexturing.
Using GL 1.3 texture combiners.
Using framebuffer objects because OpenGL 3.0 is supported and separate blending is supported.
Shaders are available because OpenGL 2.1 is supported.
VBOs are available because OpenGL 1.5 is supported.

Using VBOs: Yes
Is Modded: Definitely; Client brand changed to 'fml,forge'
Type: Client (map_client.txt)
Resource Packs: 
Current Language: English (US)
Profiler Position: N/A (disabled)
CPU: 6x Intel(R) Core(TM) i5-8400 CPU @ 2.80GHz

Cant turn off after it turns on

I have tried different keybinds but all are the same. When I hold my cursor over an item (axe) and hold the bound key (P) it shows the compare tooltip, but then the tool tip wont ever go away, whether I'm holding the bound key or not.

It's like the "show/hide" option is toggled on and never toggled off.

Multiplayer Server: MC 1.18.2, Fabric-API 0.58.0, Iceberg 1.0.38

1.3.8 don't work on Fabric 1.20.x

I have this error when I start Fabric 1.20:

Incompatible mods found!
net.fabricmc.loader.impl.FormattedException: Some of your mods are incompatible with the game or each other!
A potential solution has been determined, this may resolve your problem:
- Replace mod 'Inventory Tabs' (inventory-tabs) 1.1.8+1.20 with any version that is compatible with:
- minecraft 1.20
- Replace mod 'Forge Config API Port' (forgeconfigapiport) 7.0.0 with version 8.0 or later.
More details:
- Mod 'LibGui' (libgui) 8.1.0+1.20.1 requires version 1.20.1 of 'Minecraft' (minecraft), but only the wrong version is present: 1.20!
- Mod 'Equipment Compare' (equipmentcompare) 1.3.8 requires version 8.0 or later of mod 'Forge Config API Port' (forgeconfigapiport), but only the wrong version is present: 7.0.0!
- Mod 'Inventory Tabs' (inventory-tabs) 1.1.8+1.20 requires version 1.20.1 or later of 'Minecraft' (minecraft), but only the wrong version is present: 1.20!
- Mod 'Jankson' (jankson) 6.0.0+j1.2.3 requires version 1.20.1 or later of 'Minecraft' (minecraft), but only the wrong version is present: 1.20!
- Mod 'Tinfoiled Cotton Client Commands' (cotton-client-commands) 1.1.0+1.15.2 requires any version between 1.14- (inclusive) and 1.16- (exclusive) of 'Minecraft' (minecraft), but only the wrong version is present: 1.20!
- Mod 'ViaFabric for 1.14' (viafabric-mc114) 0.4.10+39-main requires any 1.14.x version of 'Minecraft' (minecraft), but only the wrong version is present: 1.20!
- Mod 'ViaFabric for 1.15' (viafabric-mc115) 0.4.10+39-main requires any 1.15.x version of 'Minecraft' (minecraft), but only the wrong version is present: 1.20!
- Mod 'ViaFabric for 1.16' (viafabric-mc116) 0.4.10+39-main requires any 1.16.x version of 'Minecraft' (minecraft), but only the wrong version is present: 1.20!
- Mod 'ViaFabric for 1.17' (viafabric-mc117) 0.4.10+39-main requires any 1.17.x version of 'Minecraft' (minecraft), but only the wrong version is present: 1.20!
- Mod 'ViaFabric for 1.18' (viafabric-mc118) 0.4.10+39-main requires any 1.18.x version of 'Minecraft' (minecraft), but only the wrong version is present: 1.20!
- Mod 'ViaFabric for 1.19' (viafabric-mc119) 0.4.10+39-main requires any 1.19.x version of 'Minecraft' (minecraft), but only the wrong version is present: 1.20!
at net.fabricmc.loader.impl.FormattedException.ofLocalized(FormattedException.java:51)
at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:195)
at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:146)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

But the lastest version of Forge Config API Port is 7.0.0 and it isn't need for this mod:

NVIDIA_Share_U6VjoY6rtY
NVIDIA_Share_7zYqswAeZd

Unconditionally cancelled inject causing compatibility issues on Fabric

The Fabric version of this mod contains an inject mixin in KeyMapping that is unconditionally cancelled. This is effectively the same as using an overwrite mixin, and is very bad practice:

@Inject(method = "resetMapping", at = @At(value = "HEAD"), cancellable = true)
private static void resetMapping(CallbackInfo info)
{
MAP.clear();
Iterator<?> var0 = ALL.values().iterator();
while (var0.hasNext())
{
KeyMapping keyMapping = (KeyMapping)var0.next();
if (!keyMapping.equals(EquipmentCompare.showComparisonTooltip))
{
MAP.put(keyMapping.key, keyMapping);
}
}
info.cancel();
}

Doing your mixin this way creates incompatibilities with one of my mods (specifically here (uses Yarn)) and is likely to create issues with other mods that modify keybind behaviour.

If possible, it'd be great if you could switch to a more limited injection scope, potentially making use of the excellent @WrapWithCondition provided by MixinExtras.

Ver 1.3.1 (mc 1.19.2) causes issue with Iris Mod

"The game crashed whilst initializing game
Error: java.lang.IncompatibleClassChangeError: class net.coderbot.iris.gui.option.ShadowDistanceOption cannot inherit from final class net.minecraft.client.OptionInstance"
Exit Code: -1

1.19.3 Update

Is it possible to make this mod compatible with 1.19.3? Thanks

Issues with comparison for gear with Tiers applied (TierZ, Tiered2, Tierify)

=============================
MC Version - Fabric - 1.20.1
Mod Version - Fabric 1.3.8
-Iceberg 1.1.18
-Cloth Config 11.1.106
-Forge Config Port 8.0.0
Modpack Name - Prominence 2 - Ver. 2.8.7

[Tierify version is 1.1.0, derived from Tiered2, which was derived from TierZ]

When comparing items from a Vanilla weapon for instance, it seems to work fine. e.g. 'Give' a vanilla weapon like a sword, axe etc.

Example: You spawn into a new world and have it set to give you a Vanilla MC Weapon, like a sword. That works fine, and in fact I can compare that Vanilla MC weapon to pretty much ANY modded weapon in fact.

However, holding a Modded Weapon or Vanilla 'Tiered' weapon results in either no comparison shown OR a brief 'flash' as if it's trying to pop up a Compare window, but it blinks and never stays.

For most things there's simply no indication at all that it's trying to compare. However, comparing a True 'Vanilla' Weapon / Tool to a Modded one held in hand ALWAYS results in a comparison. So, it seems it can enumerate / detect the attributes of a true vanilla weapon just fine AND it can enumerate the values of a Tiered weapon that's held, but not in comparison to anything else.

It appears to me that something with the Tierify is causing it to not see the item correctly.

NOTE: The pack in question is Prominence 2 an RPG Pack. Tierify controls the level of weapons when crafting. So, when you craft even a vanilla sword in a Crafting Table, with sticks and cobble, the resulting stone sword is given a randomly generated / rolled 'Rarity' or 'Tier'.

Weapons that ARE NOT Tiered don't seem to be a problem. However, any weapons that don't have a tier such as those that may be coming from some other mod, perhaps, seem to also work.

Thank you and I am attaching Screen Shots comparing the issue.

Screenshot 1 - Comparing a Tiered Wooden Sword to a held Vanilla Stone Sword.
Screenshot 2 - Comparing a Vanilla Stone Sword to a held Tiered Wooden Sword.
Screenshot 3 - Comparing a Tiered Modded Wand to a Held Vanilla Stone Sword
Screenshot 4 - Comparing a Vanilla Stone Sword to a Held Tiered Modded Wand

As you'll see from the screenshots; it doesn't appear that I can compare a 'Modded Tiered' Weapon, to anything else. However, I CAN successfully compare pretty much any Vanilla item, to a modded / tiered counterpart.
TieredWooden-HeldStone

VanillaStone-TieredWooden
TieredWand-HeldStone

VanillaStone-ModdedWand

layout issue on ATM9

Not quite sure where to change how the layout works. Everything overlaps as such:
image

REI and Crafting Table Support Feature Request Reminder (As well as enchantment table suggestion]

As you requested, here is the reminder to add REI compatibility, as well as the ability to compare equipment within the crafting table.

I also just thought of perhaps at the enchanting table, when ingredients are placed and it is showing an enchanted item to take from the table, one could be able to compare the stats of the enchanted item against the item's stats pre-enchantment. This would helpful in deciding if applying an enchantment is worth it.

[bug] comparison shows when I'm not wanting it too

Sometimes when I go into my inventory when I hover over an item it compares it when I'm not pressing shift. I have to press shift again to make it disappear. It doesn't happen all the time but it does happen pretty frequently

1.19.2

quilt

Modern UI Compatibility

Is there any way to make this be compatible with Modern UI mod?(Not need to set the relative option to false in it)

Possible mod conflict with accessories? - Fabric 1.21

console spams this error, I'm guessing that I use Accessories instead of trinkets?
Fabric 1.21
https://modrinth.com/mod/accessories
https://modrinth.com/mod/accessories-tc-layer

[08:31:43] [Render thread/ERROR]: java.lang.ClassNotFoundException: com.anthonyhilyard.equipmentcompare.compat.TrinketsHandler
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(Unknown Source)
	at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:226)
	at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:119)
	at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
	at java.base/java.lang.Class.forName0(Native Method)
	at java.base/java.lang.Class.forName(Unknown Source)
	at java.base/java.lang.Class.forName(Unknown Source)
	at com.anthonyhilyard.equipmentcompare.gui.ComparisonTooltips.render(ComparisonTooltips.java:174)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(Unknown Source)
	at java.base/java.lang.reflect.Method.invoke(Unknown Source)
	at net.minecraft.class_332.renderComparisonTooltips(class_332.java:6395)
	at net.minecraft.class_332.handler$dbp000$equipmentcompare$renderTooltipInternal(class_332.java:6441)
	at net.minecraft.class_332.method_51435(class_332.java)
	at net.minecraft.class_332.method_51437(class_332.java:651)
	at net.minecraft.class_465.method_2380(class_465.java:182)
	at moe.plushie.armourers_workshop.compatibility.client.gui.AbstractMenuScreenImpl.renderTooltip(AbstractMenuScreenImpl.java:39)
	at moe.plushie.armourers_workshop.core.client.gui.widget.ContainerMenuScreen._renderTooltip(ContainerMenuScreen.java:144)
	at com.apple.library.impl.WindowManagerImpl.render(WindowManagerImpl.java:104)
	at moe.plushie.armourers_workshop.core.client.gui.widget.ContainerMenuScreen.render(ContainerMenuScreen.java:67)
	at moe.plushie.armourers_workshop.compatibility.client.gui.AbstractMenuScreenImpl.method_25394(AbstractMenuScreenImpl.java:52)
	at net.minecraft.class_437.method_47413(class_437.java:117)
	at net.minecraft.class_757.mixinextras$bridge$method_47413$277(class_757.java)
	at net.minecraft.class_757.wrapOperation$dli000$fabric-screen-api-v1$onRenderScreen(class_757.java:5586)
	at net.minecraft.class_757.mixinextras$bridge$wrapOperation$dli000$fabric-screen-api-v1$onRenderScreen$278(class_757.java)
	at net.minecraft.class_757.wrapOperation$dpa000$fancymenu$wrapRenderScreenFancyMenu(class_757.java:6570)
	at net.minecraft.class_757.mixinextras$bridge$wrapOperation$dpa000$fancymenu$wrapRenderScreenFancyMenu$279(class_757.java)
	at net.minecraft.class_757.wrapOperation$fae000$konkrete$wrapRenderScreen_Konkrete(class_757.java:9102)
	at net.minecraft.class_757.method_3192(class_757.java:913)
	at net.minecraft.class_310.method_1523(class_310.java:1285)
	at net.minecraft.class_310.method_1514(class_310.java:882)
	at net.minecraft.client.main.Main.main(Main.java:256)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

Compat with JEI and EMI

It would be cool if it were possible to compare a tool/armor you hold/wear with one hovering in JEI/EMI. Currently that doesn't seem to be possible (1.20.1)

Latest version isn't labeled 1.18.2

Latest version of Equipment Compare has a file name of 1.18.1 when it's labeled as 1.18.2 on curseforge.
EquipmentCompare-1.18.1-1.2.12.jar

Just a nitpicky thing that I saw as I was going through mods.

Thank you for taking the time to create this mod.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.