ahmetkgunay/linkedinioshelper

LinkedIn iOS Fetch Member Information Library

linkedinioshelper's Issues

Login Failure error

Hi,
The redirection url after successful authorization of LinkedIn user consists of fragment identifier "#".
For eg I have logged in to Li and the final re-direction url is of form

https://www.google.com/?code=xxx&state=xxx#!

The SDK is failing to check the state in the service manager and the state in the url.
Received state in service manager in "xxx" but from url is "xxx#!" and fails while verifying it.
We must not consider the fragment identifier in the parameters. This is causing the error in login in SDK even if the user is logged in successfully in the webview.

How can we set permision in Swift

not able to set permission in Swift

LinkedInAuthorizationViewController customization

Hi!

It is possible to add some methods for customization of the WebView, NavigationBar, NavigationBarItem in the LinkedInAuthorizationViewController class?

Thanks!

Refresh token error

Hi,

I am getting the following error when I try and refresh tokens:

connection failed with response 503 (service unavailable)

Here is the code I wrote (placed on line 25 of the demo app)

if (linkedIn.isValidToken) {
        [linkedIn refreshAccessTokenWithSuccess:^(NSString *accessToken) {NSLog(@"Success");} failure:^(NSError *error){ NSLog(@"Error");}];
    }

Also the error block on the refresh access token doesn't look to have been called

Cheers

State

Hey,

Thanks for sharing this great library, I really like that there are no dependencies

I do have a concern however that the state is set statically in the code:

self.service = [LinkedInServiceManager serviceForPresentingViewController:_sender
                                                             cancelButtonText:self.cancelButtonText
                                                             appSettings:[LinkedInAppSettings settingsWithClientSecret:_clientSecret
                                                             clientId:_clientId
                                                             redirectUrl:_applicationWithRedirectURL
                                                             permissions:_permissions
                                                             state:@"DCEEFWF45453sdffef424"]];

Which means the state value is very easy to guess, opening it up to a possible CSFR attack.
https://developer.linkedin.com/docs/oauth2

Is there a way to set this in the client?

If not do would you be able to do a update so this can be set in the client through the requestMeWithSenderViewController: request or on the LinkedInHelper Object

Cheers

OAuth v.2

Does this framework support OAuth V.2.?

Storing the Token data securley

Hey,

This is the last and probably most important issue security-wise.

Could the LINKEDIN_TOKEN_KEY be stored in the secure keychain rather than the less secure NSUserDefaults?

Cheers

Logging out

Hey,

I am having trouble finding a way to clear the access keys out of the memory and log the user out

In schools they are often on shared devices and users need to login and out frequently.

Cheers