aholstenson/ecolect-js

Natural language handling for commands and intents

👋 Hi, I'm Andreas Holstenson

I work with user-centered problem solving using technology. You'll find me in Malmö, Sweden.

I enjoy building things and over the years on GitHub I've pushed 6614 commits, opened 45 issues and submitted 47 PRs. There's currently 25 repositories around here with 2038 stars.

Want to get in touch? Send me an e-mail at [email protected] or connect with me on LinkedIn.

ecolect-js's Issues

ecolect/values/ordinal is missing

const ordinal = require('ecolect/values/ordinal');

Error: Cannot find module 'ecolect/values/ordinal'

The parser exists under the language but is missing in values

CJS directory missing?

It seems that files were moved to /cjs directory, however this directory was never uploaded.
Is this intentional?

Can i change language ? ( simple way )

i tried to change the language to french, copy and past all the config en in another folder but it crash everytime.

Like if the new language can't be in another place then ecolect folder but i need it for my work every time i have the same error :
[node-red-contrib-ecolect/ecolect] SyntaxError: Unexpected token {

Some values match but are not included in result when using any

Consider the following examples

// ecolect 0.6.0
const ecolect = require('ecolect')
const en = require('ecolect/language/en')
const { any, dateTime } = require('ecolect/values')

const intents = ecolect.intentsBuilder(en)
	.intent('schedule:when')
		.value('when', dateTime())
		.value('remainder', any())
		.add('{when} {remainder}')
		.add('{remainder} {when}')
		.done()
	.build()

// "1s test" matches but only contains "remainder"
// "test 1s" matches with both "remainder" and "when"

// ecolect 0.7.0-beta.6
const { newPhrases, timeValue, anyTextValue } = require('ecolect')
const { en } = require('ecolect/language/en')

const matcher = newPhrases()
	.value('when', timeValue())
	.value('remainder', anyTextValue())
	.phrase('{when} {remainder}')
	.phrase('{remainder} {when}')
	.toMatcher(en)

// same as in 0.6.0
// "1s test" matches but only contains "remainder"
// "test 1s" matches with both "remainder" and "when"

Not just dateTime but number, enumeration, and possibly others seem to be effected when followed by an any value.

Skipable tokens

Currently 'in', 'at', 'for', 'a', 'an' are hard coded as skipable tokens. In my use of Ecolect I've found that it would be good to have a few more skipable tokens such as 'the' and 'by'.

Possibly this should be made a configuration item, either by intent or globally.

Dean

ecolect/values/time is missing

const ordinal = require('ecolect/values/time');

Error: Cannot find module 'ecolect/values/time'

The parser exists under the language but is missing in values

`Error: Multiple matches are only supported when in partial mode` when `any` matches input containing skipword

Consider this simplified example

// ecolect 0.6.0
const ecolect = require('ecolect')
const en = require('ecolect/language/en')
const { any } = require('ecolect/values')

const intents = ecolect.intentsBuilder(en)
	.intent('catchall')
		.value('any', any())
		.add('{any}')
		.done()
	.build()

// "test a" works fine ("any" == "test")
// "a test" works fine ("any" == "test")
// "test a test" results in `Error: Multiple matches are only supported when in partial mode`
// "test a a" also results in error
// "a a a" also results in error

Additionally, in some situations it seems that after triggering this error, it will break future matching for any expression, including ones that worked previously. I haven't been able to narrow this down yet.