please rename entry points to start with 'lammps.'

[aiidaplugins]

please rename entry points to start with 'lammps.'

[ltalirz]

Oh I see - in that case all good!

[ltalirz]

• add the "Framework::AiiDA" classifier to the setup.json

[JPchico]

I think all the entry points already start with lammps is there anything else that needs to be changed @chrisjsewell ?

[ltalirz]

Hey @JPchico , see here

aiida-lammps/setup.json

Lines 46 to 56 in 8f61854

	"dynaphopy = aiida_lammps.parsers.dynaphopy: DynaphopyParser"
	],
	"aiida.data": [
	"lammps.potential = aiida_lammps.data.potential:EmpiricalPotential",
	"lammps.trajectory = aiida_lammps.data.trajectory:LammpsTrajectory"
	],
	"lammps.potentials": [
	"eam = aiida_lammps.data.pot_plugins.eam:EAM",
	"lennard_jones = aiida_lammps.data.pot_plugins.lennard_jones:LennardJones",
	"reaxff = aiida_lammps.data.pot_plugins.reaxff:Reaxff",
	"tersoff = aiida_lammps.data.pot_plugins.tersoff:Tersoff"

[chrisjsewell]

Yeh it was only dynaphopy and that has been removed in the develop

[ltalirz]

aiida-lammps/pyproject.toml

Lines 77 to 81 in e7186d7

	[project.entry-points."lammps.potentials"]
	"eam" = "aiida_lammps.data.pot_plugins.eam:EAM"
	"lennard_jones" = "aiida_lammps.data.pot_plugins.lennard_jones:LennardJones"
	"reaxff" = "aiida_lammps.data.pot_plugins.reaxff:Reaxff"
	"tersoff" = "aiida_lammps.data.pot_plugins.tersoff:Tersoff"

[JPchico]

@ltalirz those potential types are going to be deprecated in the refactoring that we are doing, instead a single "lammps.lammps_potential" = "aiida_lammps.data.lammps_potential:LammpsPotentialData" will remain to take care of all the different potential types in a more general manner.

[chrisjsewell]

Yep but that is a lammps specific entry point group @ltalirz, not to do with aiida (I.e.there is no risk of clashes)