aimhubio/aimrocks

🎯 aimrocks 🎸 — python & cython bindings for RocksDB. Batteries included! 🔋

aimrocks's Issues

[QUESTION] disable WAL

Thanks for your lib !!

Is it possible to disable the WAL at write ? thanks

bump rocksdb version

I would like to try rocksdb with IOUring ( async operations ) , did you not bump the version of rocksdb for a reason , or it's just not necessary for your current usage ? thanks

[QUESTION] rocksDB version installed by wheel ?

FROM python:3.10-slim-bullseye
RUN python3 -m pip install aimrocks==0.2.1

is working directly , that mean it use https://packages.debian.org/source/bullseye/rocksdb , rocksdb (6.11.4-3) ?

Feature: more release targets

• binary wheels for Windows
• source distribution (.tar.gz) now that this is public

Trouble installing on apple silicon M1

Problem

When trying to install aim (which depends on aimrocks) with pip on MacOS with M1 chip I am getting this error:
ERROR: Could not find a version that satisfies the requirement aimrocks==0.0.10 (from aim) (from versions: none) ERROR: No matching distribution found for aimrocks==0.0.10

I suspect this happens because there are no pre-built binaries for M1 chip. To fix this issue please publish pre-built binaries for M1 arm architecture.
To save you time and resources I'm providing pre-built binaries on the specified environment from master branch using command python setup.py sdist bdist_wheel , if you need something from my side to fix this issue please feel free to contact me.

Download M1 binaries

Environment info:

OS: macOS 12.1 21C52 arm64
Host: MacBookPro18,3
Kernel: 21.2.0
DE: Aqua
CPU: Apple M1 Pro
GPU: Apple M1 Pro
Python: 3.10.x or 3.9.x
Pip: 21.2.4

Reproducing code example:

pip install aim==3.3.5
or
pip install aimrocks==0.0.10

setup.py is missing a license

setup.py file is missing classifiers field with license declaration, you already have a line like that in aim library:

classifiers=[
        'License :: OSI Approved :: Apache Software License',
    ]

this is really useful for automatic license checkers to figure out what dependency can be used in a commercial project

Feature: add support for OpenAsSecondary

Doc: https://github.com/facebook/rocksdb/wiki/Secondary-instance
Code: https://github.com/facebook/rocksdb/blob/v6.22.1/include/rocksdb/db.h#L192-L215

Conda package setup.py patch

The conda-forge package is now available at https://github.com/conda-forge/aimrocks-feedstock

Here is a patch against setup.py I am using in order to be able to build the package on the conda-forge infrastructure: https://github.com/conda-forge/aimrocks-feedstock/blob/main/recipe/setup_rocksdb.patch

That would be nice if you could integrate it here so we can remove the patch from the feedstock in the future.

It's not urgent and neither blocking for now.

ping @gorarakelyan

[BUG] close() -> SIGSEGV

ubuntu 20.04 , python 3.8

import aimrocks

db_options = dict(
    create_if_missing=True,
    paranoid_checks=False,
)

db_path = '/tmp/example_db2'
rocks_db = aimrocks.DB(db_path, aimrocks.Options(**db_options), read_only=False)

batch = aimrocks.WriteBatch()
batch.put(b'key_1', b'value_1')
batch.put(b'key_1', b'value_1')
...

rocks_db.write(batch)
rocks_db.close() # throw the error

rocks_db = aimrocks.DB(db_path, aimrocks.Options(**db_options), read_only=True)
rocks_db.get(b"key_1")
if __name__ == '__main__':
    pass

give

Process finished with exit code 139 (interrupted by signal 11: SIGSEGV)

Add source distribution (tar.gz)

Would it be possible to add a source distribution (tarball/tar.gz) here on github or on pypi? I would like to add this package to the conda-forge in order to make this package accessible to a wider user base.

[FEATURE] support BackupEngine

would be great to be able to create a backup from python code

WDYT ?

Python 3.12 wheels

Python 3.12 has been out for quite sometime now. Could you please provide wheels so that aim is easily installable on Python 3.12?