airbnb/react-with-direction

Components to provide and consume RTL or LTR direction in React

react-with-direction's Issues

Add support for React 16

React 16 is now released, so let's add it into our peerDependencies.

Legacy context usage prints warnings in React StrictMode

I noticed when using rheostat that this project is printing warnings in React StrictMode because it's using the legacy React Context instead of the one released in React 16.3. I understand this library would like to continue supporting React <16.3, but it also prevents using concurrent mode when that is eventually released into stable.

What is the long term strategy for releasing this library? Should there be a new major version/forked library which supports React 16.3+? Is it possible to feature-detect the new Context API and use that if it's available?

Add styles for DirectionProvider div or span

Is there a way to add styles for DirectionProvider? because I tried both using style or styled-components and I got errors like

Failed prop type: DirectionProvider: unknown props found: className

Typescript support

Please add types through @types or native

deepmerge is outdated

'deepmerge' is outdated so I've created this PR
#26

React 17

React 17 is around the corner and this package still relies on the unsafe componentWillRecieveProps. I attempted to make a pr to mark it as unsafe but this breaks with pre 16 react versions. Can we move forward and remove support for pre 16 react? If not switching to componentDidUpdate in this PR #14 seems like the logical way forward.

Expose ability to set classes on the DirectionProvider div

Hi,

Great tool first, no issues here but we have a requirement to apply a class to the div and was wondering if you might expose the ability to set this through the DirectionProvider.

Thanks.

npm install - removes other modules

Please provide installation guidelines.
Currently npm install react-with-direction breaks my project.
What am I missing?

Jest tests failing without module mock

Hi,

Jest tests fail on my project created with create-react-app.

One of the errors I get is:

 TypeError: Cannot read property 'propTypes' of undefined

      at withDirection (node_modules/react-with-direction/dist/withDirection.js:131:24)

This is very likely related to the provider (and the fact that tests don't have them). Other tests fail, but don't produce warnings realted to direction (although that is the cause).

For now I've mocked the react-with-direction module:

src/mocks/react-with-direction.js

let reactWithDirection = jest.genMockFromModule('react-with-direction');

reactWithDirection = {
  ...reactWithDirection,
  default: component => component
};

module.exports = reactWithDirection;

This seems to resolve it.

Is there a recommended solution for this?

Thanks!

Impact babel-plugin-transform-replace-object-assign

i getting the following error while importing DateRangePicker lib.

Configuring module specifier with a string is no longer supported. Configure with { "moduleSpecifier": "object.assign" } instead of "object.assign".

ERROR in ./node_modules/react-with-direction/dist/proptypes/brcast.js Module build failed (from ./node_modules/babel-loader/lib/index.js): Error: C:/work/POC/pq-client-develop/node_modules/react-with-direction/dist/proptypes/brcast.js: Configuring module specifier with a string is no longer supported. Configure with { "moduleSpecifier": "object.assign" } instead of "object.assign". at PluginPass.exit (C:\work\POC\pq-client-develop\node_modules\babel-plugin-transform-replace-object-assign\lib\index.js:23:19) at newFn (C:\work\POC\pq-client-develop\node_modules\babel-traverse\lib\visitors.js:276:21) at NodePath._call (C:\work\POC\pq-client-develop\node_modules\babel-traverse\lib\path\context.js:76:18) at NodePath.call (C:\work\POC\pq-client-develop\node_modules\babel-traverse\lib\path\context.js:48:17) at NodePath.visit (C:\work\POC\pq-client-develop\node_modules\babel-traverse\lib\path\context.js:117:8) at TraversalContext.visitQueue (C:\work\POC\pq-client-develop\node_modules\babel-traverse\lib\context.js:150:16) at TraversalContext.visitSingle (C:\work\POC\pq-client-develop\node_modules\babel-traverse\lib\context.js:108:19) at TraversalContext.visit (C:\work\POC\pq-client-develop\node_modules\babel-traverse\lib\context.js:192:19) at Function.traverse.node (C:\work\POC\pq-client-develop\node_modules\babel-traverse\lib\index.js:114:17) at traverse (C:\work\POC\pq-client-develop\node_modules\babel-traverse\lib\index.js:79:12) at File.transform (C:\work\POC\pq-client-develop\node_modules\babel-core\lib\transformation\file\index.js:516:35) at C:\work\POC\pq-client-develop\node_modules\babel-core\lib\transformation\pipeline.js:50:19 at File.wrap (C:\work\POC\pq-client-develop\node_modules\babel-core\lib\transformation\file\index.js:532:16) at Pipeline.transform (C:\work\POC\pq-client-develop\node_modules\babel-core\lib\transformation\pipeline.js:47:17) at transpile (C:\work\POC\pq-client-develop\node_modules\babel-loader\lib\index.js:50:20) at C:\work\POC\pq-client-develop\node_modules\babel-loader\lib\fs-cache.js:118:18 @ ./node_modules/react-with-styles/lib/withStyles.js 50:14-67 @ ./node_modules/react-dates/lib/components/CalendarMonth.js @ ./node_modules/react-dates/lib/index.js @ ./node_modules/react-dates/index.js @ ./src/js/components/CourseInfo/courseInfo.jsx @ ./src/js/components/CourseInfo/index.js @ ./src/js/components/index.js @ ./src/js/index.js @ multi (webpack)-dev-server/client?http://0.0.0.0:9000 ./src/js/index.js

i stuck by this.

Ref: https://github.com/newoga/babel-plugin-transform-replace-object-assign

error in typescript project

error in typescript project
Could not find a declaration file for module 'react-with-direction/dist/DirectionProvider'. 'D:/next project/gandom-front/node_modules/react-with-direction/dist/DirectionProvider.js' implicitly has an 'any' type.
Try npm i --save-dev @types/react-with-direction if it exists or add a new declaration (.d.ts) file containing declare module 'react-with-direction/dist/DirectionProvider';