ajaybhaga/commonj

Automatically exported from code.google.com/p/commonj

commonj's Issues

CloneUtilities.java:81: new HashMap<Object, Object>() --> cache

What steps will reproduce the problem?
1. Linked list with a.next = b and b.next = a
   (mutual circular reference, any circular reference that is more
    than just a.next = a)
2. clone a

What is the expected output? What do you see instead?
Expected: Proper cloning (using reflection, and cache to copy circular refs)
Actual: Stack overflow (infinite recursion)

What version of the product are you using? On what operating system?
Checked out on 2011-04-02 17:39 Eastern
.svn/entries says (not sure if this is version):
2010-05-25T15:11:58.486831Z

FIX:
        CloneUtilities.deepCloneReflectionInternal
          should use the cache it is given, not create new map each time:

    protected static final Object deepCloneReflectionInternal(Object original, Map<Object, Object> cache) throws Exception {
        ...
        Object clone = cloner.deepClone(original, new HashMap<Object, Object>());
        -->
        Object clone = cloner.deepClone(original, cache);

Original issue reported on code.google.com by [email protected] on 5 Apr 2011 at 7:20