ajnyga/embedhtmlarticlegalley

embedhtmlarticlegalley's Issues

getTemplatePath() does not work with OJS 3.1.2

getTemplatePath() throws a PHP error with OJS 3.1.2. I have made a few refinements so that the plugin works with OJS 3.1.2. Please have a look at mpbraendle@3ab0b2e for fixes:

• removed getTemplatePath() completely,
• moved display.tpl to a templates subdirectory
• call display.tpl via getTemplateResource() (see OJS-67 comment, this is from our internal issue tracking system.

EmbedHtmlArticleGalleyPlugin.inc.php is somewhat different to your version because it can handle also incomplete HTML (having no body element) uploaded by the publishers.

Also, I have extended the display.tpl template to display the associated (CC) license with the article text.

Please take over what you would like to.

Is it possible to see that plugin in action on an OJS journal ?

I had a quick look at journal.fi/, but I only saw articles in PDF format. Thank you.

Default CSS

If the original HTML does not contain any links to CSS files, use a default CSS file that will handle at least padding.

Extend existing HtmlArticleGalleyPlugin

We can reduce the code duplication (and automatically incorporate any future bugfixes/enhancements) by extending the existing HtmlArticleGalleyPlugin class. This would readily re-use the methods _getHTMLContents() and _handleOjsUrl().

Statistics and OJS 3.3

Hi,

Has this plugin been tested with OJS 3.3?
Does the views/download statistics for HTML work with this fix? (We made a fix to remove iframes from the plugin, but unfortunately it also resulted in the HTML views not being collected).

Add readme.md, change to GPL3 and request code check

OJS/OMP 3.4 Compatibility

Hi @ajnyga and @ctgraham ,

I work for the American Theological Library Association (Atla) and we've been using this plugin for years. Recently, I had to modify it in order to to be compatible with OJS 3.4. Would either of you be interested in that code? I'd be happy to push up the changes.

All the best.