ajthinking/data-story

A visual process builder

data-story's Issues

[not that important] Shift+T (Inspector shortcut key) is available before running

Shift + T the shortcut for the inspector is available before running the story.
Pressing this displays a blank page which you can only fix by reloading the page (losing, all the stuff and things).

Steps to replicate:

• open Data Story
• add some nodes
• press Shift + T

What is the purpes of this module ?

What is the impact on the code structure in laravel ? any good docs or whitepaper ?

Seems like it does not work with PostgreSQL

Using Composer 2, Laravel 8, and PostgreSQL

Ran composer require ajthinking/data-story --dev and I was greeted with the error below.
I am assuming that the issue could be that PostgreSQL is not supported.
Database exists, default tables are migrated and populated with seeders, no tables with the same name exists, and eloquent gets data from the DB.

composer require ajthinking/data-story --dev
Using version ^0.0.10 for ajthinking/data-story
./composer.json has been updated
Running composer update ajthinking/data-story
Loading composer repositories with package information
Updating dependencies
Lock file operations: 2 installs, 0 updates, 0 removals
  - Locking ajthinking/data-story (v0.0.10)
  - Locking calebporzio/sushi (v2.1.1)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 2 installs, 0 updates, 0 removals
  - Downloading calebporzio/sushi (v2.1.1)
  - Downloading ajthinking/data-story (v0.0.10)
  - Installing calebporzio/sushi (v2.1.1): Extracting archive
  - Installing ajthinking/data-story (v0.0.10): Extracting archive
Generating optimized autoload files
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover --ansi

   Illuminate\Database\QueryException 

  could not find driver (SQL: create table "stories" ("id" integer not null primary key autoincrement, "name" varchar, "path" varchar, "content" varchar, "deleted_at" varchar))

  at vendor/laravel/framework/src/Illuminate/Database/Connection.php:678
    674▕         // If an exception occurs when attempting to run a query, we'll format the error
    675▕         // message to include the bindings with SQL, which will make this exception a
    676▕         // lot more helpful to the developer instead of just the database's errors.
    677▕         catch (Exception $e) {
  ➜ 678▕             throw new QueryException(
    679▕                 $query, $this->prepareBindings($bindings), $e
    680▕             );
    681▕         }
    682▕ 

  1   [internal]:0
      DataStory\Models\Story::bootSushi()

  2   [internal]:0
      Illuminate\Foundation\Application::Illuminate\Foundation\{closure}()
Script @php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 1

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

LOVE the concept BTW

Mobx out of bounds

A warning appears when adding new nodes:
[mobx] Out of bounds read: 0

Find why and fix it

Class constructor NodeModel cannot be invoked without 'new'

What

While attempting to convert NodeModel.js to .ts this error occurs:
Class constructor NodeModel cannot be invoked without 'new'

Reproduce:

Rename NodeModel.js to .ts and fix warnings by declaring

export default class NodeModel extends DefaultNodeModel {
    options: any
    parent: any
    features: Feature[]
...

and adding a few :any in the closure/callbacks.

Browse to the app and add a new node. See the error appear in console.
Class constructor NodeModel cannot be invoked without 'new'

Test issue

test desc

Catched NodeJS Errors still propagate?

https://stackoverflow.com/questions/75941860/catched-nodejs-errors-still-propagate

How to reproduce:

• Add nodes: CreateJson, Throw
• Run
• Check server terminal logs

[Feature] - Put api and web routes into controller

Put api and web routes into controller + use request validation php artisan make:request ... just an idea

Refactor MobX store to use React context

Currently the store is injected as a prop in an old and opinionated way. Use React Context instead.

https://mobx.js.org/react-integration.html

Fix css issues on node ports/links

I have tried to model the ports and links after the FME software

Currently it looks like this:

Fix the following:

• the lines should be attached at the center point (now it is slighlty above center)
• the hover effect should only be applied when actually hovering the triangle or in its bounding box
• the drag and drop line should automatically attach only when on the actual triangle
• it should work with multiple ports as well

Collaboration

Do you have discord ? join here https://discord.gg/PQdkBTyrVN

Jest fails with 'self is not defined' when importing react-diagrams

tests/DiagramModel.test.ts

import { DiagramModel, NodeModelGenerics } from '@projectstorm/react-diagrams'

test('importing react diagrams', () => {
	// Uncomment this to make test fail!
    // DiagramModel
});

Throws

 ReferenceError: self is not defined

    > 1 | import { DiagramModel } from '@projectstorm/react-diagrams'
        | ^
      2 |
      3 | test('importing react diagrams', () => {
      4 |     let x = DiagramModel

      at Object.<anonymous> (node_modules/@projectstorm/react-diagrams/dist/index.umd.js:1:331)
      at Object.<anonymous> (tests/DiagramModel.test.ts:1:1)

Problems with user outside Model folder not found

If you test or migrate from laravel 5,6,7, you have User model in App/ and not inside App/Models/