akermu/krunner-pass

Integrates krunner with pass

krunner-pass's Issues

Consideration of upstreaming of krunner-pass into Plasma

I've tested this Krunner plugin today and I'm enthusiastic about it, it just works and makes my workflow to retrieve passwords as simple as it can be. Though KDE's former privacy goal just got replaced by new goals, I'm reasonably convinced that this plugin could be embraced by upstream Plasma as default shipped runner.

Simply put, it fits within KDE's aspiration of promoting a FOSS-based privacy ecosystem and a KRunner plugin for a tool like pass fits that clearly in my opinion:

Would you be interested in the potential upstreaming of your project?

/CC: @sebasje / @kossebau as they might have pointers on how this process could potentially work, as I wasn't able to find resources on this...

Any plans to cut a new release?

It's been a while and a number of fixes have since made it into master.

Installation in Arch linux failed

Hello,

I tried to install it via yay and compiling process got stuck with this error:

-- Generating done
-- Build files have been written to: /home/waldauf/.cache/yay/krunner-pass/src/build
Scanning dependencies of target kcm_krunner_pass_autogen
[ 11%] Automatic MOC for target kcm_krunner_pass
[ 11%] Built target kcm_krunner_pass_autogen
[ 22%] Generating ui_config.h
Scanning dependencies of target kcm_krunner_pass
[ 33%] Building CXX object CMakeFiles/kcm_krunner_pass.dir/kcm_krunner_pass_autogen/mocs_compilation.o
In file included from /usr/include/KF5/KConfigWidgets/KCModule:1,
                 from /home/waldauf/.cache/yay/krunner-pass/src/build/kcm_krunner_pass_autogen/EWIEGA46WW/../../../krunner-pass-1.3.0/config.h:23,
                 from /home/waldauf/.cache/yay/krunner-pass/src/build/kcm_krunner_pass_autogen/EWIEGA46WW/moc_config.cpp:10,
                 from /home/waldauf/.cache/yay/krunner-pass/src/build/kcm_krunner_pass_autogen/mocs_compilation.cpp:2:
/usr/include/KF5/KConfigWidgets/kcmodule.h:14:10: fatal error: KAuthAction: No such file or directory
   14 | #include <KAuthAction>
      |          ^~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/kcm_krunner_pass.dir/build.make:86: CMakeFiles/kcm_krunner_pass.dir/kcm_krunner_pass_autogen/mocs_compilation.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:278: CMakeFiles/kcm_krunner_pass.dir/all] Error 2
make: *** [Makefile:160: all] Error 2
==> ERROR: A failure occurred in build().
    Aborting...
checking dependencies...

Package (1)          Old Version  Net Change

extra-cmake-modules  5.79.0-1      -0.83 MiB

Total Removed Size:  0.83 MiB

:: Do you want to remove these packages? [Y/n]
:: Processing package changes...
(1/1) removing extra-cmake-modules                                                                                                                  [-------------------------------------------------------------------------------------------] 100%
:: Running post-transaction hooks...
(1/1) Arming ConditionNeedsUpdate...

Can I ask you for help with what to do? Thank you.

EDIT:
KAuth is already installed:

extra/kauth 5.79.0-1 (326.4 KiB 928.5 KiB) [kf5] (Installed)
    Abstraction to system policy and authentication features

Stops working after system restart

I'm not sure what is causing this but whenever I restart my system passwords are no longer showing in krunner even though Pass is listed in the list of plugins.

Re-running install.sh script fixes the issue but it breaks again after another reboot.

I'm running Arch Linux with KDE Plasma 5.9.5.

krunner hangs after copying password after already copied additional action

With the following krunner-pass settings:

[Runners][Pass]
showAdditionalActions=true
showFullFileContentAction=false

[Runners][Pass][AdditionalActions][0]
Icon=user-identity
Name=Login
Regex=^login: (.+?)$

After doing a copy using the new Login action (which works), the next use of krunner-pass to copy the password causes krunner to hang. At this point I need to kill the process and restart krunner.

krunner does not hang if I try to copy the Login (or any other additional action) a second time, only when doing

1. Copy an additional action entry (using tab -> return, or a click on the icon)
2. Copy password (using return or click)

in that exact order.

Happens every time, using Arch Linux with all the latest updates.

Auto-type support

Would it be possible\feasible to add auto-type support in the style of https://github.com/carnager/rofi-pass ?? In short, multi-line pass files with field names.

foobarmysecurepassword
---
user: MyUser
SomeField: foobar
AnotherField: barfoo
url: http://my.url.foo
autotype: SomeField :tab UserName :tab AnotherField :tab pass

Any pass file with an autotype field will have its keystrokes sent to the active window. If no autotype field is available, the first line is coped to the clipboard as now.

krunner not showing programs after reboot

Every program i installed doesnt show in krunner (discord, opera, spotify...) i can start the programs when i open a terminal and type in the name of the program. When i open krunner and type in the name it looks like this:

When i press enter nothing happens.
I can still run preinstalled programs like Konsole, Kate, Kwrite, etc.
Im on Parrot OS 4.11 x86_64 , kernel 5.10.0-6parrot1-amd64

Aur Install: could not find development headers and libraries

makepkg was giving me errors like this:

In file included from /usr/include/KF5/KConfigWidgets/KCModule:1,
             from /home/samuel/aur/krunner-pass/src/krunner-pass-1.3.0/config.h:23,
             from /home/samuel/aur/krunner-pass/src/krunner-pass-1.3.0/config.cpp:24:
/usr/include/KF5/KConfigWidgets/kcmodule.h:29:10: fatal error: kauthaction.h: No such file or directory
#include <kauthaction.h>

I did the following things to resolve the problem:

• Added DBus to the find_package directive for Qt5
• Added Auth to the find_package directive for KF5
• Added include_directories("/usr/include/KF5/KAuth/") after the other include directives

I don't use CMake often so I don't know why I had to make these changes. It installed fine after that.

Doesn't clear plasma clipboard

The current buffer gets cleared after $PASSWORD_STORE_CLIP_TIME seconds, but the entry is still visible in the plasma clipboard widget.

Anyway to clear that entry as well?
Thanks!

Wayland support

It would be nice if this had wayland support. It could detect if it's running under wayland and then use wl-copy instead of xclip

Installation from AUR doesn't work

I tried installing from AUR using pacaur but something went wrong. Here you can see the output from the command:

Installation log

 » pacaur -S krunner-pass

:: Package krunner-pass not found in repositories, trying AUR...
:: resolving dependencies...
:: looking for inter-conflicts...

AUR Packages  (1) krunner-pass-1.0.0-1  
Repo Packages (1) extra-cmake-modules-5.32.0-1  

Repo Download Size:   0.00 MiB
Repo Installed Size:  0.41 MiB

:: Proceed with installation? [Y/n] 

:: Retrieving package(s)...
:: krunner-pass build files are up-to-date -- skipping
:: Checking krunner-pass integrity...
==> Making package: krunner-pass 1.0.1-1 (Thu 13 Apr 20:17:40 CEST 2017)
==> Retrieving sources...
  -> Downloading v1.0.1.tar.gz...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   127    0   127    0     0    208      0 --:--:-- --:--:-- --:--:--   207
100 15657    0 15657    0     0  11155      0 --:--:--  0:00:01 --:--:-- 8606k
==> Validating source files with md5sums...
    v1.0.1.tar.gz ... Passed
:: Building krunner-pass package(s)...
==> Making package: krunner-pass 1.0.1-1 (Thu 13 Apr 20:17:42 CEST 2017)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Installing missing dependencies...
resolving dependencies...
looking for conflicting packages...

Packages (1) extra-cmake-modules-5.32.0-1

Total Installed Size:  0.41 MiB

:: Proceed with installation? [Y/n] 
(1/1) checking keys in keyring                          [##############################] 100%
(1/1) checking package integrity                        [##############################] 100%
(1/1) loading package files                             [##############################] 100%
(1/1) checking for file conflicts                       [##############################] 100%
(1/1) checking available disk space                     [##############################] 100%
:: Processing package changes...
(1/1) installing extra-cmake-modules                    [##############################] 100%
:: Running post-transaction hooks...
(1/1) Arming ConditionNeedsUpdate...
==> WARNING: Using existing $srcdir/ tree
==> Starting build()...
-- The C compiler identification is GNU 6.3.1
-- The CXX compiler identification is GNU 6.3.1
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Warning (dev) at /usr/share/ECM/modules/ECMFindModuleHelpers.cmake:133 (message):
  Your project should require at least CMake 2.8.12 to use FindKF5.cmake
Call Stack (most recent call first):
  /usr/share/ECM/find-modules/FindKF5.cmake:52 (ecm_find_package_version_check)
  CMakeLists.txt:9 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") 
-- Found PythonInterp: /usr/bin/python (found version "3.6") 
-- Found KF5I18n: /usr/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.32.0") 
-- Found KF5Service: /usr/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.32.0") 
-- Installing in the same prefix as Qt, adopting their path scheme.
CMake Deprecation Warning at /usr/share/ECM/kde-modules/KDEInstallDirs.cmake:324 (message):
  QT_PLUGIN_INSTALL_DIR is deprecated, use KDE_INSTALL_QTPLUGINDIR instead.
Call Stack (most recent call first):
  /usr/share/ECM/kde-modules/KDEInstallDirs.cmake:379 (_define_relative)
  /usr/share/ECM/kde-modules/KDEInstallDirs.cmake:456 (_define_absolute)
  /usr/lib64/cmake/KF5Package/KF5PackageMacros.cmake:3 (include)
  /usr/lib64/cmake/KF5Package/KF5PackageConfig.cmake:49 (include)
  /usr/share/cmake-3.7/Modules/CMakeFindDependencyMacro.cmake:55 (find_package)
  /usr/lib64/cmake/KF5Plasma/KF5PlasmaConfig.cmake:52 (find_dependency)
  /usr/share/cmake-3.7/Modules/CMakeFindDependencyMacro.cmake:55 (find_package)
  /usr/lib64/cmake/KF5Runner/KF5RunnerConfig.cmake:39 (find_dependency)
  /usr/share/ECM/find-modules/FindKF5.cmake:74 (find_package)
  CMakeLists.txt:9 (find_package)


-- Found KF5Runner: /usr/lib64/cmake/KF5Runner/KF5RunnerConfig.cmake (found version "5.32.0") 
-- Found KF5TextWidgets: /usr/lib64/cmake/KF5TextWidgets/KF5TextWidgetsConfig.cmake (found version "5.32.0") 
-- Found KF5PlasmaQuick: /usr/lib64/cmake/KF5PlasmaQuick/KF5PlasmaQuickConfig.cmake (found version "5.32.0") 
-- Found KF5Notifications: /usr/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.32.0") 
-- Found KF5: success (found version "5.32.0") found components:  I18n Service Runner TextWidgets PlasmaQuick Notifications 
-- Looking for __GLIBC__
-- Looking for __GLIBC__ - found
-- Performing Test _OFFT_IS_64BIT
-- Performing Test _OFFT_IS_64BIT - Success
CMake Warning (dev) in CMakeLists.txt:
  No cmake_minimum_required command is present.  A line of code such as

    cmake_minimum_required(VERSION 3.7)

  should be added at the top of the file.  The version specified may be lower
  if you wish to support older CMake versions for this project.  For more
  information run "cmake --help-policy CMP0000".
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Configuring done
-- Generating done
-- Build files have been written to: /home/luke/.cache/pacaur/krunner-pass/src/build
Scanning dependencies of target krunner_pass_automoc
[ 25%] Automatic moc for target krunner_pass
Generating moc source pass.moc
Generating moc source krunner_pass_automoc.dir/moc_pass_I6FEOYELPXYBPW.cpp
Generating moc compilation krunner_pass_automoc.cpp
[ 25%] Built target krunner_pass_automoc
Scanning dependencies of target krunner_pass
[ 50%] Building CXX object CMakeFiles/krunner_pass.dir/pass.o
[ 75%] Building CXX object CMakeFiles/krunner_pass.dir/krunner_pass_automoc.o
[100%] Linking CXX shared module krunner_pass.so
[100%] Built target krunner_pass
==> Entering fakeroot environment...
==> Starting package()...
[ 25%] Automatic moc for target krunner_pass
[ 25%] Built target krunner_pass_automoc
[100%] Built target krunner_pass
Install the project...
-- Install configuration: "Release"
-- Installing: /home/luke/.cache/pacaur/krunner-pass/pkg/krunner-pass/usr/lib/qt/plugins/krunner_pass.so
-- Installing: /home/luke/.cache/pacaur/krunner-pass/pkg/krunner-pass/usr/share/kservices5/plasma-runner-pass.desktop
-- Installing: /home/luke/.cache/pacaur/krunner-pass/pkg/krunner-pass/usr/share/knotifications5/krunner_pass.notifyrc
==> Tidying install...
  -> Removing libtool files...
  -> Purging unwanted files...
  -> Removing static library files...
  -> Stripping unneeded symbols from binaries and libraries...
  -> Compressing man and info pages...
==> Checking for packaging issue...
==> Creating package "krunner-pass"...
  -> Generating .PKGINFO file...
  -> Generating .BUILDINFO file...
  -> Generating .MTREE file...
  -> Compressing package...
==> Leaving fakeroot environment.
==> Finished making: krunner-pass 1.0.1-1 (Thu 13 Apr 20:17:46 CEST 2017)
==> Cleaning up...
:: Installing krunner-pass package(s)...
:: krunner-pass package(s) failed to install. Check .SRCINFO for mismatching data with PKGBUILD.

---

After that, I cloned the repo and ran install.sh script manually - that worked correctly.