Giter Site home page Giter Site logo

akilesh-io / app.ruscello Goto Github PK

View Code? Open in Web Editor NEW
5.0 1.0 1.0 609 KB

Watch Movies Together

Home Page: https://app.filmingo.us

TypeScript 93.88% JavaScript 1.63% CSS 4.50%
media-player movies peerjs socket-io watch-party watch-together webrtc

app.ruscello's Introduction

Ola Amigo ๐ŸŽถ

a

app.ruscello's People

Contributors

akilesh-io avatar dependabot[bot] avatar nitz-prnv avatar

Stargazers

 avatar  avatar

Watchers

 avatar

Forkers

sanjaydevtech

app.ruscello's Issues

Dev Environment

Currently the frontend is hardcoded with production Backend URLs and PeerJs URLs.

This needs to be dynamic:

  • In development the URL should be pointing to localhost.
  • In production the URL should be pointing to production url.

This makes the setting up the dev server so easy.

Application Flow

There should be a clear documentation for Application flow.
The flow should be in both Use case perspective and Development perspective.

Code smells

  • React components should be inside .tsx
  • Utils should be inside .ts
  • Format the code
  • Replace arrow to named functions in useEffect
  • Clean up resources on useEffect
  • Remove sample file created as part of create-next-app
  • JSDoc for components and functions
  • Constants

ENV secrets

All the server configs needs to be parsed from a .env file.
This avoid the need to change the code to change the URL.

This .env file should be ignored from git.

The issue #8 describes the url to be dynamic, but a different approach from this issue can make #8 simpler.
For example, we can setup a different .env file for development and production. This approach makes the BACKEND Url dynamic and thus makes the #8 issue close-able without any development.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.