aklinker1/github-better-line-counts

Chrome extension that removes generated files from GitHub line counts

github-better-line-counts's Issues

Recalculate Diff Squares

Right now, the extension doesn't change the red/green/grey squares that visualize how much of the file was new code vs removed code.

I don't know how these are calculated... the grey blocks confuse me lol. Otherwise it'd be a simple ratio.

Diff does not show up in certain cases

Github has a redesign in preview mode, but when enabled you do not get any stats. The extension just does not work

Better "processing" UI

Right now I just set the display: none on the line counts while the extension recalculates the totals.

github-better-line-counts/src/components/DiffStat.ts

Lines 11 to 17 in 6e83f10

	// Render loading UI while calculating stats
	let additionsElement = getAdditionsElement();
	let deletionsElement = getDeletionsElement();
	if (additionsElement) additionsElement.style.display = "none";
	if (deletionsElement) deletionsElement.style.display = "none";

I want to leave them visible and put a loading indicator to the right of the numbers, between the line counts and the red/green squares (where the generated count now shows up)

Potentially bad interval for ensuring diff is visible

github-better-line-counts/src/entrypoints/content.ts

Lines 6 to 9 in 2b38f9b

	main();
	// TODO: schedule next interval for 1 second AFTER the main function finishes. If the main
	// function takes more than 1 second, it might cause problems.
	setInterval(main, SECOND);

Originally posted by @aklinker1 in #20 (comment)

Hover over changes to view original diff

Sometimes, when upgrading dependencies, it's nice to know the original count to see how many dependencies were added/removed.

So when hovering over the generated number, it should show the generated + and - for a quick reference.

Doesn't work with `yarn` out of the box

The thing is, when you create a new yarn project using yarn init, it will create a .gitattributes like the following:

/.yarn/**            linguist-vendored
/.yarn/releases/*    binary
/.yarn/plugins/**/*  binary
/.pnp.*              binary linguist-generated

yarn.lock is not added to linguist-generated because git by itself doesn't count .lock files

so this extension should probably look for any .lock files by itself

CI for Publishing Updates to Firefox, Chrome, and Edge (?)

I already have this setup for another one of my extensions, using publish-browser-extension.

I'd prefer this be a single bash script though, that way it can be ran locally and though github actions.

Couldn't count generated lines for private repo

I know there's mention of this:

Optional: To load the .gitattributes for private repos, you need to enter a GitHub personal access token.

But the thing is... I don't need nor use .gitattributes. For me the basic functionality is just enough.

Currently it just hangs into this state infinitely:

IMO for simple cases without .gitattributes, – extension has all the info just on the page: token shouldn't be needed.

I just tried to add github token though, and it suddenly worked. But it shouldn't require it.

I think it is a minor issue yet important enough to mention.

Failed to calculate diff: FetchError -- returns 404

This is for a private organization repository that uses SSO, so I'm not sure if this is an expected behaviour or not. I made sure to authorize the personal access token for the organization, but still no luck.

When I run this on the command line ( with the token, owner, repo, & pull number filled in properly ) it does return a JSON response though:

curl -L \
  -H "Accept: application/vnd.github+json" \
  -H "Authorization: Bearer <YOUR-TOKEN>" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  https://api.github.com/repos/OWNER/REPO/pulls/PULL_NUMBER

Correct diff calculations when ignoring whitespace

Currently, the extension ignores whether or not you've disabled whitespace diffs on the PR (?w=1 query param). It shows the counts you would regularly see without that query parameter.

There doesn't appear to be an API that supports this parameter, it will be have to be calculated manually? I don't know how to do that.

An alternative is to read the diff numbers from the page instead of using the GitHub API. But I can't figure out how to load those all for large PRs, using the API is simpler.

Counts wrongly calculated for multiple commits at `compare` page

The reason why the bug appears, it seems:

• It does not calculate the sum of the commit changes. Only the changes for the last commit.

Here an example for reproducing: 4f6cf9c...aff927f

It shows: 1 additions, 1 deletions, 0 generated
Should be: 38 additions, 27 deletions, 0 generated

Preview:

Show generated file count

Right now it's not super clear when the extension has finished recalculating the line counts, but adding the number of generated files would help with that.

See the screenshot for what I want it to look like:

Add Save Button/Saving Label to Options Page

Settings save automatically when changed, but that's not obvious at all. We need to add either a save button that saves the settings, or a label that says "saving..." and "Saved!" when updating the settings.

Doesn't work on commit and compare pages

For you to reproduce, check out those urls in this repository:

• commit page: dc0b3f0
• compare page: 32bbab1...dc0b3f0

Those both pages don't work and showing thousands lines of change.

Here I tried with my project, too:

Custom file lists

In the extension options, add:

• A list of files that are always ignored for all repos #14
• And a way to add a list of files for individual repos

The lists will just be strings that work with fast-blob, the library I use to test if a file is in the gitattributes.