alaa-khattab/node-project

Hi there 👋 I'm Alaa Khattab 👩‍💻

Full-Stack Web Developer

• 🌍 I'm based in Palestine
• 🔭 I’m currently working on Open Screenplay as Full-Stack python and React Developer
• 📫 How to reach me: [email protected]

Links:

Skills:

Github Stats:

node-project's Issues

File structure

Generally is ok, but few improvments are possible.

Why not create an assets folder where you can move words.txt.
Move router.js and utils.js to app folder.
And so on...

Generally speaking you want to leave the root directory clean with only the most important files, in this case index.js (where the servers starts), README, package.json and so on.

.gitignore, I can see the node_modules and npm-debug.log

I can see the node_modules and also npm-debug.log.

Usually you don't want this because node_modules are installed with npm install everytime someone downlaods your code and npm-debug.log is the result of some error in you computer while you were trying npm start.

Does that make sense?

You can add a .gitignore file and add both of them:

node_modules
npm-debug.log

Heroku link in the README?

More tests

Good job with the tests and continues integration!:) Really!

The next step is: If your life would depend on the app functioning correctly, would you feel comfortable with the number of tests your wrote and the edge cases you tested.

I think you can increase the number of tests on the backend and write some for the front-end.

High Cost on the Server Side

Dear,

I noticed this issue in your code, where you read the data from the text file everytime you have a request.
(https://github.com/Alaa-Khattab/node-project/blob/master/app/code.js#L2)
This will increase the cost on the server side and will cause high delay and bad user experience as well.
Also you process the results of the text every time inside the function.
(https://github.com/Alaa-Khattab/node-project/blob/master/app/code.js#L10)

In order to solve this issue, I recommend to do this process before calling the server and define it as a global variable then pass it throw the functions.

BR,

Intensive Requiest from the Frontend

Dear,

Each time you type/delete a character it fire's a request to the server. From design point of view, this will increase the demand on the server side and will increase the cost as well.
In order to solve such issue, you can manage it from server side or frontend side.
In case you want manage it from the server side, actually its hard to do it where the request doesn't has label and if you use cookies this will add more processes on the server.
So to solve this issue, its recommended to manage it from the frontend. where you can set a time out before triggering the request.

BR,