alchemyplatform/alchemy-flow-contracts

alchemy-flow-contracts's Issues

[Suggestion] add testGetNFTs.sh for testnet folder as well

Currently only mainnet has testGetNFTs.sh.

Flowverse Socks

Hello, #23 is still hanging and until Rarible fixes the way they link it is not possible to fetch much data from it.

In .find we have a predefined list of rarible IDS that are socks and we just use that to return Flowverse socks. Would this be somtehing that Alchemy are willing to accept. The code is here https://github.com/findonflow/find/blob/main/scripts/collections.cdc#L1315

TrartContractNFT: Verifying API changes, got "Error processing request"

After Alchemy APIs support TrartContractNFT, we verify API changes for TrartContractNFT, but got "Error processing request". Use the bellow links:

mainnet :
https://flow-mainnet.g.alchemy.com/v2/demo/getNFTMetadata/?owner=0x1c7ee996c28e0651&contractName=TrartContractNFT&contractAddress=0x6f01a4b0046c1f87&tokenId=110010300093

testnet :
https://flow-testnet.g.alchemy.com/v2/demo/getNFTMetadata/?owner=0x3e100699f7218d1d&contractName=TrartContractNFT&contractAddress=0x4e024b8545e52d07&tokenId=160020100019

We recheck and test our contracts using our scripts, that is okay! We need help~

Zero

NBATopshot - Empty Media data

Hi,

It seems like the media data for NBATopshot is always empty in the API response.
Does anyone have a solution for this?
or any place that we can fetch the cover image or video for NBATopshot NFT?

Here is an example:

{
    "ownerAddress": "0x4f9d7c7cd2fa288f",
    "nfts": [
        {
            "contract": {
                "name": "TopShot",
                "address": "0x0b2a3299cc857e29",
                "externalDomain": "",
                "contractMetadata": {
                    "storagePath": "/storage/MomentCollection",
                    "publicPath": "/public/MomentCollection",
                    "publicCollectionName": "TopShot.MomentCollectionPublic"
                }
            },
            "id": {
                "tokenId": "11673790",
                "tokenMetadata": {
                    "uuid": "35792465"
                }
            },
            "title": "Terry Rozier",
            "media": [],
            "metadata": {
                "metadata": [
                    {
                        "name": "FirstName",
                        "value": "Terry"
                    },
                    {
                        "name": "DraftTeam",
                        "value": "Boston Celtics"
                    },
                    {
                        "name": "PlayCategory",
                        "value": "Handles"
                    },
                    {
                        "name": "PlayerPosition",
                        "value": "F"
                    },
                    {
                        "name": "DateOfMoment",
                        "value": "2021-02-15 00:00:00 +0000 UTC"
                    }
                    .....
                ]
            }
        }
]```

TopShot: large account returns error response 500

Error processing request

to reproduce, https://flow-mainnet.g.alchemy.com/<API_KEY>/v1/getNFTs/?owner=0xfa57101aa0d55954&limit=2

Add a way to distinguish NFTs' traits from technical meta data

We would like to show the traits separately from all kinds of technical data. E.g. this requests curl https://flow-mainnet.g.alchemy.com/demo/v1/getNFTMetadata/?owner=0x9eef2e4511390ce4&contractName=Gaia&contractAddress=0x8b148183c28ff88f&tokenId=1117 shows:

{ ...,
"metadata": {
   "metadata": [{
       "name": "playmaking",
       "value": "78"
   }, {
       "name": "uri",
       "value": "/collection/ballerz//1012"
   }, {
       "name": "role",
       "value": "Player"
   }, {
       "name": "img",
       "value": "ipfs://QmaUhmEgy5Znagz2ayY2uyn5Xdbsvzm8PkBM1GghtsXihv/1012.png"
   }, {
       "name": "shooting",
       "value": "81"
   }, {
       "name": "jersey",
       "value": "Home"
   }, {
       "name": "title",
       "value": "BALLER #1012"
   }, {
       "name": "defense",
       "value": "86"
   }, {
       "name": "team",
       "value": "Cleveland Firebirds"
   }, {
       "name": "body",
       "value": "Human IV"
   }, {
       "name": "description",
       "value": "A basketball-inspired generative NFT living on the Flow blockchain"
   }, {
       "name": "accessories",
       "value": "None"
   }, {
       "name": "id",
       "value": "1012"
   }, {
       "name": "hair",
       "value": "Afro"
   }, {
       "name": "number",
       "value": "13"
   }, {
       "name": "dunks",
       "value": "82"
   }]
}
}

Hereof, we would like to distinguish fields title, description, img, uri, from fields number, dunks, body, team. The latter fields would be filters in our marketplace UI.

I suggest to describe a structure NFTTrait(name: String, value: Any) and add a field traits: [NFTTrait] to NFTData. I can make a PR for that, if you don't mind.

[Suggestion] if `token_uri` is provided, fetch and fill IPFS metadata data in NFT API response

There is only {raw: "ipfs: / / {CID}"} in the token_uri field of response data from NFT API.
It is recommended to fill with complete metadata json

Wrong name in MyNft test case

alchemy-flow-contracts/src/cadence/scripts/testGetNFTs.sh

Lines 20 to 23 in e49278a

	MyNft)
	echo "Eternal"
	flow scripts execute getNFTs.cdc --args-json '[{ "type": "Address", "value": "0x1f56a1e665826a52" }, { "type": "Dictionary", "value": [{ "key": { "type": "String", "value": "Shard" }, "value": { "type": "Array", "value": [{ "type": "UInt64", "value": "6014" }] } }] }]' --network mainnet
	;;

This shouldn't be associated with Eternal :)

Q: Add adapter for metadata stored on IPFS (Rarible)

Hey folks,

I look for a way to form a NFTData structure for our case, when we store the actual meta on IPFS. On chain, we store e.g. metaURI: ipfs://ipfs/QmThjic7hgsN1MfmxMtxU6nefWwSpqf9GTx9HfV2ArxRN4.
Is there a way to tell the Alchemy API fetch the data from IPFS?

[Suggestion] Collect each NFT contract logo, name, official website etc too

Hi,

Currently, this repo is only collecting the flow NFT contract address by each correspond PR.
But I guess each PR should also uploading their NFT contract metadata too, such as logo, name, official website, maketplace ...
Otherwise, for the other project like us, to make our app more user friendly, we need manually collecting each contract data by ourself. A public registration for those NFT contract will be ideal in here.

Otherwise which project need collect those info manually:
https://github.com/outblock/assets
https://github.com/portto/assets/tree/main/NFT/flow

Unable to get my nft details on alchemy

I have merged my PR in alchemy around 7 days back but my NFT data is not reflected in alchemy

https://flow-mainnet.g.alchemy.com/v2/x55g2mq4cqgez3m1bwlnld3230ou8e02/getNFTMetadata?owner=0xb759c620b47621d1&contractAddress=0x85b8bbf926dcddfa&contractName=NowggNFT&tokenId=26514