alcueca/erc7399

ERC7399 Solidity Interfaces

erc7399's Issues

feedback on eip

Using this ticket as for a place to leave feedback on the eip. I tried really digging in to the code today and found myself struggling to just understand the basic flash loan workflow. i tried referencing the eip but it wasn't that helpful in explaining the basics.

Would be nice to see a summary of the basic lending workflow somewhere:

borrower calls flash() on lender. lender transfers funds and calls borrower defined callback. borrower sends amount + fee back to lender

Something like that, perhaps with a little more detail, but not too much.

There is an existing summary on the eip at the top of the specification section:

A flash loan integrates two smart contracts using a callback pattern. These are called the lender and the callback receiver in this EIP.

In the same flash loan, assets are transferred to the loan receiver before the callback and expected in the payment receiver at the end of the callback. An additional amount of assets, called a fee, MIGHT be also required to the present in the payment receiver at the end of the callback.

I think this section could be a great place for a summary and the current wording could be improved. For example I found this section confusing because it says only "two smart contracts" are used but then the next sentence starts referencing two other smart contract "loan receiver" and "payment receiver". For that matter, "loan receiver" and "payment receiver" aren't really defined in the first sentence either. I would either avoid the use of some of these special terms in the intro paragraph or else I would provide a short definition as I use them. There are also some some stylistic deficiencies and the last sentence also has a grammatical mistake "to the present in the".

Overall I think this first part can be re-written with a more informative summary to bring people quickly up to speed.

Another thing that I think is lacking from this EIP is the actual advantages of using this new standard for flash loans. The "Motivation" section doesn't seem to be about motivation -- isn't it just a list of problems with other flash loan providers? I see theres a kind of summary at the top but not much about motivation.

I think it would be nice to have a clear list of advantages of using this new standard and what are the primary features that would make someone want to use this new standard.

For example in the Motivation section, one point made is:

Some lenders offer the ability to repay the loan using a asset that is different

Which made me think that this eip solves that. But from what I could tell, I dont think it does right? This eip doesn't support borrowing one currency and repaying in a different one right? To me having that sentence there implies that you should have it.

Anyways, the amount of work you guys have done so far is very evident just wanted to give you some feedback from someone who is looking at it for the first time.