alexanderdzhoganov/ckan-plugins

ckan-plugins's Issues

PartManager does not find pre-CKAN-installed mods with parts.

No mods shown in the list, at the very least have:
DMagic Orbital Science
MechJeb 2
Near Future Solar
Procedural Fairings
Procedural Parts
RemoteTech
ScanSat

When attempting an uninstall / reinstall, the following error message is seen:

See the end of this message for details on invoking
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.MissingMethodException: Method not found: 'System.Collections.Generic.Dictionary`2<System.String,CKAN.Version> CKAN.Registry.Installed()'.
at PartManagerPlugin.PartManagerUI.RefreshInstalledModsList()
at PartManagerPlugin.PartManagerUI.OnModChanged(CkanModule module, GUIModChangeType changeType)
at CKAN.Main.PostInstallMods(Object sender, RunWorkerCompletedEventArgs e)

PartManager throws exception and crashes CKAN

So, something happened while I was running PartManager and my system crashed. As a result a couple of files were lost in the transfer process. Now, when I launch CKAN and the next thing I do is click on the PartManager tab, CKAN crashes.

I tracked it down to PartManager expecting to find a .cfg file and it not being in the cache. Once I restored the expected files to the PartManager cache everything began working as expected.

You might want to capture said errors and offer the user options as to how to deal with the conflit. In this case it would have been beneficial to indicate that Impossible Innovations was not installed and delete the offending cache entries.

scott@Jupiter:~/Games/KSP_Active$ mono ckan.exe
4867 [1] ERROR CKAN.URLHandlers (null) - Error: Parsing Error: Could not parse file ~/.local/share/applications/mimeapps.list
4904 [1] WARN CKAN.PluginController (null) - Successfully instantiated type "MigrationToolPlugin, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null" from MigrationToolPlugin, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null.dll
4904 [1] WARN CKAN.PluginController (null) - Successfully instantiated type "PartManagerPlugin, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null" from PartManagerPlugin, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null.dll
System.IO.FileNotFoundException: Could not find file "/home/scott/Games/KSP_Active/CKAN/PartManager/cache/GameData/ImpossibleInnovations/Parts/Fuel/II-deuteriumx4/Dtankx4.cfg".
File name: '/home/scott/Games/KSP_Active/CKAN/PartManager/cache/GameData/ImpossibleInnovations/Parts/Fuel/II-deuteriumx4/Dtankx4.cfg'
at System.IO.FileStream..ctor (System.String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, Boolean anonymous, FileOptions options) [0x00000] in :0
at System.IO.FileStream..ctor (System.String path, FileMode mode, FileAccess access, FileShare share) [0x00000] in :0
at (wrapper remoting-invoke-with-check) System.IO.FileStream:.ctor (string,System.IO.FileMode,System.IO.FileAccess,System.IO.FileShare)
at System.IO.File.OpenRead (System.String path) [0x00000] in :0
at System.IO.StreamReader..ctor (System.String path, System.Text.Encoding encoding, Boolean detectEncodingFromByteOrderMarks, Int32 bufferSize) [0x00000] in :0
at System.IO.StreamReader..ctor (System.String path) [0x00000] in :0
at (wrapper remoting-invoke-with-check) System.IO.StreamReader:.ctor (string)
at System.IO.File.ReadAllText (System.String path) [0x00000] in :0
at PartManagerPlugin.ConfigNodeReader.FileToConfigNode (System.String inputFile) [0x00000] in :0
at PartManagerPlugin.PartManagerUI.LoadConfig () [0x00000] in :0
at PartManagerPlugin.PartManagerUI.PartManagerUI_Load (System.Object sender, System.EventArgs e) [0x00000] in :0
at System.Windows.Forms.UserControl.OnLoad (System.EventArgs e) [0x00000] in :0
at System.Windows.Forms.UserControl.OnCreateControl () [0x00000] in :0
at System.Windows.Forms.Control.CreateControl () [0x00000] in :0
at System.Windows.Forms.Control.WmShowWindow (System.Windows.Forms.Message& m) [0x00000] in :0
at System.Windows.Forms.Control.WndProc (System.Windows.Forms.Message& m) [0x00000] in :0
at System.Windows.Forms.ScrollableControl.WndProc (System.Windows.Forms.Message& m) [0x00000] in :0
at System.Windows.Forms.ContainerControl.WndProc (System.Windows.Forms.Message& m) [0x00000] in :0
at System.Windows.Forms.UserControl.WndProc (System.Windows.Forms.Message& m) [0x00000] in :0
at System.Windows.Forms.Control+ControlWindowTarget.OnMessage (System.Windows.Forms.Message& m) [0x00000] in :0
at System.Windows.Forms.Control+ControlNativeWindow.WndProc (System.Windows.Forms.Message& m) [0x00000] in :0
at System.Windows.Forms.NativeWindow.WndProc (IntPtr hWnd, Msg msg, IntPtr wParam, IntPtr lParam) [0x00000] in :0
System.ArgumentException: An element with the same key already exists in the dictionary.
at System.Collections.Generic.Dictionary`2[TKey,TValue].Add (System.Collections.Generic.TKey key, System.Collections.Generic.TValue value) [0x00000] in :0
at PartManagerPlugin.PartManagerUI.LoadConfig () [0x00000] in :0
at PartManagerPlugin.PartManagerUI.PartManagerUI_Load (System.Object sender, System.EventArgs e) [0x00000] in :0
at System.Windows.Forms.UserControl.OnLoad (System.EventArgs e) [0x00000] in :0
at System.Windows.Forms.UserControl.OnCreateControl () [0x00000] in :0
at System.Windows.Forms.Control.CreateControl () [0x00000] in :0
at (wrapper remoting-invoke-with-check) System.Windows.Forms.Control:CreateControl ()
at System.Windows.Forms.Control.CreateControl () [0x00000] in :0
at System.Windows.Forms.Control.WmShowWindow (System.Windows.Forms.Message& m) [0x00000] in :0
at System.Windows.Forms.Control.WndProc (System.Windows.Forms.Message& m) [0x00000] in :0
at System.Windows.Forms.ScrollableControl.WndProc (System.Windows.Forms.Message& m) [0x00000] in :0
at System.Windows.Forms.Control+ControlWindowTarget.OnMessage (System.Windows.Forms.Message& m) [0x00000] in :0
at System.Windows.Forms.Control+ControlNativeWindow.WndProc (System.Windows.Forms.Message& m) [0x00000] in :0
at System.Windows.Forms.NativeWindow.WndProc (IntPtr hWnd, Msg msg, IntPtr wParam, IntPtr lParam) [0x00000] in :0
X11 Error encountered:
Error: BadWindow (invalid Window parameter)
Request: 12 (0)
Resource ID: 0x4E00185
Serial: 5247
Hwnd: Hwnd, Mapped:True ClientWindow:0x4E00185, WholeWindow:0x4E00184, Zombie=True, Parent:[Hwnd, Mapped:True ClientWindow:0x4E00183, WholeWindow:0x4E00182, Zombie=True, Parent:[Hwnd, Mapped:True ClientWindow:0x4E0001A, WholeWindow:0x4E00019, Zombie=True, Parent:[Hwnd, Mapped:True ClientWindow:0x4E00018, WholeWindow:0x4E00017, Zombie=True, Parent:[]]]]
Control: PartManagerPlugin.PartManagerUI at System.Environment.get_StackTrace()
at System.Windows.Forms.XplatUIX11.HandleError(IntPtr display, XErrorEvent ByRef error_event)
at System.Windows.Forms.XplatUIX11.XFlush(IntPtr )
at System.Windows.Forms.XplatUIX11.PostQuitMessage(Int32 exitCode)
at System.Windows.Forms.XplatUI.PostQuitMessage(Int32 exitCode)
at System.Windows.Forms.Application.Exit(System.ComponentModel.CancelEventArgs e)
at System.Windows.Forms.Application.Exit()
at System.Windows.Forms.Application.OnThreadException(System.Exception t)
at System.Windows.Forms.NativeWindow.OnThreadException(System.Exception e)
at System.Windows.Forms.NativeWindow.WndProc(IntPtr hWnd, Msg msg, IntPtr wParam, IntPtr lParam)
at System.Windows.Forms.XplatUIX11.SendMessage(IntPtr hwnd, Msg message, IntPtr wParam, IntPtr lParam)
at System.Windows.Forms.XplatUIX11.CreateWindow(System.Windows.Forms.CreateParams cp)
at System.Windows.Forms.XplatUI.CreateWindow(System.Windows.Forms.CreateParams cp)
at System.Windows.Forms.NativeWindow.CreateHandle(System.Windows.Forms.CreateParams cp)
at System.Windows.Forms.Control.CreateHandle()
at System.Windows.Forms.Control.CreateControl()
at System.Windows.Forms.Control.SetVisibleCore(Boolean value)
at System.Windows.Forms.Control.set_Visible(Boolean value)
at System.Windows.Forms.TabPage.SetVisible(Boolean value)
at System.Windows.Forms.TabControl.set_SelectedIndex(Int32 value)
at System.Windows.Forms.TabControl.MouseDownHandler(System.Object sender, System.Windows.Forms.MouseEventArgs e)
at System.Windows.Forms.Control.OnMouseDown(System.Windows.Forms.MouseEventArgs e)
at System.Windows.Forms.Control.WmLButtonDown(Message ByRef m)
at System.Windows.Forms.Control.WndProc(Message ByRef m)
at System.Windows.Forms.TabControl.WndProc(Message ByRef m)
at System.Windows.Forms.Control+ControlWindowTarget.OnMessage(Message ByRef m)
at System.Windows.Forms.Control+ControlNativeWindow.WndProc(Message ByRef m)
at System.Windows.Forms.NativeWindow.WndProc(IntPtr hWnd, Msg msg, IntPtr wParam, IntPtr lParam)
at System.Windows.Forms.XplatUIX11.DispatchMessage(MSG ByRef msg)
at System.Windows.Forms.XplatUI.DispatchMessage(MSG ByRef msg)
at System.Windows.Forms.Application.RunLoop(Boolean Modal, System.Windows.Forms.ApplicationContext context)
at System.Windows.Forms.Application.Run(System.Windows.Forms.ApplicationContext context)
at System.Windows.Forms.Application.Run(System.Windows.Forms.Form mainForm)
at CKAN.Main..ctor(System.String[] cmdlineArgs, CKAN.GUIUser User, Boolean showConsole)
at CKAN.GUI.Main_(System.String[] args, Boolean showConsole)
at CKAN.CmdLine.MainClass.Gui(CKAN.CmdLine.GuiOptions options, System.String[] args)
at CKAN.CmdLine.MainClass.Main(System.String[] args)

KerbalStuffPlugin doesn't find installed libgluezilla

Was told to create the ticket here.
I get this error when I try to use the KerbalStuffPlugin by nlight:
libgluezilla not found. To have webbrowser support, you need libgluezilla installed
I have libmono-webbrowser2.0-cil and libmono-webbrowser4.0-cil installed on my Ubuntu 14.10 system.

PartManager Tab overwrites pre-existing tabs / doesn't become clickable until tab refresh is forced.

Screenshots:

Appearance prior to using "Refresh" to re-draw the tabs.

Appearance following refesh-redraw.

Never seems to become active

I installed the part manager using the "Add new" button on the CKAN Plugins page. Then I hit the Activate button.

Something happened, but I have no idea what. It starts showing a tab which says "Installed mods that contain parts", but nothing was listed.

I then tried to unload it, but the tab remained. It even remained after I restarted. I had to find where the dll was copied to (the Plugins directory) and delete it manually.

I'm not sure if this is a PartManager issue or a CKAN issue, I'm going to post this in the CKAN issues as well.

Crashing on Windows

there is a crash that occurs whenever I load this plugin in the latest version of CKAN:

See the end of this message for details on invoking 
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.MissingMethodException: Method not found: 'CKAN.Registry CKAN.KSP.get_Registry()'.
   at MigrationToolPlugin.MigrationToolUI.GetAutodetectedMods()
   at MigrationToolPlugin.MigrationToolUI.RefreshModsList()
   at MigrationToolPlugin.MigrationToolUI..ctor()
   at MigrationToolPlugin.MigrationToolPlugin.menuItem_Click(Object sender, EventArgs e)
   at System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e)
   at System.Windows.Forms.ToolStripMenuItem.OnClick(EventArgs e)
   at System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e)
   at System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e)
   at System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea)
   at System.Windows.Forms.ToolStripDropDown.OnMouseUp(MouseEventArgs mea)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ToolStrip.WndProc(Message& m)
   at System.Windows.Forms.ToolStripDropDown.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)


************** Loaded Assemblies **************
mscorlib
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1637.0 built by: NETFXREL3STAGE
    CodeBase: file:///C:/Windows/Microsoft.NET/Framework64/v4.0.30319/mscorlib.dll
----------------------------------------
ckan
    Assembly Version: 0.0.0.0
    Win32 Version: 0.0.0.0
    CodeBase: file:///C:/Users/Michael%20Wilcox/Desktop/ckan.exe
----------------------------------------
System.Configuration
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1586.0 built by: NETFXREL2
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Configuration/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll
----------------------------------------
System
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1637.0 built by: NETFXREL3STAGE
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System/v4.0_4.0.0.0__b77a5c561934e089/System.dll
----------------------------------------
System.Core
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1638.0 built by: NETFXREL3STAGE
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Core/v4.0_4.0.0.0__b77a5c561934e089/System.Core.dll
----------------------------------------
System.Xml
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1586.0 built by: NETFXREL2
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
System.Windows.Forms
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1586.0 built by: NETFXREL2
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms/v4.0_4.0.0.0__b77a5c561934e089/System.Windows.Forms.dll
----------------------------------------
System.Drawing
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1586.0 built by: NETFXREL2
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Drawing/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll
----------------------------------------
System.Transactions
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1586.0 built by: NETFXREL2
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_64/System.Transactions/v4.0_4.0.0.0__b77a5c561934e089/System.Transactions.dll
----------------------------------------
Accessibility
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1586.0 built by: NETFXREL2
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/Accessibility/v4.0_4.0.0.0__b03f5f7f11d50a3a/Accessibility.dll
----------------------------------------
Microsoft.GeneratedCode
    Assembly Version: 1.0.0.0
    Win32 Version: 4.6.1586.0 built by: NETFXREL2
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
System.Numerics
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1586.0 built by: NETFXREL2
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Numerics/v4.0_4.0.0.0__b77a5c561934e089/System.Numerics.dll
----------------------------------------
System.Runtime.Serialization
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1637.0 built by: NETFXREL3STAGE
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Runtime.Serialization/v4.0_4.0.0.0__b77a5c561934e089/System.Runtime.Serialization.dll
----------------------------------------
System.Xml.Linq
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1586.0 built by: NETFXREL2
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Xml.Linq/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.Linq.dll
----------------------------------------
System.Data
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1636.0 built by: NETFXREL3STAGE
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_64/System.Data/v4.0_4.0.0.0__b77a5c561934e089/System.Data.dll
----------------------------------------
Anonymously Hosted DynamicMethods Assembly
    Assembly Version: 0.0.0.0
    Win32 Version: 4.6.1637.0 built by: NETFXREL3STAGE
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_64/mscorlib/v4.0_4.0.0.0__b77a5c561934e089/mscorlib.dll
----------------------------------------
Microsoft.CSharp
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1586.0
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/Microsoft.CSharp/v4.0_4.0.0.0__b03f5f7f11d50a3a/Microsoft.CSharp.dll
----------------------------------------
System.Dynamic
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1586.0
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Dynamic/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Dynamic.dll
----------------------------------------
System.EnterpriseServices
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1586.0 built by: NETFXREL2
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_64/System.EnterpriseServices/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.EnterpriseServices.dll
----------------------------------------
MigrationToolPlugin
    Assembly Version: 1.0.0.0
    Win32 Version: 1.0.0.0
    CodeBase: file:///c:/program%20files%20(x86)/steam/SteamApps/common/Kerbal%20Space%20Program/CKAN/Plugins/MigrationToolPlugin.dll
----------------------------------------

************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.

For example:

<configuration>
    <system.windows.forms jitDebugging="true" />
</configuration>

When JIT debugging is enabled, any unhandled exception
will be sent to the JIT debugger registered on the computer
rather than be handled by this dialog box.

Segmentation faults on OSX when using MigrationTool

Over in KSP-CKAN/CKAN#1673 someone mentions "malloc errors" that only occur when MigrationTool is installed. I took a quick look, and I think the BackgroundWorker declared in line 17 of https://github.com/AlexanderDzhoganov/CKAN-plugins/blob/master/MigrationToolPlugin/MigrationToolUI.cs is the likely cause of the issue. It is probably ultimately an upstream bug in Mono on OSX specifically, but either way this is likely to cause a leak. If you dispose of it this way it will either fix the leak or fix the leak and fix potential segfaults on "exotic" Mono installs.

Note: I am unable to directly test or reproduce this issue because I don't have the requisite hardware.